Re: [f2fs-dev] [RFC PATCH] f2fs: reduce expensive checkpoint trigger frequency

2021-04-22 Thread heyunlei 00015531
在 2021/4/22 15:14, Chao Yu 写道: On 2021/4/22 12:06, Jaegeuk Kim wrote: On 04/16, Chao Yu wrote: We may trigger high frequent checkpoint for below case: 1. mkdir /mnt/dir1; set dir1 encrypted 2. touch /mnt/file1; fsync /mnt/file1 3. mkdir /mnt/dir2; set dir2 encrypted 4. touch /mnt/file2; fsync

Re: [f2fs-dev] [PATCH] f2fs: fsverity: Truncate cache pages if set verity failed

2021-02-25 Thread heyunlei 00015531
在 2021/2/25 7:11, Eric Biggers 写道: On Wed, Feb 24, 2021 at 03:02:52PM -0800, Eric Biggers wrote: Hi Yunlei, On Wed, Feb 24, 2021 at 09:16:24PM +0800, Chao Yu wrote: Hi Yunlei, On 2021/2/23 19:24, heyunlei wrote: If file enable verity failed, should truncate anything wrote past i_size

Re: [f2fs-dev] [PATCH] f2fs: move dir data flush to write checkpoint process

2018-11-06 Thread heyunlei
>-Original Message- >From: Yuchao (T) >Sent: Tuesday, November 06, 2018 5:20 PM >To: heyunlei; jaeg...@kernel.org; c...@kernel.org >Cc: linux-f2fs-devel@lists.sourceforge.net; miaoxie (A) >Subject: Re: [f2fs-dev][PATCH] f2fs: move dir data flush to write checkpoint

Re: [f2fs-dev] [PATCH RFC] Revert "f2fs: avoid cpu lockup"

2018-06-01 Thread heyunlei
>-Original Message- >From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >Sent: Friday, June 01, 2018 1:56 AM >To: heyunlei >Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian; >Zhangdianfang (Euler) >Subject: Re: [f2fs-dev][PATCH RFC] Revert "f2f

Re: [f2fs-dev] [PATCH v3] f2fs: build free nid bitmap during flush nat entries

2018-05-04 Thread heyunlei
Ping Thanks >-Original Message- >From: heyunlei >Sent: Thursday, April 26, 2018 2:07 PM >To: jaeg...@kernel.org; Yuchao (T); linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; heyunlei; Zhangdianfang (Euler) >Subject: [f2fs-dev][PATCH v3] f2fs: build free nid b

Re: [f2fs-dev] [PATCH] f2fs: allow ssa journal with nat bits enabled

2018-05-04 Thread heyunlei
Ping Thanks >-Original Message- >From: heyunlei >Sent: Wednesday, April 25, 2018 3:57 PM >To: jaeg...@kernel.org; Yuchao (T); linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; heyunlei; Zhangdianfang (Euler) >Subject: [f2fs-dev][PATCH] f2fs: allow ssa journal wit

Re: [f2fs-dev] [PATCH v2] f2fs: build free nid bitmap during flush nat entries

2018-04-25 Thread heyunlei
>-Original Message- >From: heyunlei >Sent: Wednesday, April 25, 2018 3:44 PM >To: jaeg...@kernel.org; Yuchao (T); linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; heyunlei; Zhangdianfang (Euler) >Subject: [f2fs-dev][PATCH v2] f2fs: build free nid bitmap during f

Re: [f2fs-dev] [PATCH] f2fs: move mnt_want_write_file after range check

2018-04-23 Thread heyunlei
>-Original Message- >From: heyunlei >Sent: Monday, April 23, 2018 10:37 AM >To: jaeg...@kernel.org; Yuchao (T); linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; heyunlei; Zhangdianfang (Euler) >Subject: [f2fs-dev][PATCH] f2fs: move mnt_want_write_file after r

Re: [f2fs-dev] [PATCH v2] f2fs: use cur_map instead of ckpt_map

2018-04-19 Thread heyunlei
>-Original Message- >From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >Sent: Friday, April 20, 2018 11:41 AM >To: Yuchao (T) >Cc: heyunlei; linux-f2fs-devel@lists.sourceforge.net; Wangbintian; >Zhangdianfang (Euler) >Subject: Re: [f2fs-dev][PATCH v2] f2fs: use cur_ma

Re: [f2fs-dev] [PATCH] f2fs: sepearte hot/cold in free nid

2018-04-19 Thread heyunlei
>-Original Message- >From: Chao Yu [mailto:yuch...@huawei.com] >Sent: Friday, April 20, 2018 9:53 AM >To: jaeg...@kernel.org >Cc: linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net >Subject: [f2fs-dev] [PATCH] f2fs: sepearte hot/cold in free nid > >As most indirect node,

Re: [f2fs-dev] [PATCH v5] f2fs: stop issue discard if something wrong with f2fs

2018-04-19 Thread heyunlei
>-Original Message- >From: heyunlei >Sent: Friday, April 13, 2018 11:08 AM >To: jaeg...@kernel.org; Yuchao (T); linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; heyunlei; Zhangdianfang (Euler) >Subject: [f2fs-dev][PATCH v5] f2fs: stop issue discard if something

Re: [f2fs-dev] [PATCH v2] f2fs: use cur_map instead of ckpt_map

2018-04-19 Thread heyunlei
>-Original Message- >From: Yuchao (T) >Sent: Friday, April 13, 2018 9:12 AM >To: Jaegeuk Kim; heyunlei >Cc: linux-f2fs-devel@lists.sourceforge.net; Wangbintian; Zhangdianfang (Euler) >Subject: Re: [f2fs-dev][PATCH v2] f2fs: use cur_map instead of ckpt_map > >On

Re: [f2fs-dev] [PATCH] f2fs: allocate hot_data for atomic write more strictly

2018-04-17 Thread heyunlei
>-Original Message- >From: Yuchao (T) >Sent: Tuesday, April 17, 2018 4:31 PM >To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; Zhangdianfang (Euler) >Subject: Re: [f2fs-dev][PATCH] f2fs: allocate hot_data for atomic write mor

Re: [f2fs-dev] [PATCH] fsck.f2fs: recover nat bits feature default by fsck

2018-04-10 Thread heyunlei
>-Original Message- >From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >Sent: Tuesday, April 10, 2018 12:01 PM >To: heyunlei >Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian; >Zhangdianfang (Euler) >Subject: Re: [f2fs-dev][PATCH] fsck.f2fs: rec

Re: [f2fs-dev] [PATCH v4] f2fs: introduce a method to make nat journal more fresh

2018-04-09 Thread heyunlei
>-Original Message- >From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >Sent: Tuesday, April 10, 2018 12:14 PM >To: heyunlei >Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian >Subject: Re: [f2fs-dev][PATCH v4] f2fs: introduce a method to make nat jo

Re: [f2fs-dev] [PATCH] fsck.f2fs: recover nat bits feature default by fsck

2018-04-09 Thread heyunlei
>-Original Message- >From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >Sent: Tuesday, April 10, 2018 12:01 PM >To: heyunlei >Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian; >Zhangdianfang (Euler) >Subject: Re: [f2fs-dev][PATCH] fsck.f2fs: rec

Re: [f2fs-dev] [PATCH] f2fs: use cur_map instead of ckpt_map

2018-04-09 Thread heyunlei
>-Original Message- >From: Yuchao (T) >Sent: Tuesday, April 10, 2018 10:45 AM >To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; Zhangdianfang (Euler) >Subject: Re: [f2fs-dev][PATCH] f2fs: use cur_map instead of ckpt_map &g

Re: [f2fs-dev] [PATCH v3] f2fs: stop issue discard if something wrong with f2fs

2018-04-09 Thread heyunlei
>-Original Message- >From: Yuchao (T) >Sent: Tuesday, April 10, 2018 10:36 AM >To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; Zhangdianfang (Euler) >Subject: Re: [f2fs-dev][PATCH v3] f2fs: stop issue discard if something wrong

Re: [f2fs-dev] [PATCH v2] f2fs: stop issue discard if something wrong with f2fs

2018-04-09 Thread heyunlei
>-Original Message- >From: Yuchao (T) >Sent: Monday, April 09, 2018 7:05 PM >To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; Zhangdianfang (Euler) >Subject: Re: [f2fs-dev][PATCH v2] f2fs: stop issue discard if something wrong

Re: [f2fs-dev] [PATCH v4] f2fs: introduce a method to make nat journal more fresh

2018-04-09 Thread heyunlei
>-Original Message- >From: Yuchao (T) >Sent: Wednesday, March 28, 2018 9:28 AM >To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian >Subject: Re: [f2fs-dev][PATCH v4] f2fs: introduce a method to make nat journal >more fresh

Re: [f2fs-dev] [PATCH 1/2] f2fs: stop issue discard if something wrong with f2fs

2018-04-08 Thread heyunlei
>-Original Message- >From: Yuchao (T) >Sent: Sunday, April 08, 2018 4:26 PM >To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian >Subject: Re: [f2fs-dev][PATCH 1/2] f2fs: stop issue discard if something wrong >with f2fs > &g

Re: [f2fs-dev] [PATCH v2] f2fs: rebuild get_node_path function

2018-03-27 Thread heyunlei
>-Original Message- >From: Yuchao (T) >Sent: Wednesday, March 28, 2018 9:41 AM >To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian >Subject: Re: [f2fs-dev][PATCH v2] f2fs: rebuild get_node_path function > >On 2018/3/2

Re: [f2fs-dev] [PATCH] f2fs: rebuild get_node_path function

2018-03-21 Thread heyunlei
>-Original Message- >From: heyunlei >Sent: Thursday, March 22, 2018 10:49 AM >To: jaeg...@kernel.org; Yuchao (T); linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; heyunlei >Subject: [f2fs-dev][PATCH] f2fs: rebuild get_node_path function > >This pat

Re: [f2fs-dev] [PATCH v3] f2fs: introduce a method to make nat journal more fresh

2018-03-19 Thread heyunlei
>-Original Message- >From: Yuchao (T) >Sent: Monday, March 19, 2018 10:10 AM >To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; Zhangdianfang (Euler) >Subject: Re: [f2fs-dev][PATCH v3] f2fs: introduce a method to make nat jo

Re: [f2fs-dev] [PATCH v3] f2fs: check blkaddr more accuratly before issue a bio

2018-03-18 Thread heyunlei
ping >-Original Message- >From: Yuchao (T) >Sent: Thursday, March 08, 2018 5:12 PM >To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian >Subject: Re: [f2fs-dev][PATCH v3] f2fs: check blkaddr more accuratly before >issue a bio

Re: [f2fs-dev] [PATCH v3] f2fs: introduce a method to make nat journal more fresh

2018-03-16 Thread heyunlei
>-Original Message- >From: Yuchao (T) >Sent: Friday, March 16, 2018 5:47 PM >To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; Zhangdianfang (Euler) >Subject: Re: [f2fs-dev][PATCH v3] f2fs: introduce a method to make nat journal

Re: [f2fs-dev] [PATCH v3] f2fs: introduce a method to make nat journal more fresh

2018-03-16 Thread heyunlei
>-Original Message- >From: Yuchao (T) >Sent: Friday, March 16, 2018 4:49 PM >To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; Zhangdianfang (Euler) >Subject: Re: [f2fs-dev][PATCH v3] f2fs: introduce a method to make nat jo

Re: [f2fs-dev] [PATCH v3] f2fs: check blkaddr more accuratly before issue a bio

2018-03-09 Thread heyunlei
>-Original Message- >From: heyunlei >Sent: Friday, March 09, 2018 5:52 PM >To: jaeg...@kernel.org; Yuchao (T); linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; Zhangdianfang (Euler); heyunlei >Subject: [f2fs-dev][PATCH v3] f2fs: check blkaddr more accuratly be

Re: [f2fs-dev] [PATCH] dump.f2fs: fix a wrong report for dump an {d, id, did}node

2018-03-06 Thread heyunlei
>-Original Message- >From: shengyong (A) >Sent: Wednesday, March 07, 2018 11:21 AM >To: heyunlei; jaeg...@kernel.org; Yuchao (T); >linux-f2fs-devel@lists.sourceforge.net >Subject: Re: [f2fs-dev] [PATCH] dump.f2fs: fix a wrong report for dump an {d, >id, did}node

Re: [f2fs-dev] [PATCH v2] f2fs: check blkaddr more accuratly before issue a bio

2018-03-05 Thread heyunlei
>-Original Message- >From: Sahitya Tummala [mailto:stumm...@codeaurora.org] >Sent: Monday, March 05, 2018 6:24 PM >To: heyunlei >Cc: jaeg...@kernel.org; Yuchao (T); linux-f2fs-devel@lists.sourceforge.net >Subject: Re: [f2fs-dev] [PATCH v2] f2fs: check blkaddr mor

Re: [f2fs-dev] [PATCH] f2fs: set_code_data in move_data_block

2018-02-10 Thread heyunlei
>-Original Message- >From: Songyunlong (Euler) >Sent: Sunday, February 11, 2018 11:35 AM >To: jaeg...@kernel.org; c...@kernel.org; Yuchao (T); yunlong.s...@icloud.com >Cc: miaoxie (A); Wangbintian; shengyong (A); heyunlei; >linux-f2fs-devel@lists.sourcefo

Re: [f2fs-dev] [PATCH] f2fs: remove unneed reada during build free nids

2018-02-10 Thread heyunlei
>-Original Message- >From: Chao Yu [mailto:c...@kernel.org] >Sent: Friday, February 09, 2018 9:37 PM >To: heyunlei; jaeg...@kernel.org; Yuchao (T); >linux-f2fs-devel@lists.sourceforge.net >Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unneed reada during build free &g

Re: [f2fs-dev] [PATCH] fsck: fix missing endian conversion

2018-01-26 Thread heyunlei
>-Original Message- >From: Yuchao (T) >Sent: Saturday, January 27, 2018 11:30 AM >To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; Jianing (Euler) >Subject: Re: [f2fs-dev][PATCH] fsck: fix missing endian conversion > >On

Re: [f2fs-dev] [PATCH] f2fs: rebuild sit page from sit info in mem

2018-01-23 Thread heyunlei
>-Original Message- >From: heyunlei >Sent: Wednesday, January 24, 2018 10:39 AM >To: jaeg...@kernel.org; Yuchao (T); linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; Jianing (Euler); heyunlei >Subject: [f2fs-dev][PATCH] f2fs: rebuild sit page from sit info in

Re: [f2fs-dev] [PATCH v6] f2fs: avoid dead loop in function find_fsync_dnodes

2018-01-04 Thread heyunlei
>-Original Message- >From: Yuchao (T) >Sent: Friday, January 05, 2018 11:19 AM >To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; Jianing (Euler) >Subject: Re: [f2fs-dev][PATCH v6] f2fs: avoid dead loop in function >find_fsyn

Re: [f2fs-dev] [PATCH v6] f2fs: avoid dead loop in function find_fsync_dnodes

2018-01-04 Thread heyunlei
>-Original Message- >From: Yuchao (T) >Sent: Friday, January 05, 2018 9:17 AM >To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; Jianing (Euler) >Subject: Re: [f2fs-dev][PATCH v6] f2fs: avoid dead loop in function >find_fsyn

Re: [f2fs-dev] [PATCH] f2fs: update inode info to inode page for new file

2018-01-03 Thread heyunlei
>-Original Message- >From: Yuchao (T) >Sent: Thursday, January 04, 2018 11:02 AM >To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian; Jianing (Euler) >Subject: Re: [f2fs-dev][PATCH] f2fs: update inode info to inode page for new &g

Re: [f2fs-dev] [PATCH] f2fs: update inode info to inode page for new file

2018-01-03 Thread heyunlei
>-Original Message- >From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >Sent: Thursday, January 04, 2018 5:44 AM >To: heyunlei >Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian; Jianing >(Euler) >Subject: Re: [f2fs-dev][PATCH] f2fs: update inode info

Re: [f2fs-dev] [PATCH v5] f2fs: avoid dead loop in function find_fsync_dnodes

2017-12-20 Thread heyunlei
>-Original Message- >From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >Sent: Thursday, December 21, 2017 5:01 AM >To: heyunlei >Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian; Jianing >(Euler) >Subject: Re: [f2fs-dev][PATCH v5] f2fs: avoid

Re: [f2fs-dev] [PATCH RFC] f2fs: fix an error case of missing update inode page

2017-12-14 Thread heyunlei
>-Original Message- >From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >Sent: Friday, December 15, 2017 12:21 PM >To: heyunlei >Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian; Jianing >(Euler) >Subject: Re: [f2fs-dev][PATCH RFC] f2fs: fix an error c

Re: [f2fs-dev] [PATCH RFC] f2fs: fix an error case of missing update inode page

2017-12-14 Thread heyunlei
>-Original Message- >From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >Sent: Friday, December 15, 2017 3:46 AM >To: heyunlei >Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian; Jianing >(Euler) >Subject: Re: [f2fs-dev][PATCH RFC] f2fs: fix an error c

Re: [f2fs-dev] [PATCH RFC] f2fs: fix an error case of missing update inode page

2017-12-07 Thread heyunlei
>-Original Message- >From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >Sent: Friday, December 08, 2017 1:27 PM >To: heyunlei >Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian; Jianing >(Euler) >Subject: Re: [f2fs-dev][PATCH RFC] f2fs: fix an error c

Re: [f2fs-dev] [PATCH v5] f2fs: Separate nat entry mem alloc from nat_tree_locks

2017-11-09 Thread heyunlei
>-Original Message- >From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >Sent: Friday, November 10, 2017 2:05 AM >To: heyunlei >Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian; Jianing >(Euler) >Subject: Re: [f2fs-dev][PATCH v5] f2fs: Separate nat

Re: [f2fs-dev] [PATCH] f2fs: check block reserve strictly a little bit

2017-11-09 Thread heyunlei
>-Original Message- >From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >Sent: Friday, November 10, 2017 1:55 AM >To: heyunlei >Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian; Jianing >(Euler) >Subject: Re: [f2fs-dev][PATCH] f2fs: check block rese

[f2fs-dev] 答复: [PATCH v3] f2fs: Separate nat entry mem alloc from nat_tree_locks

2017-11-06 Thread heyunlei
>-Original Message- >From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >Sent: Tuesday, November 07, 2017 10:16 AM >To: heyunlei >Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian; Wangkai >(Morgan) >Subject: Re: [f2fs-dev][PATCH v3] f2fs: Separate nat

[f2fs-dev] 答复: [PATCH] f2fs: no need to scan nat bitmap if it's not enable

2017-09-06 Thread heyunlei
Hi Chao, On 2017/9/7 10:55, Yunlei He wrote: > Now, nat bitmap will get lost after sudden power off, when we build > free nids, it's better to judge nat bitmap enable or not before scan > nat bitmap. We will load uptodate nit_bits map in last valid checkpoint after SPOR, is there any problem he

[f2fs-dev] 答复: [PATCH] f2fs: fix a infinite loop in writting checkpoint

2017-08-31 Thread heyunlei
Hi Yunlei, On 2017/8/26 12:15, Yunlei He wrote: > The loop reason is DIRTY IMETA always equal to 1: > > Thread A: > -write_checkpoint >-block_operations >-f2fs_sync_inode_meta >-igrab <--- here igrab return NULL > > Thread B: > -f2fs_evict_inode >-remove_inode_

Re: [f2fs-dev] [PATCH 2/3] f2fs: lookup extent cache first under IPU scenario

2017-04-24 Thread heyunlei
Hi all, Could we move IPU judgement outside cp_rwsem lock like below: if (set ipu policy) if (ipu success) return lock_op opu unlock_op And at same time when we write new checkpoint, we set ipu policy during whole cp, the process is like this: |OPU|IP

Re: [f2fs-dev] [PATCH] f2fs: fix a infinite loop in gc_node_segment

2017-04-05 Thread heyunlei
Hi Jaegeuk, On 2017/4/6 2:22, Jaegeuk Kim wrote: > On 04/05, heyunlei wrote: >> Hi Jaegeuk, >> >> On 2017/4/4 1:39, Jaegeuk Kim wrote: >>> Hi Yunlei, >>> >>> On 03/31, Yunlei He wrote: >>>> Similar as this problem: >>>>

Re: [f2fs-dev] [PATCH] f2fs: fix a infinite loop in gc_node_segment

2017-04-04 Thread heyunlei
Hi Jaegeuk, On 2017/4/4 1:39, Jaegeuk Kim wrote: > Hi Yunlei, > > On 03/31, Yunlei He wrote: >> Similar as this problem: >> f2fs: relax node version check for victim data in gc >> >> But this patch fix wrong SSA nid. > > What was the problem and how does this fix it? - has_not_enough_free_se

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid IO split due to mixed WB_SYNC_ALL and WB_SYNC_NONE

2017-03-30 Thread heyunlei
Hi Jaegeuk, Can we split in place update bios into single sbi->f2fs_bio_info for more page merged in out place update? This case can be show as below: in place update submit a bio with one page out place update submit a bio with one page in place update submit a bio with one page

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid IO split due to mixed WB_SYNC_ALL and WB_SYNC_NONE

2017-03-30 Thread heyunlei
Hi Jaegeuk, I try this patch and find it can fix below case: kworker/u16:3-423 [002] 183.812347: submit_bio: kworker/u16:3(423): WRITE block 104749352 on mmcblk0p50 (8 sectors) fio-2122 [003] 183.812380: submit_bio: fio(2122): WRITE block 104749360 on mmcblk0p

Re: [f2fs-dev] [PATCH 1/2] f2fs: write small sized IO to hot log

2017-03-30 Thread heyunlei
Hi Jaegeuk, On 2017/3/30 4:48, Jaegeuk Kim wrote: > It would better split small and large IOs separately in order to get more > consecutive big writes. > > The default threshold is set to 64KB, but configurable by > sysfs/min_hot_blocks. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/data.c

Re: [f2fs-dev] [PATCH 1/5] f2fs: relax node version check for victim data in gc

2017-03-29 Thread heyunlei
Hi all, On 2017/3/26 5:27, Jaegeuk Kim wrote: > On 03/25, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2017/3/25 15:59, Jaegeuk Kim wrote: >>> - has_not_enough_free_secs >>> node_secs: 0 dent_secs: 0 freed:0 free_segments:103 reserved:104 >>> >>> - f2fs_gc >>> - get_victim_by_

Re: [f2fs-dev] [PATCH] f2fs: fix a problem of a truncated inmem page

2017-03-16 Thread heyunlei
Hi Jaegeuk, On 2017/3/17 10:11, Jaegeuk Kim wrote: > Hi Yunlei, > > I could reproduce this. Could you check the patches that I sent just ago? I have test it with my test case, it's OK. Thanks, > > Thanks, > > On 03/16, Jaegeuk Kim wrote: >> On 03/15, Yunlei He wrote: >>> -start atomic write >>>

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid move encrypted block in BG_GC if it has been in memory

2017-03-13 Thread heyunlei
Hi Jaegeuk, On 2017/3/14 2:30, Jaegeuk Kim wrote: > On 03/10, Yunlei He wrote: >> If an encrypted block has been read to memory, we just dirty it >> and return directly. >> >> Signed-off-by: Yunlei He >> --- >> fs/f2fs/gc.c | 11 +-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >>

Re: [f2fs-dev] [PATCH] f2fs: allow write page cache when writting cp

2017-03-10 Thread heyunlei
Hi, Jaegeuk On 2017/3/10 5:28, Jaegeuk Kim wrote: > Hi Yunlei, > > On 03/07, Yunlei He wrote: >> This patch allow write data to normal file when writting >> new checkpoint. >> >> Signed-off-by: Yunlei He >> --- >> fs/f2fs/checkpoint.c | 4 +++- >> fs/f2fs/data.c | 23 -

Re: [f2fs-dev] [PATCH v2] f2fs: add a punch discard command function

2017-03-07 Thread heyunlei
Hi Jaegeuk, On 2017/3/8 10:49, Jaegeuk Kim wrote: > On 03/07, Jaegeuk Kim wrote: >> Hi Yunlei, >> >> On 03/02, Yunlei He wrote: >>> This patch add a function to punch discard command if one segment >>> reuse before discard. Split this segment from multi-segments discard >>> range, and discard the

Re: [f2fs-dev] [PATCH] f2fs: add a modify discard command function

2017-03-01 Thread heyunlei
Hi Jaegeuk, On 2017/3/2 3:48, Jaegeuk Kim wrote: > On 02/28, heyunlei wrote: >> Hi Jaegeuk, >> >> On 2017/2/28 7:08, Jaegeuk Kim wrote: >>> On 02/27, Yunlei He wrote: >>>> This patch add a function to modify discard command if one segment >>>&g

Re: [f2fs-dev] [PATCH] f2fs: fix an error return value in truncate_partial_data_page

2017-03-01 Thread heyunlei
Hi Jaegeuk, On 2017/3/2 3:32, Jaegeuk Kim wrote: > On 03/01, Chao Yu wrote: >> On 2017/2/28 20:32, Yunlei He wrote: >>> This patch fix a error return value in truncate_partial_data_page >>> >>> Signed-off-by: Yunlei He >>> --- >>> fs/f2fs/file.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 dele

Re: [f2fs-dev] [PATCH] f2fs: skip writeback meta pages if cp_mutex acquire failed

2017-03-01 Thread heyunlei
Hi Chao, On 2017/3/1 17:32, Chao Yu wrote: > On 2017/3/1 17:21, Yunlei He wrote: >> Skip writeback meta pages if cp_mutex lock acquire failed, cp will >> flush dirty pages instead. > > Make sense to me. :) > >> >> Signed-off-by: Yunlei He >> --- >> fs/f2fs/checkpoint.c | 12 +++- >> 1 fi

Re: [f2fs-dev] [PATCH] f2fs: avoid unnecessary fg_gc

2017-02-27 Thread heyunlei
On 2017/2/28 7:40, Jaegeuk Kim wrote: > On 02/27, heyunlei wrote: >> Hi Jaegeuk, >> >> On 2017/2/27 9:59, Hou Pengyang wrote: >>> We use has_not_enough_free_secs to check if there are enough free segments, >>> >>> (free_sections

Re: [f2fs-dev] [PATCH] f2fs: add a modify discard command function

2017-02-27 Thread heyunlei
Hi Jaegeuk, On 2017/2/28 7:08, Jaegeuk Kim wrote: > On 02/27, Yunlei He wrote: >> This patch add a function to modify discard command if one segment >> reuse before discard. Split this segment from multi-segments discard >> range, and discard the left bigger range. > > Now MAX_DISCARD_BLOCKS() is

Re: [f2fs-dev] [PATCH] f2fs: avoid unnecessary fg_gc

2017-02-26 Thread heyunlei
Hi Jaegeuk, On 2017/2/27 9:59, Hou Pengyang wrote: > We use has_not_enough_free_secs to check if there are enough free segments, > > (free_sections(sbi) + freed) <= > (node_secs + 2 * dent_secs + imeta_secs + > reserved_sections(sbi) + needed); Now node S

Re: [f2fs-dev] [PATCH] f2fs: avoid unnecessary fg_gc

2017-02-24 Thread heyunlei
Hi all, I am really confused by the condition below use sec_freed, is it always equal to zero? Or, gc more process will recheck this condition? if (gc_type == BG_GC && has_not_enough_free_secs(sbi, sec_freed, 0)) On 2017/2/25 10:07, Jaegeuk Kim wrote: > On 02/25, Hou Pengyang wrote: >

Re: [f2fs-dev] [PATCH] f2fs: no need lock_op in f2fs_write_inline_data

2017-02-24 Thread heyunlei
Hi Chao, Can we add below to avoid this case? diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 80f9863..c4f3db0 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -1695,6 +1695,7 @@ static int prepare_write_begin(struct f2fs_sb_info *sbi, if (f2fs_has_inline_data(inode)) {

Re: [f2fs-dev] [PATCH] f2fs: no need lock_op in f2fs_write_inline_data

2017-02-23 Thread heyunlei
Hi Jaegeuk, Can you explain more about this? Besides, how about inplace update? On 2017/2/24 3:45, Jaegeuk Kim wrote: > In this case, however, I don't think we > can do like this. -- Check out the vibra

Re: [f2fs-dev] [PATCH 6/6] f2fs: show # of on-going flush and discard bios

2017-01-13 Thread heyunlei
Hi Jaegeuk, On 2017/1/13 6:44, Jaegeuk Kim wrote: > This patch adds stat information for flush and discard commands. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/debug.c | 7 +-- > fs/f2fs/f2fs.h| 3 ++- > fs/f2fs/segment.c | 4 > 3 files changed, 11 insertions(+), 3 deletions(-

Re: [f2fs-dev] [PATCH 6/6] f2fs: show # of on-going flush and discard bios

2017-01-13 Thread heyunlei
Hi Jaegeuk Kim, On 2017/1/13 6:44, Jaegeuk Kim wrote: > This patch adds stat information for flush and discard commands. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/debug.c | 7 +-- > fs/f2fs/f2fs.h| 3 ++- > fs/f2fs/segment.c | 4 > 3 files changed, 11 insertions(+), 3 deletio

Re: [f2fs-dev] [PATCH] f2fs: skip read if page has been uptodate

2016-12-27 Thread heyunlei
On 2016/12/27 20:04, Chao Yu wrote: > On 2016/12/27 12:05, Yunlei He wrote: >> This patch add a judgement before read, if the page has been >> uptodate, move the block directly. >> >> Signed-off-by: Yunlei He >> --- >> fs/f2fs/gc.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git

Re: [f2fs-dev] [PATCH v3] f2fs: fix a missing discard prefree segments

2016-12-21 Thread heyunlei
Hi Jaegeuk, On 2016/12/22 2:04, Jaegeuk Kim wrote: > On 12/21, Yunlei He wrote: >> If userspace issue a fstrim with a range not involve prefree segments, >> it will reuse these segments without discard. This patch fix it. >> >> Signed-off-by: Yunlei He >> --- >> fs/f2fs/segment.c | 9 +++-- >

Re: [f2fs-dev] [PATCH 1/2 v2] f2fs: fix a missing discard prefree segments

2016-12-21 Thread heyunlei
Hi Chao, On 2016/12/21 11:55, Chao Yu wrote: > On 2016/12/21 11:35, heyunlei wrote: >> Hi Chao, >> >> On 2016/12/21 10:27, Chao Yu wrote: >>> On 2016/12/21 10:02, Chao Yu wrote: >>>> Hi Jaegeuk, Yunlei, >>>> >>>> On 2016/12/20 11:1

Re: [f2fs-dev] [PATCH 1/2 v2] f2fs: fix a missing discard prefree segments

2016-12-20 Thread heyunlei
Hi Chao, On 2016/12/21 10:27, Chao Yu wrote: > On 2016/12/21 10:02, Chao Yu wrote: >> Hi Jaegeuk, Yunlei, >> >> On 2016/12/20 11:11, Yunlei He wrote: >>> If userspace issue a fstrim with a range not involve prefree segments, >>> it will reuse these segments without discard. This patch fix it. >> >

Re: [f2fs-dev] [PATCH] f2fs: fix to account total free nid correctly

2016-11-17 Thread heyunlei
On 2016/11/15 4:45, Jaegeuk Kim wrote: > On Mon, Nov 14, 2016 at 07:24:56PM +0800, Chao Yu wrote: >> Thread A Thread BThread C >> - f2fs_create >> - f2fs_new_inode >> - f2fs_lock_op >>- alloc_nid >> alloc last nid >> - f2fs_unlock_op >>

Re: [f2fs-dev] [PATCH 4/7] resize.f2fs: get latest free segments

2016-11-02 Thread heyunlei
Hi, Kim On 2016/11/3 13:28, Jaegeuk Kim wrote: > The # of free segments can be changed by defragmentation. > > Signed-off-by: Jaegeuk Kim > --- > fsck/resize.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fsck/resize.c b/fsck/resize.c > index 5dc73a8..4813de7 100644 >

Re: [f2fs-dev] [PATCH] f2fs: return directly if block has been removed from the victim

2016-11-02 Thread heyunlei
On 2016/11/2 15:19, Chao Yu wrote: > On 2016/10/28 6:34, Jaegeuk Kim wrote: >> On Wed, Oct 26, 2016 at 10:14:04AM +0800, heyunlei wrote: >>> >>> >>> On 2016/10/26 9:09, Jaegeuk Kim wrote: >>> Hi Kim, >>>> Hi Yunlei, >>>> >

Re: [f2fs-dev] [PATCH] f2fs: return directly if block has been removed from the victim

2016-10-25 Thread heyunlei
On 2016/10/26 9:09, Jaegeuk Kim wrote: Hi Kim, > Hi Yunlei, > > On Mon, Oct 24, 2016 at 11:37:28AM +0800, Yunlei He wrote: >> If one block has been to written to a new place, just return >> in move data process. >> >> Signed-off-by: Yunlei He >> --- >> fs/f2fs/gc.c | 17 - >> 1

Re: [f2fs-dev] [PATCH] f2fs: continue to do fg_gc even if beyond max_victim_search

2016-09-22 Thread heyunlei
On 2016/9/22 18:55, Chao Yu wrote: > On 2016/9/22 11:48, Yunlei He wrote: >> For forground gc, if can't find a victim in one max_victim_search, >> try it again. >> >> Signed-off-by: Yunlei He >> --- >> fs/f2fs/gc.c | 23 --- >> 1 file changed, 12 insertions(+), 11 deletions(

Re: [f2fs-dev] [PATCH] f2fs: forbid to do fstrim if fs has some error

2016-09-08 Thread heyunlei
On 2016/9/9 0:02, Chao Yu wrote: > On 2016/9/8 8:02, Jaegeuk Kim wrote: >> On Wed, Sep 07, 2016 at 09:24:31PM +0800, Chao Yu wrote: >>> Hi Yunlei, Hi all, >>> >>> On 2016/9/1 10:14, Yunlei He wrote: This patch skip fstrim if sbi set SBI_NEED_FSCK flag Signed-off-by: Yunlei He

Re: [f2fs-dev] [PATCH] f2fs: walk around a panic caused by nrpages is not zero in clear_inode

2016-09-06 Thread heyunlei
Hi, kim On 2016/9/7 9:47, Jaegeuk Kim wrote: > On Tue, Sep 06, 2016 at 09:17:32AM +0800, Yunlei He wrote: >> I came across a panic twice: >> >> [] dump_backtrace+0x0/0x124 >> [] show_stack+0x14/0x1c >> [] dump_stack+0x20/0x28 >> [] panic+0x13c/0x258 >> [] clear_inode+0x8c/0xd4 >> [] f2fs_evict_ino

Re: [f2fs-dev] [PATCH] f2fs: fix to set superblock dirty correctly

2016-08-26 Thread heyunlei
Hi all, On 2016/8/27 9:01, Jaegeuk Kim wrote: > On Fri, Aug 26, 2016 at 10:20:18PM +0800, Chao Yu wrote: >> From: Chao Yu >> >> tests/generic/251 of fstest suit complains us with below message: >> >> [ cut here ] >> invalid opcode: [#1] PREEMPT SMP >> CPU: 2 PID: 7698