Re: [f2fs-dev] [PATCH v4 1/8] fs: move sgid strip operation from inode_init_owner into inode_sgid_strip

2022-04-20 Thread xuyang2018...@fujitsu.com
on 2022/4/21 5:52, Dave Chinner wrote: > On Wed, Apr 20, 2022 at 01:27:39AM +0000, xuyang2018...@fujitsu.com wrote: >> on 2022/4/19 22:05, Christian Brauner wrote: >>> On Tue, Apr 19, 2022 at 07:47:07PM +0800, Yang Xu wrote: >>>> This has no functional

Re: [f2fs-dev] [PATCH v4 5/8] f2fs: Remove useless NULL assign value for acl and default_acl

2022-04-19 Thread xuyang2018...@fujitsu.com
on 2022/4/19 22:02, Christian Brauner wrote: > On Tue, Apr 19, 2022 at 07:47:11PM +0800, Yang Xu wrote: >> Like other use ${fs}_init_acl and posix_acl_create filesystem, we don't >> need to assign NULL for acl and default_acl pointer because f2fs_acl_create >> will do this job. So remove it. >> >>

Re: [f2fs-dev] [PATCH v4 4/8] NFSv3: only do posix_acl_create under CONFIG_NFS_V3_ACL

2022-04-19 Thread xuyang2018...@fujitsu.com
on 2022/4/19 22:11, Trond Myklebust wrote: > On Tue, 2022-04-19 at 15:59 +0200, Christian Brauner wrote: >> On Tue, Apr 19, 2022 at 07:47:10PM +0800, Yang Xu wrote: >>> Since nfs3_proc_create/nfs3_proc_mkdir/nfs3_proc_mknod these rpc >>> ops are called >>> by nfs_create/nfs_mkdir/nfs_mkdir these in

Re: [f2fs-dev] [PATCH v4 1/8] fs: move sgid strip operation from inode_init_owner into inode_sgid_strip

2022-04-19 Thread xuyang2018...@fujitsu.com
on 2022/4/19 22:05, Christian Brauner wrote: > On Tue, Apr 19, 2022 at 07:47:07PM +0800, Yang Xu wrote: >> This has no functional change. Just create and export inode_sgid_strip api >> for >> the subsequent patch. This function is used to strip S_ISGID mode when init >> a new inode. >> >> Acked-by

Re: [f2fs-dev] [PATCH v4 7/8] fs: strip file's S_ISGID mode on vfs instead of on underlying filesystem

2022-04-19 Thread xuyang2018...@fujitsu.com
on 2022/4/19 22:09, Christian Brauner wrote: > On Tue, Apr 19, 2022 at 07:47:13PM +0800, Yang Xu wrote: >> Currently, vfs only passes mode argument to filesystem, then use >> inode_init_owner() >> to strip S_ISGID. Some filesystem(ie ext4/btrfs) will call inode_init_owner >> firstly, then posxi ac

Re: [f2fs-dev] [PATCH v4 6/8] ntfs3: Use the same order for acl pointer check in ntfs_init_acl

2022-04-19 Thread xuyang2018...@fujitsu.com
on 2022/4/19 22:03, Christian Brauner wrote: > On Tue, Apr 19, 2022 at 07:47:12PM +0800, Yang Xu wrote: >> Like ext4 and other use ${fs}_init_acl filesystem, they all used the >> following >> style >> >> error = posix_acl_create(dir,&inode->i_mode,&default_acl,&acl); >> if (error)

Re: [f2fs-dev] [PATCH v4 3/8] xfs: only call posix_acl_create under CONFIG_XFS_POSIX_ACL

2022-04-19 Thread xuyang2018...@fujitsu.com
on 2022/4/19 21:53, Christian Brauner wrote: > On Tue, Apr 19, 2022 at 07:47:09PM +0800, Yang Xu wrote: >> Since xfs_generic_create only calls xfs_set_acl when enable this kconfig, we >> don't need to call posix_acl_create for the !CONFIG_XFS_POSIX_ACL case. >> >> The previous patch has added missi