Re: [PATCH] f2fs: fix 32-bit linking

2019-06-28 Thread Christoph Hellwig
On Fri, Jun 28, 2019 at 12:39:52PM +0200, Arnd Bergmann wrote: > Not all architectures support get_user() with a 64-bit argument: Which architectures are still missing? I think we finally need to get everyone in line instead of repeatedly working around the lack of minor arch support.

Re: [PATCH] f2fs: fix 32-bit linking

2019-06-28 Thread Arnd Bergmann
On Fri, Jun 28, 2019 at 2:44 PM Christoph Hellwig wrote: > > On Fri, Jun 28, 2019 at 12:39:52PM +0200, Arnd Bergmann wrote: > > Not all architectures support get_user() with a 64-bit argument: > > Which architectures are still missing? I think we finally need to > get everyone in line instead of

Re: [PATCH] f2fs: fix 32-bit linking

2019-06-28 Thread Christoph Hellwig
On Fri, Jun 28, 2019 at 03:09:47PM +0200, Arnd Bergmann wrote: > I came across this on arm-nommu (which disables > CONFIG_CPU_SPECTRE) during randconfig testing. > > I don't see an easy way to add this in there, short of rewriting the > whole __get_user_err() function. Any suggestions? Can't we j

Re: [PATCH] f2fs: fix 32-bit linking

2019-06-28 Thread Arnd Bergmann
On Fri, Jun 28, 2019 at 3:17 PM Christoph Hellwig wrote: > > On Fri, Jun 28, 2019 at 03:09:47PM +0200, Arnd Bergmann wrote: > > I came across this on arm-nommu (which disables > > CONFIG_CPU_SPECTRE) during randconfig testing. > > > > I don't see an easy way to add this in there, short of rewritin

Re: [PATCH] f2fs: fix 32-bit linking

2019-06-28 Thread Jaegeuk Kim
Hi Arnd, If you don't mind, can I integrate this into the original patch in the queue? Thanks, On 06/28, Arnd Bergmann wrote: > Not all architectures support get_user() with a 64-bit argument: > > ERROR: "__get_user_bad" [fs/f2fs/f2fs.ko] undefined! > > Use copy_from_user() here, this will alw

Re: [PATCH] f2fs: fix 32-bit linking

2019-06-28 Thread Russell King - ARM Linux admin
On Fri, Jun 28, 2019 at 04:46:14PM +0200, Arnd Bergmann wrote: > On Fri, Jun 28, 2019 at 3:17 PM Christoph Hellwig wrote: > > > > On Fri, Jun 28, 2019 at 03:09:47PM +0200, Arnd Bergmann wrote: > > > I came across this on arm-nommu (which disables > > > CONFIG_CPU_SPECTRE) during randconfig testing

Re: [PATCH] f2fs: fix 32-bit linking

2019-06-28 Thread Randy Dunlap
On 6/28/19 5:44 AM, Christoph Hellwig wrote: > On Fri, Jun 28, 2019 at 12:39:52PM +0200, Arnd Bergmann wrote: >> Not all architectures support get_user() with a 64-bit argument: > > Which architectures are still missing? I think we finally need to > get everyone in line instead of repeatedly work

Re: [PATCH] f2fs: fix 32-bit linking

2019-07-01 Thread Arnd Bergmann
On Fri, Jun 28, 2019 at 7:58 PM Russell King - ARM Linux admin wrote: > > On Fri, Jun 28, 2019 at 04:46:14PM +0200, Arnd Bergmann wrote: > > On Fri, Jun 28, 2019 at 3:17 PM Christoph Hellwig > > wrote: > > > > > > On Fri, Jun 28, 2019 at 03:09:47PM +0200, Arnd Bergmann wrote: > > > > I came acro

[f2fs-dev] [PATCH] f2fs: fix 32-bit linking

2019-06-28 Thread Arnd Bergmann
Not all architectures support get_user() with a 64-bit argument: ERROR: "__get_user_bad" [fs/f2fs/f2fs.ko] undefined! Use copy_from_user() here, this will always work. Fixes: d2ae7494d043 ("f2fs: ioctl for removing a range from F2FS") Signed-off-by: Arnd Bergmann --- fs/f2fs/file.c | 3 ++- 1

Re: [f2fs-dev] [PATCH] f2fs: fix 32-bit linking

2019-07-01 Thread Arnd Bergmann
On Fri, Jun 28, 2019 at 5:59 PM Jaegeuk Kim wrote: > > Hi Arnd, > > If you don't mind, can I integrate this into the original patch in the queue? Yes, I think that would be good anyway, it may take a little longer to fix all the architectures. Arnd _