Re: [f2fs-dev] [PATCH] f2fs: do checkpoint in kill_sb

2018-07-12 Thread Chao Yu
On 2018/7/12 15:34, Jaegeuk Kim wrote: > On 07/10, Chao Yu wrote: >> On 2018/7/10 4:36, Jaegeuk Kim wrote: >>> On 07/09, Chao Yu wrote: On 2018/7/7 9:20, Jaegeuk Kim wrote: > When unmounting f2fs in force mode, we can get it stuck by io_schedule() force mode means force shutdown?

Re: [f2fs-dev] [PATCH] f2fs: do checkpoint in kill_sb

2018-07-12 Thread Jaegeuk Kim
On 07/10, Chao Yu wrote: > On 2018/7/10 4:36, Jaegeuk Kim wrote: > > On 07/09, Chao Yu wrote: > >> On 2018/7/7 9:20, Jaegeuk Kim wrote: > >>> When unmounting f2fs in force mode, we can get it stuck by io_schedule() > >> > >> force mode means force shutdown? > > > > Yes. > > > >> > >>> by some pen

Re: [f2fs-dev] [PATCH] f2fs: do checkpoint in kill_sb

2018-07-09 Thread Chao Yu
On 2018/7/10 4:36, Jaegeuk Kim wrote: > On 07/09, Chao Yu wrote: >> On 2018/7/7 9:20, Jaegeuk Kim wrote: >>> When unmounting f2fs in force mode, we can get it stuck by io_schedule() >> >> force mode means force shutdown? > > Yes. > >> >>> by some pending IOs in meta_inode. >>> >>> io_schedule+0xd

Re: [f2fs-dev] [PATCH] f2fs: do checkpoint in kill_sb

2018-07-09 Thread Jaegeuk Kim
On 07/09, Chao Yu wrote: > On 2018/7/7 9:20, Jaegeuk Kim wrote: > > When unmounting f2fs in force mode, we can get it stuck by io_schedule() > > force mode means force shutdown? Yes. > > > by some pending IOs in meta_inode. > > > > io_schedule+0xd/0x30 > > wait_on_page_bit_common+0xc6/0x130 >

Re: [f2fs-dev] [PATCH] f2fs: do checkpoint in kill_sb

2018-07-09 Thread Chao Yu
On 2018/7/7 9:20, Jaegeuk Kim wrote: > When unmounting f2fs in force mode, we can get it stuck by io_schedule() force mode means force shutdown? > by some pending IOs in meta_inode. > > io_schedule+0xd/0x30 > wait_on_page_bit_common+0xc6/0x130 Looks like a deadlock here? Does this mean we forge

[f2fs-dev] [PATCH] f2fs: do checkpoint in kill_sb

2018-07-06 Thread Jaegeuk Kim
When unmounting f2fs in force mode, we can get it stuck by io_schedule() by some pending IOs in meta_inode. io_schedule+0xd/0x30 wait_on_page_bit_common+0xc6/0x130 __filemap_fdatawait_range+0xbd/0x100 filemap_fdatawait_keep_errors+0x15/0x40 sync_inodes_sb+0x1cf/0x240 sync_filesystem+0x52/0x90 gene