Re: [f2fs-dev] [PATCH] f2fs: fix 32-bit build

2016-11-23 Thread Jaegeuk Kim
On Wed, Nov 23, 2016 at 10:05:41PM +0100, Arnd Bergmann wrote: > On Wednesday, November 23, 2016 10:42:26 AM CET Jaegeuk Kim wrote: > > > > Unfortunately, the sector number is usually a 64-bit number, and > > we guarantee that bdev_zone_size() returns a power-of-two number. > > The sentence no lo

Re: [f2fs-dev] [PATCH] f2fs: fix 32-bit build

2016-11-23 Thread Arnd Bergmann
On Wednesday, November 23, 2016 10:42:26 AM CET Jaegeuk Kim wrote: > > Unfortunately, the sector number is usually a 64-bit number, and > we guarantee that bdev_zone_size() returns a power-of-two number. The sentence no longer makes sense. Maybe Fortunately, bdev_zone_size() is guaranteed to ret

Re: [f2fs-dev] [PATCH] f2fs: fix 32-bit build

2016-11-23 Thread Jaegeuk Kim
Hi Arnd, As Damien mentioned, is this fine to go, if you don't mind? I've confirmed that sd_zbc.c allows a power-of-two number only. Thanks, >From b709ff532daedc42526a46cb26860127f4959e01 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Tue, 22 Nov 2016 15:20:16 +0100 Subject: [PATCH] f2fs: f

Re: [f2fs-dev] [PATCH] f2fs: fix 32-bit build

2016-11-22 Thread Damien Le Moal
Arnd, > Unfortunately, the sector number is usually a 64-bit number, and > we probably can't guarantee that bdev_zone_size() returns a > power-of-two number, so we actually have to do the expensive 64-bit > operation to get the remainder. No, the zone size is guaranteed to be a power of 2. See s

[f2fs-dev] [PATCH] f2fs: fix 32-bit build

2016-11-22 Thread Arnd Bergmann
The addition of multiple-device support broke CONFIG_BLK_DEV_ZONED on 32-bit machines because of a 64-bit division: fs/f2fs/f2fs.o: In function `__issue_discard_async': extent_cache.c:(.text.__issue_discard_async+0xd4): undefined reference to `__aeabi_uldivmod' Unfortunately, the sector number i