Re: [f2fs-dev] [PATCH] f2fs: fix potential .flags overflow on 32bit architecture

2020-03-22 Thread Chao Yu
On 2020/3/22 23:30, Ondřej Jirman wrote: > On Sun, Mar 22, 2020 at 09:18:56PM +0800, Chao Yu wrote: >> Hi, >> >> On 2020-3-22 20:14, Ondřej Jirman wrote: >>> Hello, >>> >>> On Sun, Mar 22, 2020 at 06:13:27PM +0800, Chao Yu wrote: From: Chao Yu f2fs_inode_info.flags is unsigned long

Re: [f2fs-dev] [PATCH] f2fs: fix potential .flags overflow on 32bit architecture

2020-03-22 Thread Ondřej Jirman
On Sun, Mar 22, 2020 at 09:18:56PM +0800, Chao Yu wrote: > Hi, > > On 2020-3-22 20:14, Ondřej Jirman wrote: > > Hello, > > > > On Sun, Mar 22, 2020 at 06:13:27PM +0800, Chao Yu wrote: > > > From: Chao Yu > > > > > > f2fs_inode_info.flags is unsigned long variable, it has 32 bits > > > in 32bit

Re: [f2fs-dev] [PATCH] f2fs: fix potential .flags overflow on 32bit architecture

2020-03-22 Thread Chao Yu
Hi, On 2020-3-22 20:14, Ondřej Jirman wrote: Hello, On Sun, Mar 22, 2020 at 06:13:27PM +0800, Chao Yu wrote: From: Chao Yu f2fs_inode_info.flags is unsigned long variable, it has 32 bits in 32bit architecture, since we introduced FI_MMAP_FILE flag when we support data compression, we may acc

Re: [f2fs-dev] [PATCH] f2fs: fix potential .flags overflow on 32bit architecture

2020-03-22 Thread Ondřej Jirman
Hello, On Sun, Mar 22, 2020 at 06:13:27PM +0800, Chao Yu wrote: > From: Chao Yu > > f2fs_inode_info.flags is unsigned long variable, it has 32 bits > in 32bit architecture, since we introduced FI_MMAP_FILE flag > when we support data compression, we may access memory cross > the border of .flags

[f2fs-dev] [PATCH] f2fs: fix potential .flags overflow on 32bit architecture

2020-03-22 Thread Chao Yu
From: Chao Yu f2fs_inode_info.flags is unsigned long variable, it has 32 bits in 32bit architecture, since we introduced FI_MMAP_FILE flag when we support data compression, we may access memory cross the border of .flags field, corrupting .i_sem field, result in below deadlock. To fix this issue