Re: [f2fs-dev] [PATCH] f2fs: remove some dead code

2023-04-27 Thread Chao Yu
On 2023/4/28 0:28, Jaegeuk Kim wrote: On 04/18, Dan Carpenter wrote: On Mon, Apr 17, 2023 at 10:51:46PM +0200, Christophe JAILLET wrote: - ret2 = filemap_check_errors(NODE_MAPPING(sbi)); - if (!ret) - ret = ret2; + ret = filemap_check_errors(NODE_MAPPING(sbi));

Re: [f2fs-dev] [PATCH] f2fs: remove some dead code

2023-04-27 Thread Jaegeuk Kim
On 04/18, Dan Carpenter wrote: > On Mon, Apr 17, 2023 at 10:51:46PM +0200, Christophe JAILLET wrote: > > > > - ret2 = filemap_check_errors(NODE_MAPPING(sbi)); > > - if (!ret) > > - ret = ret2; > > + ret = filemap_check_errors(NODE_MAPPING(sbi)); > > > > return ret; > >

Re: [f2fs-dev] [PATCH] f2fs: remove some dead code

2023-04-17 Thread Dan Carpenter
On Mon, Apr 17, 2023 at 10:51:46PM +0200, Christophe JAILLET wrote: > > - ret2 = filemap_check_errors(NODE_MAPPING(sbi)); > - if (!ret) > - ret = ret2; > + ret = filemap_check_errors(NODE_MAPPING(sbi)); > > return ret; Let's get rid of "ret" as well:

[f2fs-dev] [PATCH] f2fs: remove some dead code

2023-04-17 Thread Christophe JAILLET
'ret' is known to be 0 at the point. So these lines of code should just be removed. Signed-off-by: Christophe JAILLET --- The dead code became after commit 8358014d6be8 ("f2fs: avoid to check PG_error flag") --- fs/f2fs/node.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-)