Re: [f2fs-dev] [PATCH] f2fs: use kmem_cache pool during xattr lookups

2019-07-30 Thread Jaegeuk Kim
On 07/29, Ju Hyung Park wrote: > Hi Chao and Jaegeuk, > > I have no idea how that patch got merged. > > We(me and Yaro) were supposed to work on doing some finishing touches > to the patch before sending it to upstream. > > I'll personally check with Yaro. > > Jaegeuk, please remove the patch.

Re: [f2fs-dev] [PATCH] f2fs: use kmem_cache pool during xattr lookups

2019-07-29 Thread Chao Yu
Hi Ju Hyung, On 2019/7/29 15:48, Ju Hyung Park wrote: > Hi Chao and Jaegeuk, > > I have no idea how that patch got merged. > > We(me and Yaro) were supposed to work on doing some finishing touches > to the patch before sending it to upstream. > > I'll personally check with Yaro. > > Jaegeuk, p

Re: [f2fs-dev] [PATCH] f2fs: use kmem_cache pool during xattr lookups

2019-07-29 Thread Ju Hyung Park
Hi Chao and Jaegeuk, I have no idea how that patch got merged. We(me and Yaro) were supposed to work on doing some finishing touches to the patch before sending it to upstream. I'll personally check with Yaro. Jaegeuk, please remove the patch. That patch has numerous issues, biggest one being h

Re: [f2fs-dev] [PATCH] f2fs: use kmem_cache pool during xattr lookups

2019-07-29 Thread Chao Yu
Hi Jaegeuk, Ju Hyung, Yaroslav, I can see "f2fs: xattr: reserve cache for xattr allocations" has been merged in dev-test branch, however, it doesn't exist in f2fs mailing list, so I can not comment on it Can anyone send it to the list? Thanks, ___

Re: [f2fs-dev] [PATCH] f2fs: use kmem_cache pool during xattr lookups

2019-07-12 Thread Chao Yu
On 2019/7/12 1:06, Jaegeuk Kim wrote: > On 07/12, Ju Hyung Park wrote: >> Hi everyone. >> >> This is a RFC patch. >> >> This patch introduces an even bigger problem, which is forcing all >> xattr lookup memory allocations to be made in 4076B, when in reality, >> 4076B allocations are only made duri

Re: [f2fs-dev] [PATCH] f2fs: use kmem_cache pool during xattr lookups

2019-07-11 Thread Jaegeuk Kim
On 07/12, Ju Hyung Park wrote: > Hi everyone. > > This is a RFC patch. > > This patch introduces an even bigger problem, which is forcing all > xattr lookup memory allocations to be made in 4076B, when in reality, > 4076B allocations are only made during initial mounts and the rests > are made in

Re: [f2fs-dev] [PATCH] f2fs: use kmem_cache pool during xattr lookups

2019-07-11 Thread Ju Hyung Park
Hi everyone. This is a RFC patch. This patch introduces an even bigger problem, which is forcing all xattr lookup memory allocations to be made in 4076B, when in reality, 4076B allocations are only made during initial mounts and the rests are made in 204B, unnecessarily wasting memory. In my tes

[f2fs-dev] [PATCH] f2fs: use kmem_cache pool during xattr lookups

2019-07-11 Thread Park Ju Hyung
It's been observed that kzalloc() on lookup_all_xattrs() are called millions of times on Android, quickly becoming the top abuser of slub memory allocator. Use a dedicated kmem cache pool for xattr lookups to mitigate this. Signed-off-by: Park Ju Hyung --- fs/f2fs/f2fs.h | 6 ++ fs/f2fs/s