Re: [f2fs-dev] [PATCH V2] f2fs: introduce free nid bitmap

2017-03-01 Thread Chao Yu
Hi Jaegeuk, On 2017/3/2 3:35, Jaegeuk Kim wrote: > Hi Chao, > > BTW, we need to add a shrinker for this as well, right? Hmm...do we really have to? As at most we will have 3900 NAT blocks, so a. free_nid_bitmap: 3900 * 57 = ~217 KB b. nat_block_bitmap:3900 / 8 = ~487 BYTE c. free_nid_co

Re: [f2fs-dev] [PATCH V2] f2fs: introduce free nid bitmap

2017-03-01 Thread Jaegeuk Kim
Hi Chao, BTW, we need to add a shrinker for this as well, right? Thanks, On 02/23, Chao Yu wrote: > In scenario of intensively node allocation, free nids will be ran out > soon, then it needs to stop to load free nids by traversing NAT blocks, > in worse case, if NAT blocks does not be cached in

Re: [f2fs-dev] [PATCH V2] f2fs: introduce free nid bitmap

2017-02-27 Thread Jaegeuk Kim
On 02/27, Chao Yu wrote: > On 2017/2/26 3:02, Jaegeuk Kim wrote: > > On 02/25, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> I added below diff code into this patch in order to fix incorrectly nid > >> status > >> updating to reduce large latency of generic/251 in fstest, could you help > >> to > >>

Re: [f2fs-dev] [PATCH V2] f2fs: introduce free nid bitmap

2017-02-26 Thread Chao Yu
On 2017/2/26 3:02, Jaegeuk Kim wrote: > On 02/25, Chao Yu wrote: >> Hi Jaegeuk, >> >> I added below diff code into this patch in order to fix incorrectly nid >> status >> updating to reduce large latency of generic/251 in fstest, could you help to >> review code below? > > Understand the problem,

Re: [f2fs-dev] [PATCH V2] f2fs: introduce free nid bitmap

2017-02-25 Thread Jaegeuk Kim
On 02/25, Chao Yu wrote: > Hi Jaegeuk, > > I added below diff code into this patch in order to fix incorrectly nid status > updating to reduce large latency of generic/251 in fstest, could you help to > review code below? Understand the problem, and how about this? diff --git a/fs/f2fs/node.c b/

Re: [f2fs-dev] [PATCH V2] f2fs: introduce free nid bitmap

2017-02-24 Thread Chao Yu
Hi Jaegeuk, I added below diff code into this patch in order to fix incorrectly nid status updating to reduce large latency of generic/251 in fstest, could you help to review code below? Latency:beforeafter generic/251 1483s ... 184s diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 52d

[f2fs-dev] [PATCH V2] f2fs: introduce free nid bitmap

2017-02-22 Thread Chao Yu
In scenario of intensively node allocation, free nids will be ran out soon, then it needs to stop to load free nids by traversing NAT blocks, in worse case, if NAT blocks does not be cached in memory, it generates IOs which slows down our foreground operations. In order to speed up node allocation