Re: [f2fs-dev] [PATCH V4] f2fs: Avoid double lock for cp_rwsem during checkpoint

2020-05-11 Thread Chao Yu
On 2020/5/12 11:24, Jaegeuk Kim wrote: > On 05/12, Chao Yu wrote: >> On 2020/5/12 6:11, Jaegeuk Kim wrote: >>> On 05/11, Chao Yu wrote: On 2020/5/10 3:03, Jaegeuk Kim wrote: > On 05/09, Chao Yu wrote: >> On 2020/5/9 0:10, Jaegeuk Kim wrote: >>> Hi Sayali, >>> >>> In order t

Re: [f2fs-dev] [PATCH V4] f2fs: Avoid double lock for cp_rwsem during checkpoint

2020-05-11 Thread Jaegeuk Kim
On 05/12, Chao Yu wrote: > On 2020/5/12 6:11, Jaegeuk Kim wrote: > > On 05/11, Chao Yu wrote: > >> On 2020/5/10 3:03, Jaegeuk Kim wrote: > >>> On 05/09, Chao Yu wrote: > On 2020/5/9 0:10, Jaegeuk Kim wrote: > > Hi Sayali, > > > > In order to address the perf regression, how about t

Re: [f2fs-dev] [PATCH V4] f2fs: Avoid double lock for cp_rwsem during checkpoint

2020-05-11 Thread Chao Yu
On 2020/5/12 6:11, Jaegeuk Kim wrote: > On 05/11, Chao Yu wrote: >> On 2020/5/10 3:03, Jaegeuk Kim wrote: >>> On 05/09, Chao Yu wrote: On 2020/5/9 0:10, Jaegeuk Kim wrote: > Hi Sayali, > > In order to address the perf regression, how about this? > > >From 48418af635884803ff

Re: [f2fs-dev] [PATCH V4] f2fs: Avoid double lock for cp_rwsem during checkpoint

2020-05-11 Thread Jaegeuk Kim
On 05/11, Chao Yu wrote: > On 2020/5/10 3:03, Jaegeuk Kim wrote: > > On 05/09, Chao Yu wrote: > >> On 2020/5/9 0:10, Jaegeuk Kim wrote: > >>> Hi Sayali, > >>> > >>> In order to address the perf regression, how about this? > >>> > >>> >From 48418af635884803ffb35972df7958a2e6649322 Mon Sep 17 00:00:0

Re: [f2fs-dev] [PATCH V4] f2fs: Avoid double lock for cp_rwsem during checkpoint

2020-05-10 Thread Chao Yu
On 2020/5/10 3:03, Jaegeuk Kim wrote: > On 05/09, Chao Yu wrote: >> On 2020/5/9 0:10, Jaegeuk Kim wrote: >>> Hi Sayali, >>> >>> In order to address the perf regression, how about this? >>> >>> >From 48418af635884803ffb35972df7958a2e6649322 Mon Sep 17 00:00:00 2001 >>> From: Jaegeuk Kim >>> Date: F

Re: [f2fs-dev] [PATCH V4] f2fs: Avoid double lock for cp_rwsem during checkpoint

2020-05-09 Thread Jaegeuk Kim
On 05/09, Chao Yu wrote: > On 2020/5/9 0:10, Jaegeuk Kim wrote: > > Hi Sayali, > > > > In order to address the perf regression, how about this? > > > >>From 48418af635884803ffb35972df7958a2e6649322 Mon Sep 17 00:00:00 2001 > > From: Jaegeuk Kim > > Date: Fri, 8 May 2020 09:08:37 -0700 > > Subjec

Re: [f2fs-dev] [PATCH V4] f2fs: Avoid double lock for cp_rwsem during checkpoint

2020-05-08 Thread Chao Yu
On 2020/5/9 0:10, Jaegeuk Kim wrote: > Hi Sayali, > > In order to address the perf regression, how about this? > >>From 48418af635884803ffb35972df7958a2e6649322 Mon Sep 17 00:00:00 2001 > From: Jaegeuk Kim > Date: Fri, 8 May 2020 09:08:37 -0700 > Subject: [PATCH] f2fs: avoid double lock for cp_r

Re: [f2fs-dev] [PATCH V4] f2fs: Avoid double lock for cp_rwsem during checkpoint

2020-05-08 Thread Jaegeuk Kim
Hi Sayali, In order to address the perf regression, how about this? >From 48418af635884803ffb35972df7958a2e6649322 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Fri, 8 May 2020 09:08:37 -0700 Subject: [PATCH] f2fs: avoid double lock for cp_rwsem during checkpoint There could be a scenario wh

Re: [f2fs-dev] [PATCH V4] f2fs: Avoid double lock for cp_rwsem during checkpoint

2020-05-05 Thread Chao Yu
On 2020/4/30 18:58, Sayali Lokhande wrote: > There could be a scenario where f2fs_sync_node_pages gets > called during checkpoint, which in turn tries to flush > inline data and calls iput(). This results in deadlock as > iput() tries to hold cp_rwsem, which is already held at the > beginning by ch

[f2fs-dev] [PATCH V4] f2fs: Avoid double lock for cp_rwsem during checkpoint

2020-04-30 Thread Sayali Lokhande
There could be a scenario where f2fs_sync_node_pages gets called during checkpoint, which in turn tries to flush inline data and calls iput(). This results in deadlock as iput() tries to hold cp_rwsem, which is already held at the beginning by checkpoint->block_operations(). Call stack : Thread A