Re: [f2fs-dev] [PATCH v2] f2fs: do more sanity check on inode

2023-06-12 Thread Chao Yu
On 2023/6/13 4:16, Jaegeuk Kim wrote: On 05/31, Chao Yu wrote: There are several issues in sanity_check_inode(): - The code looks not clean, it checks extra_attr related condition dispersively. - It missed to check i_extra_isize w/ lower boundary - It missed to check feature dependency:

Re: [f2fs-dev] [PATCH v2] f2fs: do more sanity check on inode

2023-06-12 Thread Jaegeuk Kim
On 05/31, Chao Yu wrote: > There are several issues in sanity_check_inode(): > - The code looks not clean, it checks extra_attr related condition > dispersively. > - It missed to check i_extra_isize w/ lower boundary > - It missed to check feature dependency: prjquota, inode_chksum, >

Re: [f2fs-dev] [PATCH v2] f2fs: do more sanity check on inode

2023-06-07 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 31 May 2023 09:40:55 +0800 you wrote: > There are several issues in sanity_check_inode(): > - The code looks not clean, it checks extra_attr related condition > dispersively. > - It missed to check i_extra_isize w/

[f2fs-dev] [PATCH v2] f2fs: do more sanity check on inode

2023-05-30 Thread Chao Yu
There are several issues in sanity_check_inode(): - The code looks not clean, it checks extra_attr related condition dispersively. - It missed to check i_extra_isize w/ lower boundary - It missed to check feature dependency: prjquota, inode_chksum, inode_crtime, compression features rely on