Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-08-07 Thread Chao Yu
On 2023/8/8 3:55, Jaegeuk Kim wrote: On 08/07, Chao Yu wrote: On 2023/8/5 4:52, Jaegeuk Kim wrote: On 07/25, Chao Yu wrote: On 2023/7/22 4:23, Jaegeuk Kim wrote: On 07/13, Chao Yu wrote: On 2023/7/12 23:55, Jaegeuk Kim wrote: On 07/12, Chao Yu wrote: On 2023/7/12 0:37, Jaegeuk Kim wrote:

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-08-07 Thread Jaegeuk Kim
On 08/07, Chao Yu wrote: > On 2023/8/5 4:52, Jaegeuk Kim wrote: > > On 07/25, Chao Yu wrote: > > > On 2023/7/22 4:23, Jaegeuk Kim wrote: > > > > On 07/13, Chao Yu wrote: > > > > > On 2023/7/12 23:55, Jaegeuk Kim wrote: > > > > > > On 07/12, Chao Yu wrote: > > > > > > > On 2023/7/12 0:37, Jaegeuk Ki

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-08-06 Thread Chao Yu
On 2023/8/5 4:52, Jaegeuk Kim wrote: On 07/25, Chao Yu wrote: On 2023/7/22 4:23, Jaegeuk Kim wrote: On 07/13, Chao Yu wrote: On 2023/7/12 23:55, Jaegeuk Kim wrote: On 07/12, Chao Yu wrote: On 2023/7/12 0:37, Jaegeuk Kim wrote: On 07/06, Chao Yu wrote: On 2023/7/6 1:30, Jaegeuk Kim wrote:

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-08-04 Thread Jaegeuk Kim
On 07/25, Chao Yu wrote: > On 2023/7/22 4:23, Jaegeuk Kim wrote: > > On 07/13, Chao Yu wrote: > > > On 2023/7/12 23:55, Jaegeuk Kim wrote: > > > > On 07/12, Chao Yu wrote: > > > > > On 2023/7/12 0:37, Jaegeuk Kim wrote: > > > > > > On 07/06, Chao Yu wrote: > > > > > > > On 2023/7/6 1:30, Jaegeuk Ki

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-25 Thread Chao Yu
On 2023/7/22 4:23, Jaegeuk Kim wrote: On 07/13, Chao Yu wrote: On 2023/7/12 23:55, Jaegeuk Kim wrote: On 07/12, Chao Yu wrote: On 2023/7/12 0:37, Jaegeuk Kim wrote: On 07/06, Chao Yu wrote: On 2023/7/6 1:30, Jaegeuk Kim wrote: On 07/04, Chao Yu wrote: On 2023/7/4 18:53, Jaegeuk Kim wrote:

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-21 Thread Jaegeuk Kim
On 07/13, Chao Yu wrote: > On 2023/7/12 23:55, Jaegeuk Kim wrote: > > On 07/12, Chao Yu wrote: > > > On 2023/7/12 0:37, Jaegeuk Kim wrote: > > > > On 07/06, Chao Yu wrote: > > > > > On 2023/7/6 1:30, Jaegeuk Kim wrote: > > > > > > On 07/04, Chao Yu wrote: > > > > > > > On 2023/7/4 18:53, Jaegeuk Ki

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-17 Thread Chao Yu
Comments? On 2023/7/13 9:31, Chao Yu wrote: On 2023/7/12 23:55, Jaegeuk Kim wrote: On 07/12, Chao Yu wrote: On 2023/7/12 0:37, Jaegeuk Kim wrote: On 07/06, Chao Yu wrote: On 2023/7/6 1:30, Jaegeuk Kim wrote: On 07/04, Chao Yu wrote: On 2023/7/4 18:53, Jaegeuk Kim wrote: On 07/03, Chao Yu

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-12 Thread Chao Yu
On 2023/7/12 23:55, Jaegeuk Kim wrote: On 07/12, Chao Yu wrote: On 2023/7/12 0:37, Jaegeuk Kim wrote: On 07/06, Chao Yu wrote: On 2023/7/6 1:30, Jaegeuk Kim wrote: On 07/04, Chao Yu wrote: On 2023/7/4 18:53, Jaegeuk Kim wrote: On 07/03, Chao Yu wrote: On 2023/6/15 0:10, Jaegeuk Kim wrote:

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-12 Thread Jaegeuk Kim
On 07/12, Chao Yu wrote: > On 2023/7/12 0:37, Jaegeuk Kim wrote: > > On 07/06, Chao Yu wrote: > > > On 2023/7/6 1:30, Jaegeuk Kim wrote: > > > > On 07/04, Chao Yu wrote: > > > > > On 2023/7/4 18:53, Jaegeuk Kim wrote: > > > > > > On 07/03, Chao Yu wrote: > > > > > > > On 2023/6/15 0:10, Jaegeuk Kim

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-11 Thread Chao Yu
On 2023/7/12 0:37, Jaegeuk Kim wrote: On 07/06, Chao Yu wrote: On 2023/7/6 1:30, Jaegeuk Kim wrote: On 07/04, Chao Yu wrote: On 2023/7/4 18:53, Jaegeuk Kim wrote: On 07/03, Chao Yu wrote: On 2023/6/15 0:10, Jaegeuk Kim wrote: If there're huge # of small discards, this will increase checkpoi

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-11 Thread Jaegeuk Kim
On 07/06, Chao Yu wrote: > On 2023/7/6 1:30, Jaegeuk Kim wrote: > > On 07/04, Chao Yu wrote: > > > On 2023/7/4 18:53, Jaegeuk Kim wrote: > > > > On 07/03, Chao Yu wrote: > > > > > On 2023/6/15 0:10, Jaegeuk Kim wrote: > > > > > > If there're huge # of small discards, this will increase checkpoint

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-11 Thread Chao Yu
On 2023/7/6 8:46, Chao Yu wrote: On 2023/7/6 1:30, Jaegeuk Kim wrote: On 07/04, Chao Yu wrote: On 2023/7/4 18:53, Jaegeuk Kim wrote: On 07/03, Chao Yu wrote: On 2023/6/15 0:10, Jaegeuk Kim wrote: If there're huge # of small discards, this will increase checkpoint latency insanely. Let's issu

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-05 Thread Chao Yu
On 2023/7/6 1:30, Jaegeuk Kim wrote: On 07/04, Chao Yu wrote: On 2023/7/4 18:53, Jaegeuk Kim wrote: On 07/03, Chao Yu wrote: On 2023/6/15 0:10, Jaegeuk Kim wrote: If there're huge # of small discards, this will increase checkpoint latency insanely. Let's issue small discards only by trim. Si

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-05 Thread Jaegeuk Kim
On 07/04, Chao Yu wrote: > On 2023/7/4 18:53, Jaegeuk Kim wrote: > > On 07/03, Chao Yu wrote: > > > On 2023/6/15 0:10, Jaegeuk Kim wrote: > > > > If there're huge # of small discards, this will increase checkpoint > > > > latency > > > > insanely. Let's issue small discards only by trim. > > > >

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-04 Thread Chao Yu
On 2023/7/4 18:53, Jaegeuk Kim wrote: On 07/03, Chao Yu wrote: On 2023/6/15 0:10, Jaegeuk Kim wrote: If there're huge # of small discards, this will increase checkpoint latency insanely. Let's issue small discards only by trim. Signed-off-by: Jaegeuk Kim --- Change log from v1: - move

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-04 Thread Jaegeuk Kim
On 07/03, Chao Yu wrote: > On 2023/6/15 0:10, Jaegeuk Kim wrote: > > If there're huge # of small discards, this will increase checkpoint latency > > insanely. Let's issue small discards only by trim. > > > > Signed-off-by: Jaegeuk Kim > > --- > > > > Change log from v1: > >- move the skip

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-02 Thread Chao Yu
On 2023/6/15 0:10, Jaegeuk Kim wrote: If there're huge # of small discards, this will increase checkpoint latency insanely. Let's issue small discards only by trim. Signed-off-by: Jaegeuk Kim --- Change log from v1: - move the skip logic to avoid dangling objects fs/f2fs/segment.c | 2

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-06-14 Thread Jaegeuk Kim
If there're huge # of small discards, this will increase checkpoint latency insanely. Let's issue small discards only by trim. Signed-off-by: Jaegeuk Kim --- Change log from v1: - move the skip logic to avoid dangling objects fs/f2fs/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 delet