Re: [f2fs-dev] [PATCH v2] f2fs: reduce expensive checkpoint trigger frequency

2021-05-10 Thread Chao Yu
On 2021/5/10 23:36, Jaegeuk Kim wrote: On 05/06, Chao Yu wrote: On 2021/5/6 12:43, Jaegeuk Kim wrote: On 05/06, Chao Yu wrote: On 2021/5/4 22:36, Jaegeuk Kim wrote: On 04/27, Chao Yu wrote: On 2021/4/27 1:09, Jaegeuk Kim wrote: On 04/25, Chao Yu wrote: We may trigger high frequent checkpoi

Re: [f2fs-dev] [PATCH v2] f2fs: reduce expensive checkpoint trigger frequency

2021-05-10 Thread Jaegeuk Kim
On 05/06, Chao Yu wrote: > On 2021/5/6 12:43, Jaegeuk Kim wrote: > > On 05/06, Chao Yu wrote: > > > On 2021/5/4 22:36, Jaegeuk Kim wrote: > > > > On 04/27, Chao Yu wrote: > > > > > On 2021/4/27 1:09, Jaegeuk Kim wrote: > > > > > > On 04/25, Chao Yu wrote: > > > > > > > We may trigger high frequent

Re: [f2fs-dev] [PATCH v2] f2fs: reduce expensive checkpoint trigger frequency

2021-05-06 Thread Chao Yu
On 2021/5/7 14:33, Eric Biggers wrote: On Sun, Apr 25, 2021 at 09:10:53AM +0800, Chao Yu wrote: + if (!error && S_ISDIR(inode->i_mode) && f2fs_encrypted_file(inode) && + f2fs_is_checkpointed_node(sbi, inode->i_ino)) + f2fs_add_ino_entry(sbi, inode->i_ino

Re: [f2fs-dev] [PATCH v2] f2fs: reduce expensive checkpoint trigger frequency

2021-05-06 Thread Eric Biggers
On Sun, Apr 25, 2021 at 09:10:53AM +0800, Chao Yu wrote: > + if (!error && S_ISDIR(inode->i_mode) && f2fs_encrypted_file(inode) && > + f2fs_is_checkpointed_node(sbi, inode->i_ino)) > + f2fs_add_ino_entry(sbi, inode->i_ino, ENC_DIR_INO); This will never be true,

Re: [f2fs-dev] [PATCH v2] f2fs: reduce expensive checkpoint trigger frequency

2021-05-05 Thread Chao Yu
On 2021/5/6 12:43, Jaegeuk Kim wrote: On 05/06, Chao Yu wrote: On 2021/5/4 22:36, Jaegeuk Kim wrote: On 04/27, Chao Yu wrote: On 2021/4/27 1:09, Jaegeuk Kim wrote: On 04/25, Chao Yu wrote: We may trigger high frequent checkpoint for below case: 1. mkdir /mnt/dir1; set dir1 encrypted 2. touch

Re: [f2fs-dev] [PATCH v2] f2fs: reduce expensive checkpoint trigger frequency

2021-05-05 Thread Jaegeuk Kim
On 05/06, Chao Yu wrote: > On 2021/5/4 22:36, Jaegeuk Kim wrote: > > On 04/27, Chao Yu wrote: > > > On 2021/4/27 1:09, Jaegeuk Kim wrote: > > > > On 04/25, Chao Yu wrote: > > > > > We may trigger high frequent checkpoint for below case: > > > > > 1. mkdir /mnt/dir1; set dir1 encrypted > > > > > 2.

Re: [f2fs-dev] [PATCH v2] f2fs: reduce expensive checkpoint trigger frequency

2021-05-05 Thread Chao Yu
On 2021/5/4 22:36, Jaegeuk Kim wrote: On 04/27, Chao Yu wrote: On 2021/4/27 1:09, Jaegeuk Kim wrote: On 04/25, Chao Yu wrote: We may trigger high frequent checkpoint for below case: 1. mkdir /mnt/dir1; set dir1 encrypted 2. touch /mnt/file1; fsync /mnt/file1 3. mkdir /mnt/dir2; set dir2 encryp

Re: [f2fs-dev] [PATCH v2] f2fs: reduce expensive checkpoint trigger frequency

2021-05-04 Thread Jaegeuk Kim
On 04/27, Chao Yu wrote: > On 2021/4/27 1:09, Jaegeuk Kim wrote: > > On 04/25, Chao Yu wrote: > > > We may trigger high frequent checkpoint for below case: > > > 1. mkdir /mnt/dir1; set dir1 encrypted > > > 2. touch /mnt/file1; fsync /mnt/file1 > > > 3. mkdir /mnt/dir2; set dir2 encrypted > > > 4.

Re: [f2fs-dev] [PATCH v2] f2fs: reduce expensive checkpoint trigger frequency

2021-04-26 Thread Chao Yu
On 2021/4/27 1:09, Jaegeuk Kim wrote: On 04/25, Chao Yu wrote: We may trigger high frequent checkpoint for below case: 1. mkdir /mnt/dir1; set dir1 encrypted 2. touch /mnt/file1; fsync /mnt/file1 3. mkdir /mnt/dir2; set dir2 encrypted 4. touch /mnt/file2; fsync /mnt/file2 ... Although, newly cr

Re: [f2fs-dev] [PATCH v2] f2fs: reduce expensive checkpoint trigger frequency

2021-04-26 Thread Jaegeuk Kim
On 04/25, Chao Yu wrote: > We may trigger high frequent checkpoint for below case: > 1. mkdir /mnt/dir1; set dir1 encrypted > 2. touch /mnt/file1; fsync /mnt/file1 > 3. mkdir /mnt/dir2; set dir2 encrypted > 4. touch /mnt/file2; fsync /mnt/file2 > ... > > Although, newly created dir and file are no

[f2fs-dev] [PATCH v2] f2fs: reduce expensive checkpoint trigger frequency

2021-04-25 Thread Chao Yu
We may trigger high frequent checkpoint for below case: 1. mkdir /mnt/dir1; set dir1 encrypted 2. touch /mnt/file1; fsync /mnt/file1 3. mkdir /mnt/dir2; set dir2 encrypted 4. touch /mnt/file2; fsync /mnt/file2 ... Although, newly created dir and file are not related, due to commit bbf156f7afa7 ("f