Re: [f2fs-dev] [PATCH v2 2/4] block: fix ioprio interface

2021-08-06 Thread Hannes Reinecke
On 8/6/21 8:57 AM, Damien Le Moal wrote: > On 2021/08/06 15:35, Hannes Reinecke wrote: >> On 8/6/21 7:11 AM, Damien Le Moal wrote: >>> An iocb aio_reqprio field is 16-bits (u16) but often handled as an int >>> in the block layer. E.g. ioprio_check_cap() takes an int as argument. >>> With such impli

Re: [f2fs-dev] [PATCH v2 2/4] block: fix ioprio interface

2021-08-06 Thread Damien Le Moal
On 2021/08/06 15:35, Hannes Reinecke wrote: > On 8/6/21 7:11 AM, Damien Le Moal wrote: >> An iocb aio_reqprio field is 16-bits (u16) but often handled as an int >> in the block layer. E.g. ioprio_check_cap() takes an int as argument. >> With such implicit int casting function calls, the upper 16-bi

Re: [f2fs-dev] [PATCH v2 2/4] block: fix ioprio interface

2021-08-05 Thread Hannes Reinecke
On 8/6/21 7:11 AM, Damien Le Moal wrote: An iocb aio_reqprio field is 16-bits (u16) but often handled as an int in the block layer. E.g. ioprio_check_cap() takes an int as argument. With such implicit int casting function calls, the upper 16-bits of the int argument may be left uninitialized by t

[f2fs-dev] [PATCH v2 2/4] block: fix ioprio interface

2021-08-05 Thread Damien Le Moal
An iocb aio_reqprio field is 16-bits (u16) but often handled as an int in the block layer. E.g. ioprio_check_cap() takes an int as argument. With such implicit int casting function calls, the upper 16-bits of the int argument may be left uninitialized by the compiler, resulting in invalid values fo