Re: [f2fs-dev] [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Daeho Jeong
2021년 3월 12일 (금) 오후 11:45, Greg KH 님이 작성: > > A: http://en.wikipedia.org/wiki/Top_post > Q: Were do I find info about this thing called top-posting? > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the m

Re: [f2fs-dev] [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Greg KH
On Fri, Mar 12, 2021 at 11:42:04PM +0900, Daeho Jeong wrote: > So, do you want we protect the values here with spin_lock and just > read without spin_lock in sysfs read part? I would not use any lock at all if this were my code. Remember, this is for debugging/information only, right? And the da

Re: [f2fs-dev] [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [f2fs-dev] [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Daeho Jeong
So, do you want we protect the values here with spin_lock and just read without spin_lock in sysfs read part? 2021년 3월 12일 (금) 오후 11:37, Daeho Jeong 님이 작성: > > As you can see, if we're doing like the below. > > sbi->compr_written_block += blocks; > > Let's assume the initial value as 0. > >

Re: [f2fs-dev] [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Daeho Jeong
As you can see, if we're doing like the below. sbi->compr_written_block += blocks; Let's assume the initial value as 0. sbi->compr_written_block = 0; sbi->compr_written_block = 0; +blocks(3);

Re: [f2fs-dev] [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Greg KH
On Fri, Mar 12, 2021 at 10:56:13PM +0900, Daeho Jeong wrote: > Thanks for suggesting me sysfs_emit(). > > For atomic values, actually, those are needed for writer part, not reader. > > +#define add_compr_block_stat(inode, blocks)\ > + do {

Re: [f2fs-dev] [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Daeho Jeong
Thanks for suggesting me sysfs_emit(). For atomic values, actually, those are needed for writer part, not reader. +#define add_compr_block_stat(inode, blocks)\ + do {\ + struct f2fs_sb_info

Re: [f2fs-dev] [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Greg KH
On Fri, Mar 12, 2021 at 09:25:31PM +0900, Daeho Jeong wrote: > From: Daeho Jeong > > I've added new sysfs nodes to show runtime compression stat since mount. > compr_written_block - show the block count written after compression > compr_saved_block - show the saved block count with compression >

[f2fs-dev] [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Daeho Jeong
From: Daeho Jeong I've added new sysfs nodes to show runtime compression stat since mount. compr_written_block - show the block count written after compression compr_saved_block - show the saved block count with compression compr_new_inode - show the count of inode newly enabled for compression