Re: [f2fs-dev] [PATCH v4] f2fs: fix potential .flags overflow on 32bit architecture

2020-03-22 Thread Chao Yu
On 2020/3/23 10:57, Joe Perches wrote: > On Mon, 2020-03-23 at 10:41 +0800, Chao Yu wrote: >> f2fs_inode_info.flags is unsigned long variable, it has 32 bits >> in 32bit architecture, since we introduced FI_MMAP_FILE flag >> when we support data compression, we may access memory cross >> the border

Re: [f2fs-dev] [PATCH v4] f2fs: fix potential .flags overflow on 32bit architecture

2020-03-22 Thread Chao Yu
On 2020/3/23 11:05, Ondřej Jirman wrote: > Hello, > > On Mon, Mar 23, 2020 at 10:41:09AM +0800, Chao Yu wrote: >> f2fs_inode_info.flags is unsigned long variable, it has 32 bits >> in 32bit architecture, since we introduced FI_MMAP_FILE flag >> when we support data compression, we may access memor

Re: [f2fs-dev] [PATCH v4] f2fs: fix potential .flags overflow on 32bit architecture

2020-03-22 Thread Ondřej Jirman
Hello, On Mon, Mar 23, 2020 at 10:41:09AM +0800, Chao Yu wrote: > f2fs_inode_info.flags is unsigned long variable, it has 32 bits > in 32bit architecture, since we introduced FI_MMAP_FILE flag > when we support data compression, we may access memory cross > the border of .flags field, corrupting .

Re: [f2fs-dev] [PATCH v4] f2fs: fix potential .flags overflow on 32bit architecture

2020-03-22 Thread Joe Perches
On Mon, 2020-03-23 at 10:41 +0800, Chao Yu wrote: > f2fs_inode_info.flags is unsigned long variable, it has 32 bits > in 32bit architecture, since we introduced FI_MMAP_FILE flag > when we support data compression, we may access memory cross > the border of .flags field, corrupting .i_sem field, re

[f2fs-dev] [PATCH v4] f2fs: fix potential .flags overflow on 32bit architecture

2020-03-22 Thread Chao Yu
f2fs_inode_info.flags is unsigned long variable, it has 32 bits in 32bit architecture, since we introduced FI_MMAP_FILE flag when we support data compression, we may access memory cross the border of .flags field, corrupting .i_sem field, result in below deadlock. To fix this issue, let's expand .