Re: [f2fs-dev] [PATCH v8] fsck.f2fs: Detect and fix looped node chain efficiently

2023-06-25 Thread Chunhai Guo via Linux-f2fs-devel
Hi Jaegeuk & Chao, OK. I will post a final version including the modification. Thanks. On 2023/6/24 2:50, Jaegeuk Kim wrote: On 06/23, Chao Yu wrote: On 2023/5/24 10:42, Chunhai Guo wrote: + if (!c.fix_on) { err = -1; break;

Re: [f2fs-dev] [PATCH v8] fsck.f2fs: Detect and fix looped node chain efficiently

2023-06-23 Thread Jaegeuk Kim
On 06/23, Chao Yu wrote: > On 2023/5/24 10:42, Chunhai Guo wrote: > > + if (!c.fix_on) { > > err = -1; > > break; > > } > > One more comment. > > I guess we'd better skip find_fsync_inode() and continue fsck rather > than exiting

Re: [f2fs-dev] [PATCH v8] fsck.f2fs: Detect and fix looped node chain efficiently

2023-06-22 Thread Chao Yu
On 2023/5/24 10:42, Chunhai Guo wrote: + if (!c.fix_on) { err = -1; break; } One more comment. I guess we'd better skip find_fsync_inode() and continue fsck rather than exiting directly if c.fix_on is not set,

Re: [f2fs-dev] [PATCH v8] fsck.f2fs: Detect and fix looped node chain efficiently

2023-06-21 Thread Chunhai Guo via Linux-f2fs-devel
Hi Chao, Sorry for replying late, I have send patch "fsck.f2fs: refactor looped node chain detetected logic for cleanup" as you suggested. Thanks. On 2023/6/17 10:20, Chao Yu wrote: On 2023/6/14 17:27, Chunhai Guo wrote: Hi Jaegeuk, Could you please help to confirm if this patch has been

Re: [f2fs-dev] [PATCH v8] fsck.f2fs: Detect and fix looped node chain efficiently

2023-06-16 Thread Chao Yu
On 2023/6/14 17:27, Chunhai Guo wrote: Hi Jaegeuk, Could you please help to confirm if this patch has been merged? I cannot see the patch in the dev-test or dev branch. Thanks. On 2023/5/24 10:42, 郭纯海 wrote: find_fsync_inode() detect the looped node chain by comparing the loop counter with

Re: [f2fs-dev] [PATCH v8] fsck.f2fs: Detect and fix looped node chain efficiently

2023-06-14 Thread Chunhai Guo via Linux-f2fs-devel
Got it. Thanks. On 2023/6/15 0:15, Jaegeuk Kim wrote: On 06/14, Chunhai Guo wrote: Hi Jaegeuk, Could you please help to confirm if this patch has been merged? I cannot see the patch in the dev-test or dev branch. Thanks. Somehow it was dropped. I start to test again. Thanks. On

Re: [f2fs-dev] [PATCH v8] fsck.f2fs: Detect and fix looped node chain efficiently

2023-06-14 Thread Jaegeuk Kim
On 06/14, Chunhai Guo wrote: > Hi Jaegeuk, > > Could you please help to confirm if this patch has been merged? I cannot see > the patch in the dev-test or dev branch. Thanks. Somehow it was dropped. I start to test again. > > Thanks. > > On 2023/5/24 10:42, 郭纯海 wrote: > > find_fsync_inode()

Re: [f2fs-dev] [PATCH v8] fsck.f2fs: Detect and fix looped node chain efficiently

2023-06-14 Thread Chunhai Guo via Linux-f2fs-devel
Hi Jaegeuk, Could you please help to confirm if this patch has been merged? I cannot see the patch in the dev-test or dev branch. Thanks. On 2023/5/24 10:42, 郭纯海 wrote: find_fsync_inode() detect the looped node chain by comparing the loop counter with free blocks. While it may take tens of

Re: [f2fs-dev] [PATCH v8] fsck.f2fs: Detect and fix looped node chain efficiently

2023-05-25 Thread Jaegeuk Kim
On 05/24, Chunhai Guo wrote: > find_fsync_inode() detect the looped node chain by comparing the loop > counter with free blocks. While it may take tens of seconds to quit when > the free blocks are large enough. We can use Floyd's cycle detection > algorithm to make the detection more efficient,

Re: [f2fs-dev] [PATCH v8] fsck.f2fs: Detect and fix looped node chain efficiently

2023-05-24 Thread Chao Yu
On 2023/5/24 10:42, Chunhai Guo wrote: find_fsync_inode() detect the looped node chain by comparing the loop counter with free blocks. While it may take tens of seconds to quit when the free blocks are large enough. We can use Floyd's cycle detection algorithm to make the detection more

[f2fs-dev] [PATCH v8] fsck.f2fs: Detect and fix looped node chain efficiently

2023-05-23 Thread Chunhai Guo via Linux-f2fs-devel
find_fsync_inode() detect the looped node chain by comparing the loop counter with free blocks. While it may take tens of seconds to quit when the free blocks are large enough. We can use Floyd's cycle detection algorithm to make the detection more efficient, and fix the issue by filling a NULL