Re: [f2fs-dev] [RFC PATCH 5/5] fsck.f2fs: reconnect unreachable files to lost+found

2018-02-13 Thread Chao Yu
On 2018/2/6 12:31, Sheng Yong wrote: > This patch introduces lost+found feature to fsck. If a file is found > unreachable by fsck. Fsck tries to reconnect the file to lost+found > directory: > 1. Scan all unreachable file inodes, ignore non-inodes ones and > directories. > 2. Check them

Re: [f2fs-dev] [RFC PATCH 5/5] fsck.f2fs: reconnect unreachable files to lost+found

2018-02-07 Thread Sheng Yong
On 2018/2/7 18:01, Sheng Yong wrote: [...] + +/* lookup lost+found in root directory */ +lpf_ino = f2fs_lookup(sbi, node, (u8 *) LPF, strlen(LPF)); The 4th parameter should be namelen but not strlen(LPF). Sorry for the noise. The comment here is wrong :( [...] + +static int

Re: [f2fs-dev] [RFC PATCH 5/5] fsck.f2fs: reconnect unreachable files to lost+found

2018-02-07 Thread Sheng Yong
On 2018/2/6 12:31, Sheng Yong wrote: This patch introduces lost+found feature to fsck. If a file is found unreachable by fsck. Fsck tries to reconnect the file to lost+found directory: 1. Scan all unreachable file inodes, ignore non-inodes ones and directories. 2. Check them and fix

[f2fs-dev] [RFC PATCH 5/5] fsck.f2fs: reconnect unreachable files to lost+found

2018-02-05 Thread Sheng Yong
This patch introduces lost+found feature to fsck. If a file is found unreachable by fsck. Fsck tries to reconnect the file to lost+found directory: 1. Scan all unreachable file inodes, ignore non-inodes ones and directories. 2. Check them and fix incorrupted data to make sure filesystem