Re: [f2fs-dev] [RFC PATCH 5/8] dump.f2fs: do not dump encrypted files

2017-10-31 Thread Chao Yu
On 2017/10/31 17:16, Sheng Yong wrote: > > > On 2017/10/31 15:57, Chao Yu wrote: >> On 2017/10/31 9:38, Sheng Yong wrote: >>> If a file is encrypted, its content is cipher text on the storage. So >>> there is no need to dump an encrypted file. >> >> IMO, if user have encryption key, it still has

Re: [f2fs-dev] [RFC PATCH 5/8] dump.f2fs: do not dump encrypted files

2017-10-31 Thread Sheng Yong
On 2017/10/31 15:57, Chao Yu wrote: On 2017/10/31 9:38, Sheng Yong wrote: If a file is encrypted, its content is cipher text on the storage. So there is no need to dump an encrypted file. IMO, if user have encryption key, it still has chance to read that file, right? So how about keeping

Re: [f2fs-dev] [RFC PATCH 5/8] dump.f2fs: do not dump encrypted files

2017-10-31 Thread Chao Yu
On 2017/10/31 9:38, Sheng Yong wrote: > If a file is encrypted, its content is cipher text on the storage. So > there is no need to dump an encrypted file. IMO, if user have encryption key, it still has chance to read that file, right? So how about keeping this functionality? Thanks, > >

[f2fs-dev] [RFC PATCH 5/8] dump.f2fs: do not dump encrypted files

2017-10-30 Thread Sheng Yong
If a file is encrypted, its content is cipher text on the storage. So there is no need to dump an encrypted file. Signed-off-by: Sheng Yong --- fsck/dump.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/fsck/dump.c b/fsck/dump.c index