[f2fs-dev] [RFC PATCH v2] fsck.f2fs: write checkpoint out of place first

2018-07-26 Thread Weichao Guo
We may encounter both checkpoints invalid in such a case: 1. write checkpoint A, B, C; 2. sudden power-cut during write checkpoint D; 3. fsck changes the total block count of checkpoint C; 4. sudden power-cut during fsck write checkpoint C in place - - | ver C |

Re: [f2fs-dev] [RFC PATCH v2] fsck.f2fs: write checkpoint out of place first

2018-07-27 Thread Chao Yu
On 2018/7/27 4:54, Weichao Guo wrote: > We may encounter both checkpoints invalid in such a case: > 1. write checkpoint A, B, C; > 2. sudden power-cut during write checkpoint D; > 3. fsck changes the total block count of checkpoint C; > 4. sudden power-cut during fsck write checkpoint C in place >

Re: [f2fs-dev] [RFC PATCH v2] fsck.f2fs: write checkpoint out of place first

2018-08-17 Thread Jaegeuk Kim
Hi Weichao, This is corrupting the checkpoint showing dangling nids when running my test where injects faults with shutdown loop. Thanks, On 07/28, Chao Yu wrote: > On 2018/7/27 4:54, Weichao Guo wrote: > > We may encounter both checkpoints invalid in such a case: > > 1. write checkpoint A, B, C

Re: [f2fs-dev] [RFC PATCH v2] fsck.f2fs: write checkpoint out of place first

2018-08-20 Thread guoweichao
Hi Jaegeuk, Is your test using a kernel include some unstable patches like "f2fs: guarantee journalled quota data by checkpoint"? I am planing to reproduce the problem with dev branch. Is that OK? Any hints for reproducing? Thank, Weichao On 2018/8/18 2:32, Jaegeuk Kim wrote: > Hi Weichao, >

Re: [f2fs-dev] [RFC PATCH v2] fsck.f2fs: write checkpoint out of place first

2018-08-20 Thread Jaegeuk Kim
On 08/20, guoweichao wrote: > Hi Jaegeuk, > > Is your test using a kernel include some unstable patches like "f2fs: > guarantee journalled quota data by checkpoint"? > I am planing to reproduce the problem with dev branch. Is that OK? Any hints > for reproducing? I actually removed such the pat