Re: [f2fs-dev] Space leak in f2fs

2015-05-17 Thread Jaegeuk Kim
fsde...@vger.kernel.org; > > linux-f2fs-devel@lists.sourceforge.net > > Subject: Re: [f2fs-dev] Space leak in f2fs > > > > Hi Chao, > > > > On Fri, May 15, 2015 at 04:31:43PM +0800, Chao Yu wrote: > > > Hi Jaegeuk, > > > > >

Re: [f2fs-dev] Space leak in f2fs

2015-05-17 Thread Nicholas Krause
l.org; >linux-f2fs-devel@lists.sourceforge.net >> Subject: Re: [f2fs-dev] Space leak in f2fs >> >> Hi Chao, >> >> On Fri, May 15, 2015 at 04:31:43PM +0800, Chao Yu wrote: >> > Hi Jaegeuk, >> > >> >> [snip] >> >>

Re: [f2fs-dev] Space leak in f2fs

2015-05-17 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Saturday, May 16, 2015 8:56 AM > To: Chao Yu > Cc: 'hujianyang'; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev]

Re: [f2fs-dev] Space leak in f2fs

2015-05-15 Thread Jaegeuk Kim
Hi Chao, On Fri, May 15, 2015 at 04:31:43PM +0800, Chao Yu wrote: > Hi Jaegeuk, > [snip] > > + /* if orphan inode, we don't need to write its data */ > > + if (is_orphan_inode(sbi, inode->i_ino)) > > + goto out; > > When user create a temp file by invoking open with O_TMPFILE fla

Re: [f2fs-dev] Space leak in f2fs

2015-05-15 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Friday, May 15, 2015 5:14 AM > To: hujianyang > Cc: linux-fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] Space leak in f2fs > &g

Re: [f2fs-dev] Space leak in f2fs

2015-05-14 Thread Jaegeuk Kim
Hi Hu, I've been rethinking about whole this issue differently. And, now I'm starting to test with the below patch instead of previous one. Thanks, Signed-off-by: Jaegeuk Kim --- fs/f2fs/checkpoint.c | 19 +++ fs/f2fs/data.c | 4 fs/f2fs/f2fs.h | 1 + fs/f2fs

Re: [f2fs-dev] Space leak in f2fs

2015-05-13 Thread Jaegeuk Kim
I'll push the patch into dev branch right now. Let me know, if there is any problem. Thanks, On Thu, May 14, 2015 at 09:40:25AM +0800, hujianyang wrote: > Hi Jaegeuk, > > I've tested this patch. It's OK now. Seems this problem is fixed. > > I'd like to push this patch to my local tree and run a

Re: [f2fs-dev] Space leak in f2fs

2015-05-13 Thread hujianyang
Hi Jaegeuk, I've tested this patch. It's OK now. Seems this problem is fixed. I'd like to push this patch to my local tree and run a formal stress test next week. Will you push this patch to f2fs-dev branch? If you have other modification to this fix, please let me know. Thanks very much! Hu O

Re: [f2fs-dev] Space leak in f2fs

2015-05-13 Thread Jaegeuk Kim
Hi Hu, Found a bug in the previous patch. Could you check this out? Thanks, --- fs/f2fs/super.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 19438f2..647591b 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -431,8 +

Re: [f2fs-dev] Space leak in f2fs

2015-05-13 Thread Jaegeuk Kim
Hi Hu, Thank you for the report. When I tried to reproduce this, it seems that this can occur under somewhat stressful condition. I could't reach out to this problem. Nevertheless, I think this is a possible scenario, so I wrote a patch for this. Could you test this patch? Thanks, --- fs/f2fs

[f2fs-dev] Space leak in f2fs

2015-05-13 Thread hujianyang
Hi Jaegeuk, I found a space leak problem in f2fs. This problem could lead to ENOSPC error during stress tests, e.g. ltp. <<>> growfiles(gf15): 11656 growfiles.c/2249: 16920 tlibio.c/739 write(6, buf, 1352) ret:-1, errno=28 No space left on device gf151 TFAIL : growfiles.c:132: Test fa