Re: [f2fs-dev] f2fs: avoid abnormal behavior on broken symlink

2015-04-22 Thread Dan Carpenter
On Wed, Apr 22, 2015 at 11:13:36AM -0700, Jaegeuk Kim wrote: > On Wed, Apr 22, 2015 at 01:27:22PM +0300, Dan Carpenter wrote: > > On Wed, Apr 22, 2015 at 02:28:22PM +0800, Chao Yu wrote: > > > > > fs/f2fs/namei.c > > > > >299 static void *f2fs_follow_link(struct dentry *dentry, struct > > > >

Re: [f2fs-dev] f2fs: avoid abnormal behavior on broken symlink

2015-04-22 Thread Jaegeuk Kim
On Wed, Apr 22, 2015 at 01:27:22PM +0300, Dan Carpenter wrote: > On Wed, Apr 22, 2015 at 02:28:22PM +0800, Chao Yu wrote: > > > > fs/f2fs/namei.c > > > >299 static void *f2fs_follow_link(struct dentry *dentry, struct > > > > nameidata *nd) > > > >300 { > > > >301 struct page

Re: [f2fs-dev] f2fs: avoid abnormal behavior on broken symlink

2015-04-22 Thread Jaegeuk Kim
'; linux-f2fs-devel@lists.sourceforge.net > > Subject: Re: [f2fs-dev] f2fs: avoid abnormal behavior on broken symlink > > > > Hi Chao, > > > > On Wed, Apr 22, 2015 at 02:28:22PM +0800, Chao Yu wrote: > > > Hi all, > > > > > > > -Original

Re: [f2fs-dev] f2fs: avoid abnormal behavior on broken symlink

2015-04-22 Thread Dan Carpenter
On Wed, Apr 22, 2015 at 02:28:22PM +0800, Chao Yu wrote: > > > fs/f2fs/namei.c > > >299 static void *f2fs_follow_link(struct dentry *dentry, struct > > > nameidata *nd) > > >300 { > > >301 struct page *page; > > >302 > > >303 page = page_follow_link_light(de

Re: [f2fs-dev] f2fs: avoid abnormal behavior on broken symlink

2015-04-22 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Wednesday, April 22, 2015 3:49 PM > To: Chao Yu > Cc: 'Dan Carpenter'; linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] f2fs: avoid abnormal behavior on

Re: [f2fs-dev] f2fs: avoid abnormal behavior on broken symlink

2015-04-22 Thread Jaegeuk Kim
urceforge.net > > Subject: Re: [f2fs-dev] f2fs: avoid abnormal behavior on broken symlink > > > > Hi Dan, > > > > Thank you for letting me know. > > I wrote a patch for this below. > > > > Thanks, > > > > On Mon, Apr 20, 2015 at 05:49:47P

Re: [f2fs-dev] f2fs: avoid abnormal behavior on broken symlink

2015-04-21 Thread Chao Yu
Hi all, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Wednesday, April 22, 2015 2:21 AM > To: Dan Carpenter > Cc: linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] f2fs: avoid abnormal behavior on broken symlink > > Hi

Re: [f2fs-dev] f2fs: avoid abnormal behavior on broken symlink

2015-04-21 Thread Jaegeuk Kim
Hi Dan, Thank you for letting me know. I wrote a patch for this below. Thanks, On Mon, Apr 20, 2015 at 05:49:47PM +0300, Dan Carpenter wrote: > Hello Jaegeuk Kim, > > The patch feb7cbb079e6: "f2fs: avoid abnormal behavior on broken > symlink" from Apr 15, 2015, leads to the following static che

Re: [f2fs-dev] f2fs: avoid abnormal behavior on broken symlink

2015-04-20 Thread Dan Carpenter
Hello Jaegeuk Kim, The patch feb7cbb079e6: "f2fs: avoid abnormal behavior on broken symlink" from Apr 15, 2015, leads to the following static checker warning: fs/f2fs/namei.c:304 f2fs_follow_link() warn: 'page' isn't an ERR_PTR fs/f2fs/namei.c 299 static void *f2fs_follow_lin