Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address

On 2024/4/28 9:23, Daeho Jeong wrote: I have a question. Is it okay for META_GENERIC? It seems all users of META_GENERIC comes from IO paths: a) f2fs_merge_page_bio b) f2fs_submit_page_bio c) f2fs_submit_page_write - verify_fio_blkaddr They are all impossible cases? so it's fine to record the

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address

On Thu, Apr 25, 2024 at 12:30 AM Chao Yu wrote: > > On 2024/4/19 18:27, Juhyung Park wrote: > > On Sat, Apr 13, 2024 at 5:57 AM Jaegeuk Kim wrote: > >> > >> On 04/11, Chao Yu wrote: > >>> On 2024/4/10 4:34, Jaegeuk Kim wrote: > f2fs_ra_meta_pages can try to read ahead on invalid block addres

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address

On 2024/4/19 18:27, Juhyung Park wrote: On Sat, Apr 13, 2024 at 5:57 AM Jaegeuk Kim wrote: On 04/11, Chao Yu wrote: On 2024/4/10 4:34, Jaegeuk Kim wrote: f2fs_ra_meta_pages can try to read ahead on invalid block address which is not the corruption case. In which case we will read ahead inv

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address

On 04/19, Juhyung Park wrote: > On Sat, Apr 13, 2024 at 5:57 AM Jaegeuk Kim wrote: > > > > On 04/11, Chao Yu wrote: > > > On 2024/4/10 4:34, Jaegeuk Kim wrote: > > > > f2fs_ra_meta_pages can try to read ahead on invalid block address which > > > > is > > > > not the corruption case. > > > > > > I

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address

On Sat, Apr 13, 2024 at 5:57 AM Jaegeuk Kim wrote: > > On 04/11, Chao Yu wrote: > > On 2024/4/10 4:34, Jaegeuk Kim wrote: > > > f2fs_ra_meta_pages can try to read ahead on invalid block address which is > > > not the corruption case. > > > > In which case we will read ahead invalid meta pages? rec

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address

On 04/11, Chao Yu wrote: > On 2024/4/10 4:34, Jaegeuk Kim wrote: > > f2fs_ra_meta_pages can try to read ahead on invalid block address which is > > not the corruption case. > > In which case we will read ahead invalid meta pages? recovery w/ META_POR? I was trying to debug another issue, but foun

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix false alarm on invalid block address

On 2024/4/10 4:34, Jaegeuk Kim wrote: f2fs_ra_meta_pages can try to read ahead on invalid block address which is not the corruption case. In which case we will read ahead invalid meta pages? recovery w/ META_POR? Thanks, Fixes: 31f85ccc84b8 ("f2fs: unify the error handling of f2fs_is_valid_