Re: [f2fs-dev] [PATCH v5 5/9] btrfs: zstd: Switch to the zstd-1.4.6 API

2020-11-06 Thread Josef Bacik
On 11/3/20 1:05 AM, Nick Terrell wrote: From: Nick Terrell Move away from the compatibility wrapper to the zstd-1.4.6 API. This code is functionally equivalent. Signed-off-by: Nick Terrell --- fs/btrfs/zstd.c | 48 1 file changed, 28 inserti

Re: [f2fs-dev] [GIT PULL][PATCH v5 0/9] Update to zstd-1.4.6

2020-11-06 Thread Josef Bacik
On 11/3/20 1:05 AM, Nick Terrell wrote: From: Nick Terrell Please pull from g...@github.com:terrelln/linux.git tags/v5-zstd-1.4.6 to get these changes. Alternatively the patchset is included. Where did we come down on the code formatting question? Personally I'm of the mind that as lo

Re: [f2fs-dev] [PATCH v4 2/2] f2fs: fix compat F2FS_IOC_{MOVE, GARBAGE_COLLECT}_RANGE

2020-11-06 Thread Eric Biggers
On Fri, Nov 06, 2020 at 02:53:31PM +0800, Chao Yu wrote: > +#if defined(__KERNEL__) > +struct compat_f2fs_gc_range { > + u32 sync; > + compat_u64 start; > + compat_u64 len; > +}; There's no need to use '#if defined(__KERNEL__)' in kernel source files. Likewise for compat_f2fs_move_ran

Re: [f2fs-dev] [PATCH v5 5/9] btrfs: zstd: Switch to the zstd-1.4.6 API

2020-11-06 Thread Nick Terrell via Linux-f2fs-devel
> On Nov 6, 2020, at 9:10 AM, Josef Bacik wrote: > > On 11/3/20 1:05 AM, Nick Terrell wrote: >> From: Nick Terrell >> Move away from the compatibility wrapper to the zstd-1.4.6 API. This >> code is functionally equivalent. >> Signed-off-by: Nick Terrell >> --- >> fs/btrfs/zstd.c | 48 +++

Re: [f2fs-dev] [PATCH v5 1/9] lib: zstd: Add zstd compatibility wrapper

2020-11-06 Thread Christoph Hellwig
You just keep resedning this crap, don't you? Haven't you been told multiple times to provide a proper kernel API by now? On Mon, Nov 02, 2020 at 10:05:27PM -0800, Nick Terrell wrote: > From: Nick Terrell > > Adds zstd_compat.h which provides the necessary functions from the > current zstd.h AP

Re: [f2fs-dev] [GIT PULL][PATCH v5 0/9] Update to zstd-1.4.6

2020-11-06 Thread Nick Terrell via Linux-f2fs-devel
> On Nov 6, 2020, at 9:15 AM, Josef Bacik wrote: > > On 11/3/20 1:05 AM, Nick Terrell wrote: >> From: Nick Terrell >> Please pull from >> g...@github.com:terrelln/linux.git tags/v5-zstd-1.4.6 >> to get these changes. Alternatively the patchset is included. > > Where did we come down on the co

Re: [f2fs-dev] [PATCH] f2fs: compress: support chksum

2020-11-06 Thread Jaegeuk Kim
On 11/03, Chao Yu wrote: > On 2020/11/3 10:02, Chao Yu wrote: > > On 2020/11/3 0:31, Jaegeuk Kim wrote: > > > On 11/02, Chao Yu wrote: > > > > This patch supports to store chksum value with compressed > > > > data, and verify the integrality of compressed data while > > > > reading the data. > > >

Re: [f2fs-dev] [PATCH v3 2/2] f2fs: fix compat F2FS_IOC_{MOVE, GARBAGE_COLLECT}_RANGE

2020-11-06 Thread Jaegeuk Kim
On 11/06, Chao Yu wrote: > On 2020/11/6 8:05, Eric Biggers wrote: > > This patch is marked 2/2, but it seems you sent it out on its own. Patch > > series > > are supposed to be resend in full; otherwise people can see just one patch > > and > > have no context. > > That's a historical problem,