[f2fs-dev] [PATCH] f2fs: fix double free of unicode map

2020-11-12 Thread Hyeongseok Kim
In case of retrying fill_super with skip_recovery, s_encoding for casefold would not be loaded again even though it's already been freed because it's not NULL. Set NULL after free to prevent double freeing when unmount. Signed-off-by: Hyeongseok Kim --- fs/f2fs/super.c | 1 + 1 file changed, 1 i

Re: [f2fs-dev] [PATCH] f2fs: fix double free of unicode map

2020-11-12 Thread Eric Biggers
On Thu, Nov 12, 2020 at 05:02:01PM +0900, Hyeongseok Kim wrote: > In case of retrying fill_super with skip_recovery, > s_encoding for casefold would not be loaded again even though it's > already been freed because it's not NULL. > Set NULL after free to prevent double freeing when unmount. > > Si

Re: [f2fs-dev] [PATCH] f2fs: fix double free of unicode map

2020-11-12 Thread hyeongseok
On 11/12/20 5:17 PM, Eric Biggers wrote: On Thu, Nov 12, 2020 at 05:02:01PM +0900, Hyeongseok Kim wrote: In case of retrying fill_super with skip_recovery, s_encoding for casefold would not be loaded again even though it's already been freed because it's not NULL. Set NULL after free to prevent

[f2fs-dev] [PATCH v2] f2fs: fix double free of unicode map

2020-11-12 Thread Hyeongseok Kim
In case of retrying fill_super with skip_recovery, s_encoding for casefold would not be loaded again even though it's already been freed because it's not NULL. Set NULL after free to prevent double freeing when unmount. Fixes: eca4873ee1b6 ("f2fs: Use generic casefolding support") Signed-off-by: H

Re: [f2fs-dev] [PATCH v2] f2fs: fix double free of unicode map

2020-11-12 Thread Chao Yu
On 2020/11/12 17:14, Hyeongseok Kim wrote: In case of retrying fill_super with skip_recovery, s_encoding for casefold would not be loaded again even though it's already been freed because it's not NULL. Set NULL after free to prevent double freeing when unmount. Fixes: eca4873ee1b6 ("f2fs: Use g

Re: [f2fs-dev] [PATCH] fscrypt: fix inline encryption not used on new files

2020-11-12 Thread Eric Biggers
On Tue, Nov 10, 2020 at 05:52:24PM -0800, Eric Biggers wrote: > From: Eric Biggers > > The new helper function fscrypt_prepare_new_inode() runs before > S_ENCRYPTED has been set on the new inode. This accidentally made > fscrypt_select_encryption_impl() never enable inline encryption on newly >

[f2fs-dev] [GIT PULL] another fscrypt fix for 5.10-rc4

2020-11-12 Thread Eric Biggers
The following changes since commit 92cfcd030e4b1de11a6b1edb0840e55c26332d31: fscrypt: remove reachable WARN in fscrypt_setup_iv_ino_lblk_32_key() (2020-11-06 09:48:55 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/fs/fscrypt/fscrypt.git tags/fscrypt-for-linu

Re: [f2fs-dev] [GIT PULL] another fscrypt fix for 5.10-rc4

2020-11-12 Thread pr-tracker-bot
The pull request you sent on Thu, 12 Nov 2020 15:16:30 -0800: > https://git.kernel.org/pub/scm/fs/fscrypt/fscrypt.git tags/fscrypt-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/585e5b17b92dead8a3aca4e3c9876fbca5f7e0ba Thank you! -- Deet-doot-dot, I am a b

[f2fs-dev] [PATCH] f2fs: fix the bug in f2fs_direct_IO with inline encryption

2020-11-12 Thread Lihong Kou
Now we have inline encrytion and fs layer encrption in the kernel, when we choose inline encryption, we should not use bufferd IO instead of direct IO. Signed-off-by: Lihong Kou --- fs/f2fs/f2fs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2

Re: [f2fs-dev] [PATCH] f2fs: fix the bug in f2fs_direct_IO with inline encryption

2020-11-12 Thread Eric Biggers
On Fri, Nov 13, 2020 at 11:43:48AM +0800, Lihong Kou wrote: > Now we have inline encrytion and fs layer encrption in the kernel, when we > choose inline encryption, we should not use bufferd IO instead of direct IO. > > Signed-off-by: Lihong Kou > --- > fs/f2fs/f2fs.h | 4 ++-- > 1 file changed,