Re: [f2fs-dev] [PATCH -next] f2fs: Replace kmalloc() with f2fs_kmalloc

2022-08-01 Thread Joe Perches
On Mon, 2022-08-01 at 11:23 -0700, Christoph Hellwig wrote: > On Mon, Aug 01, 2022 at 05:22:02PM +0800, studentxs...@163.com wrote: > > From: Xie Shaowen > > > > replace kmalloc with f2fs_kmalloc to keep f2fs code consistency. > > For that removing f2fs_kmalloc entirely would be way better.

Re: [f2fs-dev] [PATCH -next v2] f2fs: fix null-ptr-deref in f2fs_get_dnode_of_data

2022-08-01 Thread Jaegeuk Kim
On 08/01, Daeho Jeong wrote: > On Mon, Aug 1, 2022 at 4:15 AM Ye Bin via Linux-f2fs-devel > wrote: > > > > There is issue as follows when test f2fs atomic write: > > F2FS-fs (loop0): Can't find valid F2FS filesystem in 2th superblock > > F2FS-fs (loop0): invalid crc_offset: 0 > > F2FS-fs (loop0):

Re: [f2fs-dev] [PATCH -next v2] f2fs: fix null-ptr-deref in f2fs_get_dnode_of_data

2022-08-01 Thread Daeho Jeong
On Mon, Aug 1, 2022 at 4:15 AM Ye Bin via Linux-f2fs-devel wrote: > > There is issue as follows when test f2fs atomic write: > F2FS-fs (loop0): Can't find valid F2FS filesystem in 2th superblock > F2FS-fs (loop0): invalid crc_offset: 0 > F2FS-fs (loop0): f2fs_check_nid_range: out-of-range nid=1,

Re: [f2fs-dev] [PATCH -next] f2fs: Replace kmalloc() with f2fs_kmalloc

2022-08-01 Thread Christoph Hellwig
On Mon, Aug 01, 2022 at 05:22:02PM +0800, studentxs...@163.com wrote: > From: Xie Shaowen > > replace kmalloc with f2fs_kmalloc to keep f2fs code consistency. For that removing f2fs_kmalloc entirely would be way better. ___ Linux-f2fs-devel mailing

[f2fs-dev] [PATCH] f2fs: revive F2FS_IOC_ABORT_VOLATILE_WRITE

2022-08-01 Thread Daeho Jeong
From: Daeho Jeong F2FS_IOC_ABORT_VOLATILE_WRITE was used to abort a atomic write before. However it was removed accidentally. So revive it by changing the name, since volatile write had gone. Signed-off-by: Daeho Jeong Fiexes: 7bc155fec5b3("f2fs: kill volatile write support") ---

Re: [f2fs-dev] [PATCH -next v2] f2fs: fix null-ptr-deref in f2fs_get_dnode_of_data

2022-08-01 Thread Chao Yu
On 2022/8/1 19:26, Ye Bin wrote: There is issue as follows when test f2fs atomic write: F2FS-fs (loop0): Can't find valid F2FS filesystem in 2th superblock F2FS-fs (loop0): invalid crc_offset: 0 F2FS-fs (loop0): f2fs_check_nid_range: out-of-range nid=1, run fsck to fix. F2FS-fs (loop0):

[f2fs-dev] [PATCH] f2fs: fix null inode reference when FG GC for atomic file

2022-08-01 Thread Daeho Jeong
From: Daeho Jeong Fixed null inode reference when doing foreground GC for data segments of COW inodes. Below is a finding by Ye Bin . There is issue as follows when test f2fs atomic write: F2FS-fs (loop0): Can't find valid F2FS filesystem in 2th superblock F2FS-fs (loop0): invalid crc_offset:

[f2fs-dev] [PATCH -next v2] f2fs: fix null-ptr-deref in f2fs_get_dnode_of_data

2022-08-01 Thread Ye Bin via Linux-f2fs-devel
There is issue as follows when test f2fs atomic write: F2FS-fs (loop0): Can't find valid F2FS filesystem in 2th superblock F2FS-fs (loop0): invalid crc_offset: 0 F2FS-fs (loop0): f2fs_check_nid_range: out-of-range nid=1, run fsck to fix. F2FS-fs (loop0): f2fs_check_nid_range: out-of-range nid=2,

[f2fs-dev] [PATCH -next] f2fs: Replace kmalloc() with f2fs_kmalloc

2022-08-01 Thread studentxswpy
From: Xie Shaowen replace kmalloc with f2fs_kmalloc to keep f2fs code consistency. Reported-by: Hacash Robot Signed-off-by: Xie Shaowen --- fs/f2fs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index d5bd7932fb64..712b51f69c04 100644