Re: [f2fs-dev] [PATCH v4 0/5] Write-placement hints and FDP

On Tue, Sep 03, 2024 at 07:58:46PM GMT, Kanchan Joshi wrote: > Hi Amir, > > > On 8/26/2024 10:36 PM, Kanchan Joshi wrote: > > Current write-hint infrastructure supports 6 temperature-based data life > > hints. > > The series extends the infrastructure with a new temperature-agnostic > > placement

Re: [f2fs-dev] [PATCH] f2fs: fix to don't set SB_RDONLY in f2fs_handle_critical_error()

On Tue, Sep 10, 2024 at 11:07:13AM GMT, Chao Yu wrote: > syzbot reports a f2fs bug as below: > > [ cut here ] > WARNING: CPU: 1 PID: 58 at kernel/rcu/sync.c:177 rcu_sync_dtor+0xcd/0x180 > kernel/rcu/sync.c:177 > CPU: 1 UID: 0 PID: 58 Comm: kworker/1:2 Not tainted > 6.10.0

Re: [f2fs-dev] [PATCH] fs/writeback: convert wbc_account_cgroup_owner to take a folio

On Thu, 26 Sep 2024 16:01:21 +0200, Pankaj Raghav (Samsung) wrote: > Most of the callers of wbc_account_cgroup_owner() are converting a folio > to page before calling the function. wbc_account_cgroup_owner() is > converting the page back to a folio to call mem_cgroup_css_from_folio(). > > Convert

Re: [f2fs-dev] (subset) [PATCH v4 1/6] fs: enhance and rename shutdown() callback to remove_bdev()

On Fri, 04 Jul 2025 10:12:29 +0930, Qu Wenruo wrote: > Currently all the filesystems implementing the > super_opearations::shutdown() callback can not afford losing a device. > > Thus fs_bdev_mark_dead() will just call the shutdown() callback for the > involved filesystem. > > But it will no long

Re: [f2fs-dev] [PATCH v4 1/6] fs: enhance and rename shutdown() callback to remove_bdev()

On Mon, Jul 07, 2025 at 05:45:32PM -0700, Darrick J. Wong wrote: > On Tue, Jul 08, 2025 at 08:52:47AM +0930, Qu Wenruo wrote: > > > > > > 在 2025/7/8 08:32, Dave Chinner 写道: > > > On Fri, Jul 04, 2025 at 10:12:29AM +0930, Qu Wenruo wrote: > > > > Currently all the filesystems implementing the > >

Re: [f2fs-dev] [PATCH v4 1/6] fs: enhance and rename shutdown() callback to remove_bdev()

On Tue, Jul 08, 2025 at 01:20:50PM -0700, Darrick J. Wong wrote: > On Tue, Jul 08, 2025 at 12:20:00PM +0200, Jan Kara wrote: > > On Mon 07-07-25 17:45:32, Darrick J. Wong wrote: > > > On Tue, Jul 08, 2025 at 08:52:47AM +0930, Qu Wenruo wrote: > > > > 在 2025/7/8 08:32, Dave Chinner 写道: > > > > > On

Re: [f2fs-dev] [PATCH v4 1/6] fs: enhance and rename shutdown() callback to remove_bdev()

On Wed, Jul 09, 2025 at 08:59:42AM +1000, Dave Chinner wrote: > On Tue, Jul 08, 2025 at 09:55:14AM +0200, Christian Brauner wrote: > > On Mon, Jul 07, 2025 at 05:45:32PM -0700, Darrick J. Wong wrote: > > > On Tue, Jul 08, 2025 at 08:52:47AM +0930, Qu Wenruo wrote: > > > > > > > > > > > > 在 2025/7

Re: [f2fs-dev] [PATCH v4 1/6] fs: enhance and rename shutdown() callback to remove_bdev()

On Thu, Jul 10, 2025 at 07:24:46PM +0930, Qu Wenruo wrote: > > > 在 2025/7/10 18:10, Christian Brauner 写道: > > On Tue, Jul 08, 2025 at 01:20:50PM -0700, Darrick J. Wong wrote: > > > On Tue, Jul 08, 2025 at 12:20:00PM +0200, Jan Kara wrote: > > > > On Mon 07-07-25 17:45:32, Darrick J. Wong wrote: >

Re: [f2fs-dev] [PATCH v2 1/6] fs: enhance and rename shutdown() callback to remove_bdev()

On Tue, Jul 01, 2025 at 04:05:03PM +0930, Qu Wenruo wrote: > > > 在 2025/7/1 15:44, Christoph Hellwig 写道: > > On Tue, Jul 01, 2025 at 03:02:34PM +0930, Qu Wenruo wrote: > > > To allow those multi-device filesystems to be integrated to use > > > fs_holder_ops: > > > > > > - Rename shutdown() call

Re: [f2fs-dev] [PATCH 00/10] convert the majority of file systems to mmap_prepare

On Mon, Jun 16, 2025 at 04:11:11PM -0700, Andrew Morton wrote: > On Mon, 16 Jun 2025 20:33:19 +0100 Lorenzo Stoakes > wrote: > > > I am basing this on the mm-new branch in Andrew's tree, so let me know if I > > should rebase anything here. Given the mm bits touched I did think perhaps > > we sho

Re: [f2fs-dev] [PATCH 06/10] fs/xfs: transition from deprecated .mmap hook to .mmap_prepare

On Mon, Jun 16, 2025 at 10:08:03PM -0700, Christoph Hellwig wrote: > On Mon, Jun 16, 2025 at 08:33:25PM +0100, Lorenzo Stoakes wrote: > > STATIC int > > -xfs_file_mmap( > > - struct file *file, > > - struct vm_area_struct *vma) > > +xfs_file_mmap_prepare( > > + struct vm_area_d

Re: [f2fs-dev] [PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper

On Tue, Jun 17, 2025 at 12:08:13PM +0200, Jan Kara wrote: > On Tue 17-06-25 06:25:34, Lorenzo Stoakes wrote: > > On Mon, Jun 16, 2025 at 10:11:28PM -0700, Christoph Hellwig wrote: > > > On Mon, Jun 16, 2025 at 08:33:22PM +0100, Lorenzo Stoakes wrote: > > > > Since commit c84bf6dd2b83 ("mm: introduc

Re: [f2fs-dev] [PATCH 04/10] fs/dax: make it possible to check dev dax support without a VMA

On Mon, Jun 16, 2025 at 09:26:54PM +0100, Matthew Wilcox wrote: > On Mon, Jun 16, 2025 at 08:33:23PM +0100, Lorenzo Stoakes wrote: > > fs/ext4/file.c | 2 +- > > fs/xfs/xfs_file.c | 3 ++- > > Both of these already have the inode from the file ... > > > +static inline bool daxdev_mapping

Re: [f2fs-dev] [PATCH 09/10] fs: convert most other generic_file_*mmap() users to .mmap_prepare()

On Tue, Jun 17, 2025 at 12:23:41PM +0200, Jan Kara wrote: > On Mon 16-06-25 20:33:28, Lorenzo Stoakes wrote: > > Update nearly all generic_file_mmap() and generic_file_readonly_mmap() > > callers to use generic_file_mmap_prepare() and > > generic_file_readonly_mmap_prepare() respectively. > > > >

Re: [f2fs-dev] [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings

On Tue, Jun 17, 2025 at 12:28:17PM +0200, Jan Kara wrote: > On Mon 16-06-25 20:33:29, Lorenzo Stoakes wrote: > > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > > callback"), the f_op->mmap() hook has been deprecated in favour of > > f_op->mmap_prepare(). > > > > This callback

Re: [f2fs-dev] [PATCH 00/10] convert the majority of file systems to mmap_prepare

On Mon, 16 Jun 2025 20:33:19 +0100, Lorenzo Stoakes wrote: > REVIEWER'S NOTES > > > I am basing this on the mm-new branch in Andrew's tree, so let me know if I > should rebase anything here. Given the mm bits touched I did think perhaps > we should take it through the mm tree, how

Re: [f2fs-dev] [PATCH v5 00/13] Move fscrypt and fsverity info out of struct inode

On Sun, Aug 10, 2025 at 02:03:02AM -0700, Eric Biggers wrote: > On Sun, Aug 10, 2025 at 10:47:32AM +0200, Christian Brauner wrote: > > On Sun, Aug 10, 2025 at 12:56:53AM -0700, Eric Biggers wrote: > > > This is a cleaned-up implementation of moving the i_crypt_info and > > > i_verity_info pointers

Re: [f2fs-dev] [PATCH v5 00/13] Move fscrypt and fsverity info out of struct inode

On Mon, Aug 11, 2025 at 03:17:01PM +0200, Christian Brauner wrote: > On Sun, Aug 10, 2025 at 02:03:02AM -0700, Eric Biggers wrote: > > On Sun, Aug 10, 2025 at 10:47:32AM +0200, Christian Brauner wrote: > > > On Sun, Aug 10, 2025 at 12:56:53AM -0700, Eric Biggers wrote: > > > > This is a cleaned-up

Re: [f2fs-dev] [PATCH v5 00/13] Move fscrypt and fsverity info out of struct inode

> The fs-specific field solution from this patchset is much more efficient > than the rhashtable: efficient enough that we don't really have to worry > about it, regardless of fscrypt or fsverity. So I think it's a good > middle ground, and I'd like to just do it this way. I agree.

Re: [f2fs-dev] [PATCH v5 00/13] Move fscrypt and fsverity info out of struct inode

On Sun, Aug 10, 2025 at 12:56:53AM -0700, Eric Biggers wrote: > This is a cleaned-up implementation of moving the i_crypt_info and > i_verity_info pointers out of 'struct inode' and into the fs-specific > part of the inode, as proposed previously by Christian at > https://lore.kernel.org/r/20250723

Re: [f2fs-dev] [PATCH v5 00/13] Move fscrypt and fsverity info out of struct inode

On Mon, Aug 11, 2025 at 09:39:07AM -0700, Eric Biggers wrote: > On Mon, Aug 11, 2025 at 03:34:35PM +0200, Christian Brauner wrote: > > On Mon, Aug 11, 2025 at 03:17:01PM +0200, Christian Brauner wrote: > > > On Sun, Aug 10, 2025 at 02:03:02AM -0700, Eric Biggers wrote: > > > > On Sun, Aug 10, 2025