Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-22 Thread Michael Prokop
* Julien BLACHE jbla...@debian.org [Tue Sep 21, 2010 at 10:21:12PM +0200]: Michael Prokop m...@grml.org wrote: Mika, can this make it into a 3.4.3? Do you want a bug in the BTS? If Michael Tautschnig as setup-storage maintainer acknowledges the patch and either you or MT applies it to svn

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-21 Thread Julien BLACHE
Michael Prokop m...@grml.org wrote: Hi, Mika, can this make it into a 3.4.3? Do you want a bug in the BTS? If Michael Tautschnig as setup-storage maintainer acknowledges the patch and either you or MT applies it to svn so I can cherry-pick it I've just commited the fix to trunk, with a bit

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-18 Thread Julien BLACHE
Michael Tautschnig m...@debian.org wrote: Hi, Well, setup-storage development is really driven by use cases and feature requests these days, so unless someone explicitly requests that, it will not be supported, right. Yet it doesn't seem to hard to implement, IMHO just add a few commands

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Julien BLACHE
Michael Prokop m...@grml.org wrote: Hi, If Michael Tautschnig as setup-storage maintainer acknowledges the patch and either you or MT applies it to svn so I can cherry-pick it from there that's absolutely fine for me and I'd provide it as 3.4.3 release, sure. OK, let's wait for Michael's

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Julien BLACHE
Michael Tautschnig m...@debian.org wrote: Hi, absolutely fine if the fix goes in via this patch). Just one stylistic note: Unless I'm missing something, the following if ... elsif ... -if (FAI::set_partition_type_on_phys_dev($d, raid)) { +if ($vol-{preserve}) { +

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Michael Tautschnig
Hi Julien, Michael Tautschnig m...@debian.org wrote: Hi, absolutely fine if the fix goes in via this patch). Just one stylistic note: Unless I'm missing something, the following if ... elsif ... -if (FAI::set_partition_type_on_phys_dev($d, raid)) { + if ($vol-{preserve})

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Julien BLACHE
Michael Tautschnig m...@debian.org wrote: Hi, Though pt_complete is only for physical devices, so all things considered I should have a second look at this. I'll do this on monday. Ouch, yes, you're absolutely right. I think the following code should do it: if ($vol-{preserve}) {

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-16 Thread Michael Prokop
* Julien BLACHE jbla...@debian.org [Thu Sep 16, 2010 at 05:41:37PM +0200]: Preserving a RAID volume doesn't work in 3.4.x: - mdadm --detail --scan doesn't give information on non-assembled arrays, leading setup-storage to think there aren't any; - preserved arrays must be assembled