Re: ext3 writepages ?

2005-02-03 Thread Sonny Rao
On Thu, Feb 03, 2005 at 07:51:37AM -0800, Badari Pulavarty wrote: > On Wed, 2005-02-02 at 12:19, Sonny Rao wrote: > > On Wed, Feb 02, 2005 at 07:32:04AM -0800, Badari Pulavarty wrote: > > > Hi, > > > > > > I forgot the reason why we don't have ext3_writepages() ? > > > I can dig through to find ou

Re: RFC: [PATCH-2.6] Add helper function to lock multiple page cache pages - nopage alternative

2005-02-03 Thread Bryan Henderson
>> > > And for the vmscan->writepage() side of things I wonder if it would be >> > > possible to overload the mapping's ->nopage handler. If the target page >> > > lies in a hole, go off and allocate all the necessary pagecache pages, zero >> > > them, mark them dirty? >> > >> > I guess it wou

Re: RFC: [PATCH-2.6] Add helper function to lock multiple page cache pages - loop device

2005-02-03 Thread Bryan Henderson
>I did a patch which switched loop to use the file_operations.read/write >about a year ago. Forget what happened to it. It always seemed the right >thing to do.. This is unquestionably the right thing to do (at least compared to what we have now). The loop device driver has no business assumi

Re: mpage writepage question

2005-02-03 Thread Andrew Morton
Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > Hi Andrew, > > I was wondering why mpage_writepage() is only "static" ? Good question. > Is the expectation that, filesystems use > > .writepage == block_full_write_page > .writepages == mpage_writepages > > ? I am little confused on

Re: NFSD needs EXPORTFS

2005-02-03 Thread Joel Soete
... > > If the problem occured with CONFIG_XFS_FS=m I understand what went > wrong. > Yes, it was > It seems to be correct. > > This was a side effect of Roman's fix for the XFS <-> EXPORTFS > dependency. > Thanks a lot, Joel - To unsubscribe from this list: send the line "unsubscribe

Re: NFSD needs EXPORTFS

2005-02-03 Thread Adrian Bunk
On Thu, Feb 03, 2005 at 05:01:11PM +, Matthew Wilcox wrote: > > Got this report about 2.6.11-rc3. Is this the correct solution? > > - Forwarded message from Joel Soete <[EMAIL PROTECTED]> - > > A short analyse, it seems that's because NFSD was builtin while EXPORTFS > was a module i

Re: ext3 writepages ?

2005-02-03 Thread Sonny Rao
On Thu, Feb 03, 2005 at 08:56:50AM -0800, Badari Pulavarty wrote: > On Thu, 2005-02-03 at 09:00, Sonny Rao wrote: > > > > > Well it seems to work, here's my (rather ugly) patch. > > I'm doing some performance comparisons now. > > > > Sonny > > Interesting.. Why did you create a nobh_prepare_wri

Re: ext3 writepages ?

2005-02-03 Thread Badari Pulavarty
On Thu, 2005-02-03 at 09:00, Sonny Rao wrote: > > Well it seems to work, here's my (rather ugly) patch. > I'm doing some performance comparisons now. > > Sonny Interesting.. Why did you create a nobh_prepare_write() ? mpage_writepages() can handle pages with buffer heads attached. And also, a

Re: mpage writepage question

2005-02-03 Thread Sonny Rao
On Thu, Feb 03, 2005 at 08:37:19AM -0800, Badari Pulavarty wrote: > Hi Andrew, > > I was wondering why mpage_writepage() is only "static" ? > > Is the expectation that, filesystems use > > .writepage == block_full_write_page > .writepages == mpage_writepages > > ? I am little confu

mpage writepage question

2005-02-03 Thread Badari Pulavarty
Hi Andrew, I was wondering why mpage_writepage() is only "static" ? Is the expectation that, filesystems use .writepage == block_full_write_page .writepages == mpage_writepages ? I am little confused on why we have 2 different ways to do things ? block_full_write_page() seems t

Re: ext3 writepages ?

2005-02-03 Thread Sonny Rao
On Thu, Feb 03, 2005 at 07:51:37AM -0800, Badari Pulavarty wrote: > On Wed, 2005-02-02 at 12:19, Sonny Rao wrote: > > On Wed, Feb 02, 2005 at 07:32:04AM -0800, Badari Pulavarty wrote: > > > Hi, > > > > > > I forgot the reason why we don't have ext3_writepages() ? > > > I can dig through to find ou

NFSD needs EXPORTFS

2005-02-03 Thread Matthew Wilcox
Got this report about 2.6.11-rc3. Is this the correct solution? - Forwarded message from Joel Soete <[EMAIL PROTECTED]> - A short analyse, it seems that's because NFSD was builtin while EXPORTFS was a module in my previous config file. Imho EXPORTFS would be build as NFSD? Is the follo

Re: ext3 writepages ?

2005-02-03 Thread Badari Pulavarty
On Wed, 2005-02-02 at 12:19, Sonny Rao wrote: > On Wed, Feb 02, 2005 at 07:32:04AM -0800, Badari Pulavarty wrote: > > Hi, > > > > I forgot the reason why we don't have ext3_writepages() ? > > I can dig through to find out, but it would be easy to ask > > people. > > > > Please let me know. > > B

Re: RFC: [PATCH-2.6] Add helper function to lock multiple page cache pages.

2005-02-03 Thread Anton Altaparmakov
On Thu, 2005-02-03 at 02:47 -0800, Andrew Morton wrote: > Anton Altaparmakov <[EMAIL PROTECTED]> wrote: > > On Wed, 2005-02-02 at 14:34 -0800, Andrew Morton wrote: > > > Anton Altaparmakov <[EMAIL PROTECTED]> wrote: > > > > > > > > Below is a patch which adds a function > > > > mm/filemap.c::find

Re: RFC: [PATCH-2.6] Add helper function to lock multiple page cache pages.

2005-02-03 Thread Andrew Morton
Anton Altaparmakov <[EMAIL PROTECTED]> wrote: > > On Wed, 2005-02-02 at 14:34 -0800, Andrew Morton wrote: > > Anton Altaparmakov <[EMAIL PROTECTED]> wrote: > > > > > > Below is a patch which adds a function > > > mm/filemap.c::find_or_create_pages(), locks a range of pages. Please > > > see >

Re: RFC: [PATCH-2.6] Add helper function to lock multiple page cache pages.

2005-02-03 Thread Anton Altaparmakov
On Wed, 2005-02-02 at 14:34 -0800, Andrew Morton wrote: > Anton Altaparmakov <[EMAIL PROTECTED]> wrote: > > > > Below is a patch which adds a function > > mm/filemap.c::find_or_create_pages(), locks a range of pages. Please see > > the function description in the patch for details. > > This i