[PATCH 2.6.13-rc2-mm2] v9fs: fix problems spotted in previous patchset (2.0.2)

2005-07-14 Thread ericvh
Fix formating errors and a memory leak that crept in the previous round of revisions to v9fs. These will be reincorperated into the patchset and resent to akpm. Signed-off-by: Eric Van Hensbergen <[EMAIL PROTECTED]> --- commit 22d785a22895513c6ab67dfa53c25b8b833fe235 tree 88822e96e339bf071d6357

Re: [RFC][PATCH] Remove security_inode_post_create/mkdir/symlink/mknod hooks

2005-07-14 Thread Stephen Smalley
On Thu, 2005-07-14 at 12:41 -0700, Chris Wright wrote: > * Stephen Smalley ([EMAIL PROTECTED]) wrote: > > This patch removes the inode_post_create/mkdir/mknod/symlink LSM hooks > > as they are obsoleted by the new inode_init_security hook that enables > > atomic inode security labeling. If anyone

Re: [PATCH 2.6.13-rc2-mm2 5/7] v9fs: 9P protocol implementation (2.0.2)

2005-07-14 Thread Eric Van Hensbergen
On 7/14/05, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > +static inline void buf_check_size(struct cbuf *buf, int len) > > +{ > > + if (buf->p+len > buf->ep) { > > + if (buf->p < buf->ep) { > > + eprintk(KERN_ERR, "buffer overflow\n"); > > +

Re: [PATCH 2.6.13-rc2-mm2 2/7] v9fs: VFS file, dentry, and directory operations (2.0.2)

2005-07-14 Thread Eric Van Hensbergen
Doh! Good catch, I'll fix and resubmit - same goes for the formating issues. On 7/14/05, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > @@ -383,9 +379,10 @@ v9fs_file_write(struct file *filp, const > > return -ENOMEM; > > > > ret = copy_from_user(buffer, data, count); > > -

Re: [PATCH 2.6.13-rc2-mm2 2/7] v9fs: VFS file, dentry, and directory operations (2.0.2)

2005-07-14 Thread Christoph Hellwig
> @@ -383,9 +379,10 @@ v9fs_file_write(struct file *filp, const > return -ENOMEM; > > ret = copy_from_user(buffer, data, count); > - if (ret) > + if (ret) { > dprintk(DEBUG_ERROR, "Problem copying from user\n"); > - else > + return -EFAULT

Re: [PATCH 2.6.13-rc2-mm2 7/7] v9fs: debug and support routines (2.0.2)

2005-07-14 Thread Christoph Hellwig
On Sun, Jul 17, 2005 at 08:53:59AM -0500, [EMAIL PROTECTED] wrote: > This is part [7/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2. > > This part of the patch contains debug and other misc routine changes related > to hch's comments. Here a few if( instead if ( formatting sneaked in. -

Re: [PATCH 2.6.13-rc2-mm2 5/7] v9fs: 9P protocol implementation (2.0.2)

2005-07-14 Thread Christoph Hellwig
> +static inline void buf_check_size(struct cbuf *buf, int len) > +{ > + if (buf->p+len > buf->ep) { > + if (buf->p < buf->ep) { > + eprintk(KERN_ERR, "buffer overflow\n"); > + buf->p = buf->ep + 1; > + } > + } > +} "ha

Re: [RFC][PATCH] Remove security_inode_post_create/mkdir/symlink/mknod hooks

2005-07-14 Thread Chris Wright
* Stephen Smalley ([EMAIL PROTECTED]) wrote: > This patch removes the inode_post_create/mkdir/mknod/symlink LSM hooks > as they are obsoleted by the new inode_init_security hook that enables > atomic inode security labeling. If anyone sees any reason to retain these > hooks, > please speak now.

[RFC][PATCH] Remove security_inode_post_create/mkdir/symlink/mknod hooks

2005-07-14 Thread Stephen Smalley
This patch removes the inode_post_create/mkdir/mknod/symlink LSM hooks as they are obsoleted by the new inode_init_security hook that enables atomic inode security labeling. If anyone sees any reason to retain these hooks, please speak now. Also, is anyone using the post_rename/link hooks; if no

[PATCH 2.6.13-rc2-mm2 6/7] v9fs: transport modules (2.0.2)

2005-07-14 Thread ericvh
This is part [6/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2. This part of the patch contains transport routine changes related to hch's comments. Signed-off-by: Eric Van Hensbergen <[EMAIL PROTECTED]> -- fs/9p/trans_sock.c |2 +- fs/9p/mux.c | 44

[PATCH 2.6.13-rc2-mm2 3/7] v9fs: VFS inode operations (2.0.2)

2005-07-14 Thread ericvh
This is part [3/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2. This part of the patch contains the VFS inode interfaces changes related to hch's comments. Signed-off-by: Eric Van Hensbergen <[EMAIL PROTECTED]> -- fs/9p/vfs_inode.c | 69 +-

[PATCH 2.6.13-rc2-mm2 2/7] v9fs: VFS file, dentry, and directory operations (2.0.2)

2005-07-14 Thread ericvh
This is part [2/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2 This part of the patch contains the VFS file, dentry, & directory interface changes related to hch's comments. Signed-off-by: Eric Van Hensbergen <[EMAIL PROTECTED]> -- fs/9p/vfs_file.c | 35 +++--

[PATCH 2.6.13-rc2-mm2 1/7] v9fs: Documentation, Makefiles, Configuration (2.0.2)

2005-07-14 Thread ericvh
This is part [1/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2 This part of the patch contains Documentation, Makefiles, and configuration file changes related to hch's comments. Signed-off-by: Eric Van Hensbergen <[EMAIL PROTECTED]> -- fs/9p/Makefile |1 - 1 files chan

[PATCH 2.6.13-rc2-mm2 7/7] v9fs: debug and support routines (2.0.2)

2005-07-14 Thread ericvh
This is part [7/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2. This part of the patch contains debug and other misc routine changes related to hch's comments. Signed-off-by: Eric Van Hensbergen <[EMAIL PROTECTED]> -- fs/9p/error.c|3 +-- fs/9p/error.h|3 +++

[PATCH 2.6.13-rc2-mm2 4/7] v9fs: VFS superblock operations and glue (2.0.2)

2005-07-14 Thread ericvh
This is part [4/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2. This part of the patch contains VFS superblock and mapping code changes related to hch's comments. Signed-off-by: Eric Van Hensbergen <[EMAIL PROTECTED]> -- v9fs.c | 103 +--

[PATCH 2.6.13-rc2-mm2 0/7] v9fs: Changes in response to hch comments (2.0.2)

2005-07-14 Thread ericvh
This is part [0/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2. The changes in this patch-set are primarily motivated by comments from Chistoph Hellwig (hch): "there's a few issues with the code still I'd like to see fixed: - there's three sparse warnings still. Two of them are easily

[PATCH 2.6.13-rc2-mm2 5/7] v9fs: 9P protocol implementation (2.0.2)

2005-07-14 Thread ericvh
This is part [5/7] of the v9fs-2.0.2 patch against Linux 2.6.13-rc2-mm2. This part of the patch contains the 9P protocol function changes related to hch's comments. Signed-off-by: Eric Van Hensbergen <[EMAIL PROTECTED]> -- fs/9p/9p.c |2 +- fs/9p/conv.c| 54 +++

Re: [RFC][PATCH 0/2] JFS atomic inode security labeling

2005-07-14 Thread Dave Kleikamp
Andrew, I'll push these to you via git after any feedback. On Thu, 2005-07-14 at 11:16 -0500, Dave Kleikamp wrote: > Here's the jfs implementation. The first patch fixes the transaction > layering in the xattr code to allow xattrs to be added to an inode as a > part of an existing transaction, an

[RFC][PATCH 2/2] JFS atomic inode security labeling

2005-07-14 Thread Dave Kleikamp
Implement jfs_init_security() diff -Nurp linux-1/fs/jfs/jfs_xattr.h linux/fs/jfs/jfs_xattr.h --- linux-1/fs/jfs/jfs_xattr.h 2005-07-13 16:59:04.0 -0500 +++ linux/fs/jfs/jfs_xattr.h2005-07-14 10:27:23.0 -0500 @@ -61,4 +61,14 @@ extern ssize_t jfs_getxattr(struct dentr extern s

[RFC][PATCH 1/2] JFS atomic xattr/acl handling

2005-07-14 Thread Dave Kleikamp
__jfs_setxattr should allow extended attributes to be set within an existing transaction diff -urp linux-2.6.13-rc3/fs/jfs/acl.c linux-1/fs/jfs/acl.c --- linux-2.6.13-rc3/fs/jfs/acl.c 2005-07-13 10:03:40.0 -0500 +++ linux-1/fs/jfs/acl.c2005-07-14 09:19:50.0 -0500 @@ -

[RFC][PATCH 0/2] JFS atomic inode security labeling

2005-07-14 Thread Dave Kleikamp
Here's the jfs implementation. The first patch fixes the transaction layering in the xattr code to allow xattrs to be added to an inode as a part of an existing transaction, and correctly calls jfs_init_acl() within the same transaction that creates a file/directory/device. The second patch actua

Re: XFS corruption on move from xscale to i686

2005-07-14 Thread Christoph Hellwig
On Thu, Jul 14, 2005 at 05:45:15PM +0300, Yura Pakhuchiy wrote: > Yes, but a lof of people use older versions of compilers and suffer > from this bug. > I personally was very unhappy when lost my data. then host the patch somewhere and make sure to apply it. - To unsubscribe from this list: send

Re: XFS corruption on move from xscale to i686

2005-07-14 Thread Yura Pakhuchiy
2005/7/14, Christoph Hellwig <[EMAIL PROTECTED]>: > On Thu, Jul 14, 2005 at 04:50:01PM +0300, Yura Pakhuchiy wrote: > > 2005/7/14, Nathan Scott <[EMAIL PROTECTED]>: > > > On Wed, Jul 13, 2005 at 06:22:28PM +0300, Yura Pakhuchiy wrote: > > > > I found patch by Greg Ungreger to fix this problem, but

Re: XFS corruption on move from xscale to i686

2005-07-14 Thread Christoph Hellwig
On Thu, Jul 14, 2005 at 04:50:01PM +0300, Yura Pakhuchiy wrote: > 2005/7/14, Nathan Scott <[EMAIL PROTECTED]>: > > On Wed, Jul 13, 2005 at 06:22:28PM +0300, Yura Pakhuchiy wrote: > > > I found patch by Greg Ungreger to fix this problem, but why it's still > > > not in mainline? Or it's a gcc proble

Re: XFS corruption on move from xscale to i686

2005-07-14 Thread Yura Pakhuchiy
2005/7/14, Nathan Scott <[EMAIL PROTECTED]>: > On Wed, Jul 13, 2005 at 06:22:28PM +0300, Yura Pakhuchiy wrote: > > I found patch by Greg Ungreger to fix this problem, but why it's still > > not in mainline? Or it's a gcc problem and should be fixed by gcc folks? > > Yes, IIRC the patch was incorre