Re: [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging

2007-01-17 Thread Josef Sipek
On Wed, Jan 17, 2007 at 04:55:49PM -0600, Dave Kleikamp wrote: ... > diff -Nurp linux-2.6.20-rc4-mm1/fs/jfs/jfs_lock.h linux/fs/jfs/jfs_lock.h > --- linux-2.6.20-rc4-mm1/fs/jfs/jfs_lock.h2006-11-29 15:57:37.0 > -0600 > +++ linux/fs/jfs/jfs_lock.h 2007-01-17 15:30:19.0 -0600 >

Re: [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging

2007-01-17 Thread Dave Kleikamp
On Thu, 2007-01-18 at 10:46 +1100, Jens Axboe wrote: > On Wed, Jan 17 2007, Dave Kleikamp wrote: > > On Thu, 2007-01-18 at 10:18 +1100, Jens Axboe wrote: > > > > > Can you try io_schedule() and verify that things just work? > > > > I actually did do that in the first place, but wondered if it was t

Re: [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging

2007-01-17 Thread Jens Axboe
On Wed, Jan 17 2007, Dave Kleikamp wrote: > Jens, > Can you please take a look at this patch, and if you think it's sane, > add it to your explicit i/o plugging patchset? Would it make sense in > any of these paths to use io_schedule() instead of schedule()? I'm glad you bring that up, actually.

Re: [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging

2007-01-17 Thread Jens Axboe
On Wed, Jan 17 2007, Dave Kleikamp wrote: > On Thu, 2007-01-18 at 10:18 +1100, Jens Axboe wrote: > > > Can you try io_schedule() and verify that things just work? > > I actually did do that in the first place, but wondered if it was the > right thing to introduce the accounting changes that came

Re: [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging

2007-01-17 Thread Dave Kleikamp
On Thu, 2007-01-18 at 10:18 +1100, Jens Axboe wrote: > Can you try io_schedule() and verify that things just work? I actually did do that in the first place, but wondered if it was the right thing to introduce the accounting changes that came with that. I'll change it back to io_schedule() and te

Re: [PATCH -mm 0/10][RFC] aio: make struct kiocb private

2007-01-17 Thread Nate Diller
On Wed, 17 Jan 2007, Benjamin LaHaise wrote: On Mon, Jan 15, 2007 at 08:25:15PM -0800, Nate Diller wrote: the right thing to do from a design perspective. Hopefully it enables a new architecture that can reduce context switches in I/O completion, and reduce overhead. That's the real motive ;)

[PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging

2007-01-17 Thread Dave Kleikamp
Jens, Can you please take a look at this patch, and if you think it's sane, add it to your explicit i/o plugging patchset? Would it make sense in any of these paths to use io_schedule() instead of schedule()? I hadn't looked at your patchset until I discovered that jfs was easy to hang in the -mm

Re: [PATCH -mm 0/10][RFC] aio: make struct kiocb private

2007-01-17 Thread Benjamin LaHaise
On Mon, Jan 15, 2007 at 08:25:15PM -0800, Nate Diller wrote: > the right thing to do from a design perspective. Hopefully it enables > a new architecture that can reduce context switches in I/O completion, > and reduce overhead. That's the real motive ;) And it's a broken motive. Context switch

Unpatched secunia advisories

2007-01-17 Thread Majkls
Hello, some time ago I sent some open advisory there, but in fact it had been already fixed. So I want to continue in this chase on open advisories and closed bugs. So there is some from FS: CVE-2006-2629 - Race condition in Linux kernel 2.6.15 to 2.6.17, when running on SMP platforms, allows loca

Re: [take33 10/10] kevent: Kevent based AIO (aio_sendfile()/aio_sendfile_path()).

2007-01-17 Thread Evgeniy Polyakov
On Wed, Jan 17, 2007 at 07:21:42PM +0530, Suparna Bhattacharya ([EMAIL PROTECTED]) wrote: > > Since you are implementing new APIs here, have you considered doing an > aio_sendfilev to be able to send a header with the data ? It is doable, but why people do not like corking? With Linux less than

Re: [take33 10/10] kevent: Kevent based AIO (aio_sendfile()/aio_sendfile_path()).

2007-01-17 Thread Suparna Bhattacharya
Since you are implementing new APIs here, have you considered doing an aio_sendfilev to be able to send a header with the data ? Regards Suparna On Wed, Jan 17, 2007 at 09:30:35AM +0300, Evgeniy Polyakov wrote: > > Kevent based AIO (aio_sendfile()/aio_sendfile_path()). > > aio_sendfile()/aio_s

Re: [RFC][PATCH 0/3] ext4 online defrag (ver 0.2)

2007-01-17 Thread Takashi Sato
Hi, On Jan 16, 2007 21:03 +0900, [EMAIL PROTECTED] wrote: 1. Add new ioctl(EXT4_IOC_DEFRAG) which returns the first physical block number of the specified file. With this ioctl, a command gets the specified directory's. Maybe I don't understand, but how is this different from the long