Re: asynchronous locks for cluster exports

2007-02-03 Thread Christoph Hellwig
On Sat, Feb 03, 2007 at 12:30:55AM -0500, J. Bruce Fields wrote: The gfs2 implementation in the last patch is (unfortunately) still just a rough draft that needs some more thought and some testing. So what exactly in this patch is tested? - To unsubscribe from this list: send the line

Re: [PATCH 3/14] locks: factor out generic/filesystem switch from setlock code

2007-02-03 Thread Christoph Hellwig
On Sat, Feb 03, 2007 at 12:33:59AM -0500, J. Bruce Fields wrote: + */ +int vfs_lock_file(struct file *filp, unsigned int cmd, struct file_lock *fl) +{ + if (filp-f_op filp-f_op-lock) + return filp-f_op-lock(filp, cmd, fl); + else + return

Re: [patch 0/9] buffered write deadlock fix

2007-02-03 Thread Fengguang Wu
On Fri, Feb 02, 2007 at 03:52:32PM -0800, Andrew Morton wrote: Bugfixes come first, so I will drop readahead and fsaio and git-block to get this work completed if needed - please work agaisnt mainline. OK with readahead. There are too much fixes in the series. I'd like to fold them up and

Re: [patch 1/9] fs: libfs buffered write leak fix

2007-02-03 Thread Jörn Engel
On Sat, 3 February 2007 02:33:16 +0100, Nick Piggin wrote: If doing a partial-write, simply clear the whole page and set it uptodate (don't need to get too tricky). That sounds just like a bug I recently fixed in logfs. prepare_write() would clear the page, commit_write() would write the

Re: [NFS] [PATCH 9/14] lockd: handle fl_notify callbacks

2007-02-03 Thread Trond Myklebust
On Sat, 2007-02-03 at 00:34 -0500, J. Bruce Fields wrote: From: Marc Eshel [EMAIL PROTECTED] - unquoted Add code to handle file system callback when the lock is finally granted. Signed-off-by: Marc Eshel [EMAIL PROTECTED] Signed-off-by: J. Bruce Fields [EMAIL PROTECTED] ---

Re: asynchronous locks for cluster exports

2007-02-03 Thread J. Bruce Fields
On Sat, Feb 03, 2007 at 08:39:29AM +, Christoph Hellwig wrote: On Sat, Feb 03, 2007 at 12:30:55AM -0500, J. Bruce Fields wrote: The gfs2 implementation in the last patch is (unfortunately) still just a rough draft that needs some more thought and some testing. So what exactly in this

Re: [PATCH 2/14] locks: factor out generic/filesystem switch from test_lock

2007-02-03 Thread J. Bruce Fields
On Sat, Feb 03, 2007 at 08:50:25AM +, Christoph Hellwig wrote: +int vfs_test_lock(struct file *filp, struct file_lock *fl, struct file_lock *conf) Please make sure to add linebreaks after at most 80 characters. OK, done. + error = vfs_test_lock(filp, file_lock, cfl); + if

Re: [NFS] [PATCH 2/14] locks: factor out generic/filesystem switch from test_lock

2007-02-03 Thread J. Bruce Fields
On Sat, Feb 03, 2007 at 04:32:05PM -0800, Trond Myklebust wrote: On Sat, 2007-02-03 at 00:33 -0500, J. Bruce Fields wrote: From: J. Bruce Fields [EMAIL PROTECTED] - unquoted +int vfs_test_lock(struct file *filp, struct file_lock *fl, struct file_lock *conf) +{ + int error; + +

Re: [PATCH 4/14] locks: add locking function that returns conflicting lock

2007-02-03 Thread J. Bruce Fields
On Sat, Feb 03, 2007 at 08:54:50AM +, Christoph Hellwig wrote: Is there any reason we want to have both variants? I think vfs_lock_file should simple get the last argument and we shouldn't have a separate vfs_lock_file_conf (which btw doesn't have an exactly descriptive name). The also

Re: [NFS] [PATCH 9/14] lockd: handle fl_notify callbacks

2007-02-03 Thread J. Bruce Fields
On Sat, Feb 03, 2007 at 04:40:05PM -0800, Trond Myklebust wrote: On Sat, 2007-02-03 at 00:34 -0500, J. Bruce Fields wrote: nlmsvc_notify_blocked(struct file_lock *fl, struct file_lock *conf, int result) { struct nlm_block*block; + int rc = -ENOENT;

Re: [patch 1/9] fs: libfs buffered write leak fix

2007-02-03 Thread Nick Piggin
On Sat, Feb 03, 2007 at 05:49:47PM +, Jörn Engel wrote: On Sat, 3 February 2007 02:33:16 +0100, Nick Piggin wrote: If doing a partial-write, simply clear the whole page and set it uptodate (don't need to get too tricky). That sounds just like a bug I recently fixed in logfs.