Re: [PATCH] Fix d_path for lazy unmounts

2007-02-14 Thread Andreas Gruenbacher
On Monday 05 February 2007 00:32, Andreas Gruenbacher wrote: Here is an updated patch that also catches this special case. [...] The d_path change was to not start unreachable paths with slashes. In the extreme case, this leads to an empty string. As it turns out, we are reporting meaningless

Re: [PATCH] Fix d_path for lazy unmounts

2007-02-14 Thread Olaf Hering
On Wed, Feb 14, Andreas Gruenbacher wrote: What's the point in reporting the rootfs at all -- it's never reachable to an ordinary process? /init and its childs has it as root, until it passes control over to /sbin/init - To unsubscribe from this list: send the line unsubscribe linux-fsdevel

Re: [PATCH] Fix d_path for lazy unmounts

2007-02-14 Thread Andreas Gruenbacher
On Wednesday 14 February 2007 00:29, Olaf Hering wrote: On Wed, Feb 14, Andreas Gruenbacher wrote: What's the point in reporting the rootfs at all -- it's never reachable to an ordinary process? /init and its childs has it as root, until it passes control over to /sbin/init Yes, that's

Re: [PATCH] Fix d_path for lazy unmounts

2007-02-14 Thread Linus Torvalds
On Wed, 14 Feb 2007, Andreas Gruenbacher wrote: Mountpoints are reported relative to the chroot if they are reachable from the chroot, and relative to the namespace they are defined in otherwise. This is big nonsense, but it's unclear to me how to best fix it: Well, it's also what a

Fix(es) for ext2 fsync bug

2007-02-14 Thread Valerie Henson
Just some quick notes on possible ways to fix the ext2 fsync bug that eXplode found. Whether or not anyone will bother to implement it is another matter. Background: The eXplode file system checker found a bug in ext2 fsync behavior. Do the following: truncate file A, create file B which

Re: Fix(es) for ext2 fsync bug

2007-02-14 Thread David Chinner
On Wed, Feb 14, 2007 at 11:54:54AM -0800, Valerie Henson wrote: Just some quick notes on possible ways to fix the ext2 fsync bug that eXplode found. Whether or not anyone will bother to implement it is another matter. Background: The eXplode file system checker found a bug in ext2 fsync

Re: Fix(es) for ext2 fsync bug

2007-02-14 Thread Dave Kleikamp
On Thu, 2007-02-15 at 07:31 +1100, David Chinner wrote: On Wed, Feb 14, 2007 at 11:54:54AM -0800, Valerie Henson wrote: Just some quick notes on possible ways to fix the ext2 fsync bug that eXplode found. Whether or not anyone will bother to implement it is another matter. Background:

Re: Fix(es) for ext2 fsync bug

2007-02-14 Thread David Chinner
On Wed, Feb 14, 2007 at 03:26:22PM -0600, Dave Kleikamp wrote: On Thu, 2007-02-15 at 07:31 +1100, David Chinner wrote: On Wed, Feb 14, 2007 at 11:54:54AM -0800, Valerie Henson wrote: Just some quick notes on possible ways to fix the ext2 fsync bug that eXplode found. Whether or not

Re: [PATCH] Fix d_path for lazy unmounts

2007-02-14 Thread Andreas Gruenbacher
On Wednesday 14 February 2007 07:37, Linus Torvalds wrote: We could prepend another '/' (so that you'd have a path that starts with //). That's still a legal path, but it's also somethign that even POSIX says is valid to mean something else (eg //ftp/.. or //socket/.. to escape into another

Re: Fix(es) for ext2 fsync bug

2007-02-14 Thread sfaibish
Val, Maybe it is not only our (FS people) problem. We probably need to bring the kernel people judge as ext2 and ext3 are the base Linux FS. I add the kernel list for opinion. /Sorin On Wed, 14 Feb 2007 14:54:54 -0500, Valerie Henson [EMAIL PROTECTED] wrote: Just some quick notes on

Re: [PATCH] Fix d_path for lazy unmounts

2007-02-14 Thread Andreas Gruenbacher
On Wednesday 14 February 2007 11:39, Andreas Gruenbacher wrote: On Wednesday 14 February 2007 07:37, Linus Torvalds wrote: We could prepend another '/' (so that you'd have a path that starts with //). That's still a legal path, but it's also somethign that even POSIX says is valid to mean

Re: [PATCH] Fix d_path for lazy unmounts

2007-02-14 Thread Andreas Gruenbacher
On Sunday 04 February 2007 16:15, Neil Brown wrote: The behaviour in the face of a lazy unmount should be clarified in this comment. Done. If sys_getcwd is called on a directory that is no longer connected to the root, it isn't clear to me that it should return without an error. Without

Re: [PATCH] Fix d_path for lazy unmounts

2007-02-14 Thread Andreas Gruenbacher
On Wednesday 14 February 2007 14:57, Andreas Gruenbacher wrote: [1] Always make disconnected paths relative: From all these choices, I actually like [1] best, together with hiding unreachable mount points in /proc/$pid/mounts and /proc/$pid/mountstats: there is no real point in pretending