Re: [patch 3/8] per backing_dev dirty and writeback page accounting

2007-03-11 Thread David Chinner
On Tue, Mar 06, 2007 at 07:04:46PM +0100, Miklos Szeredi wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > > [EMAIL PROTECTED]: bugfix] > > Miklos Szeredi <[EMAIL PROTECTED]>: > > Changes: > - updated to apply after clear_page_dirty_for_io() race fix > > This is needed for > > - balance_dir

Re: impact of 4k sector size on the IO & FS stack

2007-03-11 Thread Andreas Dilger
On Mar 12, 2007 04:27 +0100, Jan Engelhardt wrote: > Assume this partition table on my current HD: > > Disk /dev/hdc: 251.0 GB, 251000193024 bytes > 255 heads, 63 sectors/track, 30515 cylinders > Units = cylinders of 16065 * 512 = 8225280 bytes > > Device Start

Re: impact of 4k sector size on the IO & FS stack

2007-03-11 Thread Jan Engelhardt
On Mar 11 2007 22:45, Ric Wheeler wrote: > Jan Engelhardt wrote: >> On Mar 11 2007 18:51, Ric Wheeler wrote: >> >> > During the recent IO/FS workshop, we spoke briefly about the >> > coming change to a 4k sector size for disks on linux. If I >> > recall correctly, the general feeling was that the

Re: impact of 4k sector size on the IO & FS stack

2007-03-11 Thread Ric Wheeler
Jan Engelhardt wrote: On Mar 11 2007 18:51, Ric Wheeler wrote: During the recent IO/FS workshop, we spoke briefly about the coming change to a 4k sector size for disks on linux. If I recall correctly, the general feeling was that the impact was not significant since we already do most file

Re: impact of 4k sector size on the IO & FS stack

2007-03-11 Thread Ric Wheeler
Alan Cox wrote: Are there other concerns in the IO or FS stack that we should bring up with vendors? I have been asked to summarize the impact of 4k sectors on linux for a disk vendor gathering and want to make sure that I put all of our linux specific items into that summary... We ne

Re: impact of 4k sector size on the IO & FS stack

2007-03-11 Thread Ric Wheeler
Jeff Garzik wrote: Alan Cox wrote: I would be interested to know what the disk vendors intend to use as their strategy when (with ATA) they have a 512 byte write from an older file system/setup into a 4K block. The case where errors magically appear Well, you have logical and physical secto

Re: [patch 2/3] fs: introduce perform_write aop

2007-03-11 Thread Mark Fasheh
On Sat, Mar 10, 2007 at 09:25:41AM +, Christoph Hellwig wrote: > On Fri, Mar 09, 2007 at 03:33:01PM -0800, Mark Fasheh wrote: > > ->kernel_write() as opposed to genericizing ->perform_write() would be fine > > with me. Just so long as we get rid of ->prepare_write and ->commit_write in > > that

Re: impact of 4k sector size on the IO & FS stack

2007-03-11 Thread Jeff Garzik
Alan Cox wrote: I would be interested to know what the disk vendors intend to use as their strategy when (with ATA) they have a 512 byte write from an older file system/setup into a 4K block. The case where errors magically appear Well, you have logical and physical sector size changes. First

Re: impact of 4k sector size on the IO & FS stack

2007-03-11 Thread Jan Engelhardt
On Mar 11 2007 18:51, Ric Wheeler wrote: > > During the recent IO/FS workshop, we spoke briefly about the > coming change to a 4k sector size for disks on linux. If I > recall correctly, the general feeling was that the impact was > not significant since we already do most file system IO in 4k > p

Re: impact of 4k sector size on the IO & FS stack

2007-03-11 Thread Alan Cox
> Are there other concerns in the IO or FS stack that we should bring up > with vendors? I have been asked to summarize the impact of 4k sectors > on linux for a disk vendor gathering and want to make sure that I put > all of our linux specific items into that summary... We need to make sure

impact of 4k sector size on the IO & FS stack

2007-03-11 Thread Ric Wheeler
During the recent IO/FS workshop, we spoke briefly about the coming change to a 4k sector size for disks on linux. If I recall correctly, the general feeling was that the impact was not significant since we already do most file system IO in 4k page sizes and should be fine as long as we parti