Re: + knfsd-exportfs-add-exportfsh-header-fix.patch added to -mm tree

2007-05-15 Thread Christoph Hellwig
On Tue, May 15, 2007 at 02:49:14PM -0700, [EMAIL PROTECTED] wrote: > fs/cifs/export.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff -puN fs/cifs/export.c~knfsd-exportfs-add-exportfsh-header-fix > fs/cifs/export.c > --- a/fs/cifs/export.c~knfsd-exportfs-add-exportfsh-heade

Re: [PATCH] LogFS take three

2007-05-15 Thread Willy Tarreau
On Wed, May 16, 2007 at 02:06:31AM +0200, Jörn Engel wrote: > On Tue, 15 May 2007 13:37:59 -0700, Andrew Morton wrote: > > It's strange and a bit regrettable that an fs would have dependency on MTD, > > really. > > It is and changing this wouldn't be too hard. All device access goes > through fiv

Re: [RFC][PATCH 8/14] Union-mount lookup

2007-05-15 Thread Bharata B Rao
On Tue, May 15, 2007 at 09:57:24AM +0200, Jan Engelhardt wrote: > > On May 14 2007 15:12, Bharata B Rao wrote: > > > >+struct dentry * d_lookup_single(struct dentry *parent, struct qstr *name) > >+{ > >+struct dentry *dentry; > >+unsigned long seq; > >+ > >+do { > >+

Re: [RFC][PATCH 7/14] Union-mount mounting

2007-05-15 Thread Bharata B Rao
On Tue, May 15, 2007 at 09:29:39AM +0200, Jan Engelhardt wrote: > > On May 14 2007 15:11, Bharata B Rao wrote: > > > >TODO: bind and move mounts aren't yet supported with union mounts. > > Are the semantics already set? Not yet. > > >@@ -294,6 +294,10 @@ static struct vfsmount *clone_mnt(struc

Re: [PATCH] LogFS take three

2007-05-15 Thread David Woodhouse
On Tue, 2007-05-15 at 21:19 +0200, Jörn Engel wrote: > On Tue, 15 May 2007 15:07:05 -0400, John Stoffel wrote: > > > > I've been semi watching this, and the only comment I really can give > > is that I hate the name. To me, logfs implies a filesystem for > > logging purposes, not for Flash hardwa

Re: [PATCH 1/5][TAKE3] fallocate() implementation on i86, x86_64 and powerpc

2007-05-15 Thread David Chinner
On Wed, May 16, 2007 at 01:33:59AM +0530, Amit K. Arora wrote: > This patch implements sys_fallocate() and adds support on i386, x86_64 > and powerpc platforms. Can you please pick up the ia64 support patch I posted as well? > Changelog: > - > Note: The changes below are from the initial

Re: [PATCH] LogFS take three

2007-05-15 Thread Roland Dreier
There are rather a lot of of FIXME comments, including scary stuff like > +/* > + * FIXME: this cannot be right but it does "fix" a bug of i_count > + * dropping too low. Needs more thought. > + */ > +atomic_inc(&old_dentry->d_inode->i_count); and > +int __logfs_write_

Re: [PATCH] LogFS take three

2007-05-15 Thread Jörn Engel
On Wed, 16 May 2007 02:06:31 +0200, Jörn Engel wrote: > > > > + > > > + if (dest) { > > > + /* symlink */ > > > + ret = logfs_inode_write(inode, dest, destlen, 0); > > > + } else { > > > + /* creat/mkdir/mknod */ > > > + ret = __logfs_write_inode(inode); > > > + } >

RE: Software raid0 will crash the file-system, when each disk is 5TB

2007-05-15 Thread Jeff Zheng
Here is the information of the created raid0. Hope it is enough. Jeff The crashing one: md: bind md: bind md: raid0 personality registered for level 0 md0: setting max_sectors to 4096, segment boundary to 1048575 raid0: looking at sde raid0: comparing sde(5859284992) with sde(5859284992) raid0:

Re: [PATCH 1/5][TAKE3] fallocate() implementation on i86, x86_64 and powerpc

2007-05-15 Thread Mingming Cao
On Wed, 2007-05-16 at 01:33 +0530, Amit K. Arora wrote: > This patch implements sys_fallocate() and adds support on i386, x86_64 > and powerpc platforms. > @@ -1137,6 +1148,8 @@ struct inode_operations { > ssize_t (*listxattr) (struct dentry *, char *, size_t); > int (*removexattr) (st

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-15 Thread Nick Piggin
Andrew Morton wrote: On Tue, 15 May 2007 16:52:31 +0100 David Howells <[EMAIL PROTECTED]> wrote: Implement shared-writable mmap for AFS. This blows up in -mm: fs/afs/file.c:59: error: 'filemap_nopage' undeclared here (not in a function) fs/afs/file.c:60: error: unknown field 'populate' spe

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-15 Thread Nick Piggin
David Howells wrote: Implement shared-writable mmap for AFS. The key with which to access the file is obtained from the VMA at the point where the PTE is made writable by the page_mkwrite() VMA op and cached in the affected page. If there's an outstanding write on the page made with a different

Re: [PATCH 1/2] AFS: Fix afs_prepare_write()

2007-05-15 Thread Nick Piggin
David Howells wrote: afs_prepare_write() should not mark a page up to date if it only partially fills it in, in expectation of the caller filling in the rest prior to calling commit_write(). commit_write(), however, should mark the page up to date. Acked-by: Nick Piggin <[EMAIL PROTECTED]>

Re: [PATCH] LogFS take three

2007-05-15 Thread Jörn Engel
On Tue, 15 May 2007 19:26:17 -0400, Albert Cahalan wrote: > > Please don't forget the immutable bit. ("man lsattr") > Having both, BSD-style, would be even better. > The immutable bit is important for working around > software bugs and "features" that damage files. > > I also can't find xattr sup

Re: [PATCH] LogFS take three

2007-05-15 Thread Jörn Engel
On Tue, 15 May 2007 13:37:59 -0700, Andrew Morton wrote: > > + > > +config LOGFS_FSCK > > + bool "Run LogFS fsck at mount time" > > + depends on LOGFS > > + help > > + Run a full filesystem check on every mount. If any errors are > > + found, mounting the filesystem will fail. This

Re: Software raid0 will crash the file-system, when each disk is 5TB

2007-05-15 Thread Neil Brown
On Wednesday May 16, [EMAIL PROTECTED] wrote: > > > > Anybody have a clue? > > No... When a raid0 array is assemble, quite a lot of message get printed about number of zones and hash_spacing etc. Can you collect and post those. Both for the failing case (2*5.5T) and the working case (4*2.55T) is

Re: [PATCH 0/5][TAKE3] fallocate system call

2007-05-15 Thread Mingming Cao
On Wed, 2007-05-16 at 01:07 +0530, Amit K. Arora wrote: > ToDos: > - > 1> Implementation on other architectures (other than i386, x86_64, > ppc64 and s390(x)). David Chinner has already posted a patch for ia64. Here is the 2.6.22-rc1 version of David's patch: add fallocate() on ia64 From: Da

Re: Software raid0 will crash the file-system, when each disk is 5TB

2007-05-15 Thread Michal Piotrowski
[Ingo, Neil, linux-raid added to CC] On 16/05/07, Jeff Zheng <[EMAIL PROTECTED]> wrote: Hi everyone: We are experiencing problems with software raid0, with very large disk arrays. We are using two 3ware disk array controllers, each of them is connected 8 750GB harddrives. And we build a

Re: [PATCH] LogFS take three

2007-05-15 Thread Albert Cahalan
Please don't forget the immutable bit. ("man lsattr") Having both, BSD-style, would be even better. The immutable bit is important for working around software bugs and "features" that damage files. I also can't find xattr support. - To unsubscribe from this list: send the line "unsubscribe linux-

Software raid0 will crash the file-system, when each disk is 5TB

2007-05-15 Thread Jeff Zheng
Hi everyone: We are experiencing problems with software raid0, with very large disk arrays. We are using two 3ware disk array controllers, each of them is connected 8 750GB harddrives. And we build a software raid0 on top of that. The total capacity is 5.5TB+5.5TB=11TB We use jfs as the f

Re: [PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-15 Thread Andrew Morton
On Tue, 15 May 2007 16:52:31 +0100 David Howells <[EMAIL PROTECTED]> wrote: > Implement shared-writable mmap for AFS. This blows up in -mm: fs/afs/file.c:59: error: 'filemap_nopage' undeclared here (not in a function) fs/afs/file.c:60: error: unknown field 'populate' specified in initializer fs/

Re: [PATCH] LogFS take three

2007-05-15 Thread Andrew Morton
On Tue, 15 May 2007 17:19:20 +0200 J__rn Engel <[EMAIL PROTECTED]> wrote: > Add LogFS, a scalable flash filesystem. > > ... > > > +config LOGFS > + tristate "Log Filesystem (EXPERIMENTAL)" > + depends on EXPERIMENTAL > + select ZLIB_INFLATE > + select ZLIB_DEFLATE > + help >

[PATCH 5/5][TAKE3] ext4: write support for preallocated blocks

2007-05-15 Thread Amit K. Arora
This patch adds write support to the uninitialized extents that get created when a preallocation is done using fallocate(). It takes care of splitting the extents into multiple (upto three) extents and merging the new split extents with neighbouring ones, if possible. Changelog: - Note: Th

[PATCH 4/5][TAKE3] ext4: fallocate support in ext4

2007-05-15 Thread Amit K. Arora
This patch implements ->fallocate() inode operation in ext4. With this patch users of ext4 file systems will be able to use fallocate() system call for persistent preallocation. Current implementation only supports preallocation for regular files (directories not supported as of date) with extent

[PATCH 3/5][TAKE3] ext4: Extent overlap bugfix

2007-05-15 Thread Amit K. Arora
This patch adds a check for overlap of extents and cuts short the new extent to be inserted, if there is a chance of overlap. Changelog: - Note: The changes below are from the initial post (dated 26th April, 2007) and _not_ from TAKE2. The only difference from TAKE2 is the kernel version o

[PATCH 2/5][TAKE3] fallocate() on s390

2007-05-15 Thread Amit K. Arora
This is the patch suggested by Martin Schwidefsky to support sys_fallocate() on s390(x) platform. He also suggested a wrapper in glibc to handle this system call on s390. Posting it here so that we get feedback for this too. .globl __fallocate ENTRY(__fallocate) stm %r6,%r7,28(%r15)

[PATCH 1/5][TAKE3] fallocate() implementation on i86, x86_64 and powerpc

2007-05-15 Thread Amit K. Arora
This patch implements sys_fallocate() and adds support on i386, x86_64 and powerpc platforms. Changelog: - Note: The changes below are from the initial post (dated 26th April, 2007) and _not_ from TAKE2. The only difference from TAKE2 is the kernel version on which this patch is based. TAK

[PATCH 0/5][TAKE3] fallocate system call

2007-05-15 Thread Amit K. Arora
-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ P L E A S EN O T E : *** 1. Patches have been now rebased to 2.6.22-rc1 kernel. Earlier they were based on 2.6.21. 2. An unnecessary export of symbol is removed from the ext4 preallocate patch. Details

Re: [PATCH] LogFS take three

2007-05-15 Thread Jörn Engel
On Tue, 15 May 2007 15:07:05 -0400, John Stoffel wrote: > > I've been semi watching this, and the only comment I really can give > is that I hate the name. To me, logfs implies a filesystem for > logging purposes, not for Flash hardware with wear leveling issues to > be taken into account. Yeah,

Re: [PATCH] LogFS take three

2007-05-15 Thread Jörn Engel
On Tue, 15 May 2007 20:37:25 +0200, Sam Ravnborg wrote: > On Tue, May 15, 2007 at 05:19:20PM +0200, Jörn Engel wrote: > > [ I have put everyone that gave comments to the last patch on Cc:. Hope > > that doesn't offend anyone. ] > > > > > > Add LogFS, a scalable flash filesystem. > > Have you ru

Re: [2.6.21] circular locking dependency found in QUOTA OFF

2007-05-15 Thread Jan Kara
On Tue 15-05-07 19:52:03, Folkert van Heusden wrote: > I'm afraid it doesn't compile: > > CHK include/linux/version.h > CHK include/linux/utsrelease.h > CHK include/linux/compile.h > CC fs/dquot.o > CC fs/quota.o > fs/quota.c: In function `quota_sync_sb': > fs/quota

Re: [PATCH] LogFS take three

2007-05-15 Thread Sam Ravnborg
On Tue, May 15, 2007 at 05:19:20PM +0200, Jörn Engel wrote: > [ I have put everyone that gave comments to the last patch on Cc:. Hope > that doesn't offend anyone. ] > > > Add LogFS, a scalable flash filesystem. Have you run sparse on this code? I do not recall if you have written something abo

Re: [2.6.21] circular locking dependency found in QUOTA OFF

2007-05-15 Thread Jan Kara
On Tue 15-05-07 19:52:03, Folkert van Heusden wrote: > I'm afraid it doesn't compile: > > CHK include/linux/version.h > CHK include/linux/utsrelease.h > CHK include/linux/compile.h > CC fs/dquot.o > CC fs/quota.o > fs/quota.c: In function `quota_sync_sb': > fs/quota

Re: [2.6.21] circular locking dependency found in QUOTA OFF

2007-05-15 Thread Folkert van Heusden
I'm afraid it doesn't compile: CHK include/linux/version.h CHK include/linux/utsrelease.h CHK include/linux/compile.h CC fs/dquot.o CC fs/quota.o fs/quota.c: In function `quota_sync_sb': fs/quota.c:180: error: `I_MUTEX_NESTED' undeclared (first use in this function)

[PATCH] AFS: Write back dirty data on unmount

2007-05-15 Thread David Howells
Fix AFS to write back dirty on unmounting. This didn't happen because afs_super_ops.drop_inode was pointing to generic_delete_inode. Now this pointer is left set to NULL so that the default behaviour occurs instead. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/afs/super.c |1 -

[PATCH 2/2] AFS: Implement shared-writable mmap

2007-05-15 Thread David Howells
Implement shared-writable mmap for AFS. The key with which to access the file is obtained from the VMA at the point where the PTE is made writable by the page_mkwrite() VMA op and cached in the affected page. If there's an outstanding write on the page made with a different key, then page_mkwrite

[PATCH 1/2] AFS: Fix afs_prepare_write()

2007-05-15 Thread David Howells
afs_prepare_write() should not mark a page up to date if it only partially fills it in, in expectation of the caller filling in the rest prior to calling commit_write(). commit_write(), however, should mark the page up to date. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- fs/afs/write.c

Review status (Re: [PATCH] LogFS take three)

2007-05-15 Thread Jörn Engel
Most of my homework is done. There are six items left plus another five I believe should not get changed. Changed: o Kconfig description updated o Spaces converted to tabs in Makefile o Sorted/seperated #includes o structures are __packed instead of packed, #define removed o removed TRACE() o 32

Re: [RFC][PATCH 13/14] ext3 whiteout support

2007-05-15 Thread Theodore Tso
On Mon, May 14, 2007 at 10:35:47PM +0200, Jan Blunck wrote: > > I don't know. I tried to contact him a few weeks ago but failed. > Guess, maybe he isn't reading the @thunk.org email anymore which was > reference in the e2fsprogs source I used. I do pay more attention to mail sent to the @mit.edu

Re: [RFC][PATCH 8/14] Union-mount lookup

2007-05-15 Thread Trond Myklebust
On Mon, 2007-05-14 at 15:12 +0530, Bharata B Rao wrote: > From: Jan Blunck <[EMAIL PROTECTED]> > Subject: Union-mount lookup > > Modifies the vfs lookup routines to work with union mounted directories. > > The existing lookup routines generally lookup for a pathname only in the > topmost or given

Re: [2.6.21] circular locking dependency found in QUOTA OFF

2007-05-15 Thread Jan Kara
Hi, Thanks for report. It seems like a lockdep problem. i_mutex for quota files is below dqonoff_sem. We were already fixing this for filesystem specific quota IO functions but obviously we've missed a few cases. I wonder why it showed up only now... Anyway, attached is a fix. Andrew, would yo

Re: [PATCH 1/5][TAKE2] fallocate() implementation on i86, x86_64 and powerpc

2007-05-15 Thread Amit K. Arora
On Tue, May 15, 2007 at 09:44:36AM +1000, Stephen Rothwell wrote: > On Mon, 14 May 2007 20:15:24 +0530 "Amit K. Arora" <[EMAIL PROTECTED]> wrote: > > > > This patch implements sys_fallocate() and adds support on i386, x86_64 > > and powerpc platforms. > > This patch no longer applies to Linus' tre

Re: [RFC][PATCH 2/14] Add a new mount flag (MNT_UNION) for union mount

2007-05-15 Thread Jan Blunck
On 5/15/07, Eric Van Hensbergen <[EMAIL PROTECTED]> wrote: On 5/15/07, Bharata B Rao <[EMAIL PROTECTED]> wrote: > > So there can be two cases in union mounts: > 1. A file exists in topmost layer and also in one or more lower layers. Deleting > the file would result in the top layer file being de

Re: [PATCH 0/5][TAKE2] fallocate system call

2007-05-15 Thread Amit K. Arora
On Tue, May 15, 2007 at 12:31:21AM -0600, Andreas Dilger wrote: > On May 14, 2007 18:59 +0530, Amit K. Arora wrote: > > asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len) > > > > fd: The descriptor of the open file. > > > > mode*: This specifies the behavior of the syste

Re: [RFC][PATCH 2/14] Add a new mount flag (MNT_UNION) for union mount

2007-05-15 Thread Eric Van Hensbergen
On 5/15/07, Bharata B Rao <[EMAIL PROTECTED]> wrote: So there can be two cases in union mounts: 1. A file exists in topmost layer and also in one or more lower layers. Deleting the file would result in the top layer file being deleted and a whiteout being created in the top layer. 2. A file exi

Re: [RFC][PATCH 13/14] ext3 whiteout support

2007-05-15 Thread Jan Blunck
On 5/15/07, Bharata B Rao <[EMAIL PROTECTED]> wrote: On Mon, May 14, 2007 at 01:16:57PM -0700, Badari Pulavarty wrote: > On Mon, 2007-05-14 at 15:14 +0530, Bharata B Rao wrote: > > From: Bharata B Rao <[EMAIL PROTECTED]> > > > > +static int ext3_whiteout(struct inode *dir, struct dentry *dentry)

Re: [RFC][PATCH 2/14] Add a new mount flag (MNT_UNION) for union mount

2007-05-15 Thread Bharata B Rao
On Mon, May 14, 2007 at 10:38:46PM +0200, Jan Engelhardt wrote: > > On May 14 2007 15:09, Bharata B Rao wrote: > > > >Introduce MNT_UNION, MS_UNION and FS_WHT flags. There are the necessary flags > >for doing > > > >mount /dev/hda3 /mnt -o union > > > >You need additional patches for util-linu

Re: [RFC][PATCH 8/14] Union-mount lookup

2007-05-15 Thread Jan Engelhardt
On May 14 2007 15:12, Bharata B Rao wrote: > >+struct dentry * d_lookup_single(struct dentry *parent, struct qstr *name) >+{ >+ struct dentry *dentry; >+ unsigned long seq; >+ >+do { >+seq = read_seqbegin(&rename_lock); >+dentry = __d_lookup_singl

Re: [RFC][PATCH 7/14] Union-mount mounting

2007-05-15 Thread Jan Engelhardt
On May 14 2007 15:11, Bharata B Rao wrote: > >TODO: bind and move mounts aren't yet supported with union mounts. Are the semantics already set? >@@ -294,6 +294,10 @@ static struct vfsmount *clone_mnt(struct > if (!mnt) > goto alloc_failed; > >+ /* >+ * As of now,

Re: [RFC][PATCH 5/14] Introduce union stack

2007-05-15 Thread Jan Blunck
On 5/14/07, Jan Engelhardt <[EMAIL PROTECTED]> wrote: >+static inline void union_lock(struct dentry *dentry) >+{ >+ if (unlikely(dentry && dentry->d_union)) { >+ struct union_info *ui = dentry->d_union; >+ >+ UM_DEBUG_LOCK("\"%s\" locking %p (count=%d)\n", >+