Re: vm/fs meetup in september?

2007-06-24 Thread Christoph Hellwig
On Sun, Jun 24, 2007 at 06:23:45AM +0200, Nick Piggin wrote: > I'd just like to take the chance also to ask about a VM/FS meetup some > time around kernel summit (maybe take a big of time during UKUUG or so). I won't be around until a day or two before KS, so I'd prefer to have it after KS if poss

Re: [patch 1/3] add the fsblock layer

2007-06-24 Thread Neil Brown
On Sunday June 24, [EMAIL PROTECTED] wrote: > > +#define PG_blocks20 /* Page has block mappings */ > + I've only had a very quick look, but this line looks *very* wrong. You should be using PG_private. There should never be any confusion about whether ->private has buffers or b

Re: [AppArmor 39/45] AppArmor: Profile loading and manipulation, pathname matching

2007-06-24 Thread Pavel Machek
Hi! > But as someone who doesn't use either SElinux or AA, I really hope > we can get past the part of the debate where: > > while(1) > AA) we think we're making users happy with pathname security > SELINUX) pathname security sucks (Hopefully I'll not be fired for this. :-) Yes, we _are

Re: [patch 1/3] add the fsblock layer

2007-06-24 Thread Arjan van de Ven
> Hmm, could define a macro DECLARE_ATOMIC_BITMAP(maxbit) that expands to the > smallest > possible type for each architecture. And a couple of ugly casts for set_bit > et.al. > but those could be also hidden in macros. Should be relatively easy to do. or make a "smallbit" type that is small/su

Re: [patch 1/3] add the fsblock layer

2007-06-24 Thread Andi Kleen
Nick Piggin <[EMAIL PROTECTED]> writes: [haven't read everything, just commenting on something that caught my eye] > +struct fsblock { > + atomic_tcount; > + union { > + struct { > + unsigned long flags; /* XXX: flags could be int for > better p

Re: [RFC] fsblock

2007-06-24 Thread Chris Mason
On Sun, Jun 24, 2007 at 05:47:55AM +0200, Nick Piggin wrote: > On Sat, Jun 23, 2007 at 11:07:54PM -0400, Jeff Garzik wrote: > > > >- Large block support. I can mount and run an 8K block size minix3 fs on > > > my 4K page system and it didn't require anything special in the fs. We > > > can go up

Re: [RFC] fsblock

2007-06-24 Thread Andi Kleen
Nick Piggin <[EMAIL PROTECTED]> writes: > > - Structure packing. A page gets a number of buffer heads that are > allocated in a linked list. fsblocks are allocated contiguously, so > cacheline footprint is smaller in the above situation. It would be interesting to test if that makes a differe

[PATCH] update description in Documentation/filesystems/vfs.txt

2007-06-24 Thread Borislav Petkov
While reading the said file I noticed some discrepancies between the actual code and the info in the docs. Here's an update that attempts to match it to the code in the current 2.6.22-rc5. --- From: Borislav Petkov <[EMAIL PROTECTED]> Update the description of struct file_system_type and get_sb()