Re: [PATCH] CIFS: make cifsd (more)

2007-06-25 Thread Christoph Hellwig
On Mon, Jun 25, 2007 at 05:25:00PM -0500, Steve French wrote: > Jeff, > Not seeing any objections to your revised approach (to not allowing > signals for cifsd kernel thread), I just merged something similar to > your patch to the cifs-2.6.git tree (also fixed some nearby lines that > went past 80

Re: vm/fs meetup in september?

2007-06-25 Thread Christoph Hellwig
On Mon, Jun 25, 2007 at 05:08:02PM -0700, Jared Hulbert wrote: > -memory mappable swap file (I'm not sure if this one is appropriate > for the proposed meeting) Please explain what this is supposed to mean. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of

Re: Patent or not patent a new idea

2007-06-25 Thread Neil Brown
On Tuesday June 26, [EMAIL PROTECTED] wrote: > > Thanks for the brief howto there. I'll install the mdadm suite and > experiment. It seems like a userspace driver? mdadm is a userspace tool for managing the 'md' driver which is in the linux kernel. > > I don't know what you mean by '2'. > > 2 m

Re: Patent or not patent a new idea

2007-06-25 Thread Graeme Sheppard
Neil Brown wrote: ??? (reads original description in more detail). So... the filesystem images are identical in both copies, and the "interesting" bit is that the image is just a file on some filesystem. So could I implement your idea by: dd if=/dev/zero of=/1/bigfile count=lotsandlots dd

Re: [RFC] fsblock

2007-06-25 Thread Nick Piggin
David Chinner wrote: On Sun, Jun 24, 2007 at 03:45:28AM +0200, Nick Piggin wrote: I'm announcing "fsblock" now because it is quite intrusive and so I'd like to get some thoughts about significantly changing this core part of the kernel. Can you rename it to something other than shorthand for

Re: Patent or not patent a new idea

2007-06-25 Thread Neil Brown
On Tuesday June 26, [EMAIL PROTECTED] wrote: > Neil Brown wrote: > > > > Sounds a lot like "RAIF" - ask google for details. > > I did not know about RAIF. RAIF "merges" separate filesystems? That is a > good idea in itself. > > My idea is for driver that provides a filesystem from image files it

Re: vm/fs meetup in september?

2007-06-25 Thread Andreas Dilger
On Jun 26, 2007 12:35 +1000, Nick Piggin wrote: > Leaving my opinion of higher order pagecache aside, this _may_ be an > example of something that doesn't need a lot of attention, because it > should be fairly uncontroversial from a filesystem's POV? (eg. it is > more a relevant item to memory man

Re: Patent or not patent a new idea

2007-06-25 Thread Graeme Sheppard
Neil Brown wrote: On Tuesday June 26, [EMAIL PROTECTED] wrote: Posting it here seems the best thing to do. To the inventor goes naming privilege and I'm calling this one softer raid. It is a form of storage raid implemented in software, as contrasted to software and hardware raid which are depe

Re: [patch 1/3] add the fsblock layer

2007-06-25 Thread Nick Piggin
Neil Brown wrote: On Tuesday June 26, [EMAIL PROTECTED] wrote: Chris Mason wrote: The block device pagecache isn't special, and certainly isn't that much code. I would suggest keeping it buffer head specific and making a second variant that does only fsblocks. This is mostly to keep the sem

Re: [RFC] fsblock

2007-06-25 Thread David Chinner
On Sun, Jun 24, 2007 at 03:45:28AM +0200, Nick Piggin wrote: > > I'm announcing "fsblock" now because it is quite intrusive and so I'd > like to get some thoughts about significantly changing this core part > of the kernel. Can you rename it to something other than shorthand for "filesystem block

Re: [patch 1/3] add the fsblock layer

2007-06-25 Thread Neil Brown
On Tuesday June 26, [EMAIL PROTECTED] wrote: > Chris Mason wrote: > > > > The block device pagecache isn't special, and certainly isn't that much > > code. I would suggest keeping it buffer head specific and making a > > second variant that does only fsblocks. This is mostly to keep the > > sema

Re: [patch 1/3] add the fsblock layer

2007-06-25 Thread Nick Piggin
Chris Mason wrote: On Sun, Jun 24, 2007 at 03:46:13AM +0200, Nick Piggin wrote: Rewrite the buffer layer. Overall, I like the basic concepts, but it is hard to track the locking rules. Could you please write them up? Yeah I will do that. Thanks for taking a look. One thing I am thinking

Re: vm/fs meetup in september?

2007-06-25 Thread Nick Piggin
Christoph Hellwig wrote: On Sun, Jun 24, 2007 at 06:23:45AM +0200, Nick Piggin wrote: I'd just like to take the chance also to ask about a VM/FS meetup some time around kernel summit (maybe take a big of time during UKUUG or so). I won't be around until a day or two before KS, so I'd prefer

Re: [patch 1/3] add the fsblock layer

2007-06-25 Thread Nick Piggin
Chris Mason wrote: On Mon, Jun 25, 2007 at 05:41:58PM +1000, Nick Piggin wrote: Neil Brown wrote: Why do you think you need PG_blocks? Block device pagecache (buffer cache) has to be able to accept attachment of either buffers or blocks for filesystem metadata, and call into either buffer.

Re: Patent or not patent a new idea

2007-06-25 Thread Neil Brown
On Tuesday June 26, [EMAIL PROTECTED] wrote: > Posting it here seems the best thing to do. > > To the inventor goes naming privilege and I'm calling this one softer raid. > It is a form of storage raid implemented in software, as contrasted to > software and hardware raid which are dependent on us

Re: Patent or not patent a new idea

2007-06-25 Thread Graeme Sheppard
Posting it here seems the best thing to do. To the inventor goes naming privilege and I'm calling this one softer raid. It is a form of storage raid implemented in software, as contrasted to software and hardware raid which are dependent on using required hardware. To create a loop filesystem is

Re: Patent or not patent a new idea

2007-06-25 Thread Bryan Henderson
>If your only purpose is to try generate a defensive patent, then just >dumping the idea in the public domain serves the same purpose, probably >better. > >I have a few patents, some of which are defensive. That has not prevented >the USPTO issuing quite a few patents that are in clear violation of

Re: vm/fs meetup in september?

2007-06-25 Thread Jared Hulbert
A few things I'd like to talk about are: - the address space operations APIs, and their page based nature. I think it would be nice to generally move toward offset,length based ones as much as possible because it should give more efficiency and flexibility in the filesystem. - write_begin

Re: Patent or not patent a new idea

2007-06-25 Thread manningc2
> Dear devs, > > In a moment of serendipity I thought of a concept which may be > advantageous > if incorporated into the kernel. I was going to offer it to the OIN but > they responded they only consider existing patents and I don't have the > money to afford one. > > I am seeking advice on how to

Re: Patent or not patent a new idea

2007-06-25 Thread Attila Kinali
On Tue, 26 Jun 2007 09:45:22 +1200 Graeme Sheppard <[EMAIL PROTECTED]> wrote: > I am seeking advice on how to proceed. It could be used as a defensive > patent in which case I can email an expert who can file it. If that is the > concept is sound. I am not expecting any royalties from this myself.

Re: Patent or not patent a new idea

2007-06-25 Thread alan
On Tue, 26 Jun 2007, Graeme Sheppard wrote: alan wrote: On Tue, 26 Jun 2007, Graeme Sheppard wrote: Dear devs, In a moment of serendipity I thought of a concept which may be advantageous if incorporated into the kernel. I was going to offer it to the OIN but they responded they only consid

Re: Patent or not patent a new idea

2007-06-25 Thread Graeme Sheppard
alan wrote: On Tue, 26 Jun 2007, Graeme Sheppard wrote: Dear devs, In a moment of serendipity I thought of a concept which may be advantageous if incorporated into the kernel. I was going to offer it to the OIN but they responded they only consider existing patents and I don't have the money t

Re: [PATCH] CIFS: make cifsd (more)

2007-06-25 Thread Steve French
Jeff, Not seeing any objections to your revised approach (to not allowing signals for cifsd kernel thread), I just merged something similar to your patch to the cifs-2.6.git tree (also fixed some nearby lines that went past 80 columns). Thanks Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> di

Re: Patent or not patent a new idea

2007-06-25 Thread alan
On Tue, 26 Jun 2007, Graeme Sheppard wrote: Dear devs, In a moment of serendipity I thought of a concept which may be advantageous if incorporated into the kernel. I was going to offer it to the OIN but they responded they only consider existing patents and I don't have the money to afford one.

[RFC PATCH 1/1] VFS: Augment /proc/mount with subroot and shared-subtree

2007-06-25 Thread Ram Pai
Please check if the following modified patch meets the requirements. It augments /proc/mount with additional information to (1) disambiguate bind mounts with subroot information. (2) display shared-subtree information using which one can determine the propagation tr

Patent or not patent a new idea

2007-06-25 Thread Graeme Sheppard
Dear devs, In a moment of serendipity I thought of a concept which may be advantageous if incorporated into the kernel. I was going to offer it to the OIN but they responded they only consider existing patents and I don't have the money to afford one. I am seeking advice on how to proceed. It co

Re: [PATCH 7/7][TAKE5] ext4: support new modes

2007-06-25 Thread Andreas Dilger
On Jun 25, 2007 19:20 +0530, Amit K. Arora wrote: > @@ -2499,7 +2500,8 @@ long ext4_fallocate(struct inode *inode, >* currently supporting (pre)allocate mode for extent-based >* files _only_ >*/ > - if (mode != FA_ALLOCATE || !(EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL))

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-25 Thread Andreas Dilger
On Jun 25, 2007 19:15 +0530, Amit K. Arora wrote: > +#define FA_FL_DEALLOC0x01 /* default is allocate */ > +#define FA_FL_KEEP_SIZE 0x02 /* default is extend/shrink size */ > +#define FA_FL_DEL_DATA 0x04 /* default is keep written data on DEALLOC > */ In XFS one of the (many)

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-25 Thread Andreas Dilger
On Jun 25, 2007 20:33 +0530, Amit K. Arora wrote: > I have not implemented FA_FL_FREE_ENOSPC and FA_ZERO_SPACE flags yet, as > *suggested* by Andreas in http://lkml.org/lkml/2007/6/14/323 post. > If it is decided that these flags are also needed, I will update this > patch. Thanks! Can you clari

Re: [AppArmor 39/45] AppArmor: Profile loading and manipulation, pathname matching

2007-06-25 Thread david
On Mon, 25 Jun 2007, Pavel Machek wrote: Hi! We've been over the "AA is different" discussion in threads about a billion times, and at the last kernel summit. I think Lars and others have done a pretty good job of describing the problems they are trying to solve, can we please move on to disc

[PATCH] update description in Documentation/filesystems/vfs.txt (typo fixed)

2007-06-25 Thread Borislav Petkov
On Mon, Jun 25, 2007 at 12:34:36PM +0300, Pekka Enberg wrote: > > Hi Borislav, > > On 6/24/2007, "Borislav Petkov" <[EMAIL PROTECTED]> wrote: > > @@ -3,7 +3,7 @@ > > > > Original author: Richard Gooch <[EMAIL PROTECTED]> > > > > - Last updated on October 28, 2005 > > +

Re: [PATCH 25/26] r/o bind mounts: scalable writer count

2007-06-25 Thread Miklos Szeredi
> > I'd suggest something along these lines in final mntput: > > > > lock_and_coalesce_cpu_mnt_writer_counts(); > > mnt_unlock_cpus(); > > BUG_ON(atomic_read(&mnt->__mnt_writers)); > > > > since there's basically no other we'll notice if there _is_ an > > imbalance. > > T

Re: [AppArmor 39/45] AppArmor: Profile loading and manipulation, pathname matching

2007-06-25 Thread Pavel Machek
Hi! > We've been over the "AA is different" discussion in threads about a > billion times, and at the last kernel summit. I think Lars and others > have done a pretty good job of describing the problems they are trying > to solve, can we please move on to discussing technical issues around > that

Re: [PATCH 14/26] elevate write count for file_update_time()

2007-06-25 Thread Dave Hansen
On Sat, 2007-06-23 at 08:46 +0100, Christoph Hellwig wrote: > On Fri, Jun 22, 2007 at 01:03:21PM -0700, Dave Hansen wrote: > > Signed-off-by: Dave Hansen <[EMAIL PROTECTED]> > > We really want a guaranteed non-NULL file here, but I don't want to put > this on your plate also. Please add a comment

Re: [PATCH 09/26] make access() use mnt check

2007-06-25 Thread Dave Hansen
On Sat, 2007-06-23 at 08:45 +0100, Christoph Hellwig wrote: > On Fri, Jun 22, 2007 at 01:03:14PM -0700, Dave Hansen wrote: > > > > It is OK to let access() go without using a mnt_want/drop_write() > > pair because it doesn't actually do writes to the filesystem, > > and it is inherently racy anywa

Re: [PATCH 04/26] filesystem helpers for custom 'struct file's

2007-06-25 Thread Dave Hansen
On Mon, 2007-06-25 at 10:25 -0700, Andrew Morton wrote: > On Mon, 25 Jun 2007 08:37:29 -0700 Dave Hansen <[EMAIL PROTECTED]> wrote: > > On Sat, 2007-06-23 at 09:52 -0700, Andrew Morton wrote: > > > The net/socket.c change is a mystery. My version of sock_attach_fd() > > > doesn't look like yours.

Re: vm/fs meetup in september?

2007-06-25 Thread Zach Brown
> > I'd just like to take the chance also to ask about a VM/FS meetup some > > time around kernel summit (maybe take a big of time during UKUUG or so). Yeah, I'd be interested. > More issues: - chris mason's patches to normalize buffered and direct locking - z - To unsubscribe from this list: s

Re: [PATCH 04/26] filesystem helpers for custom 'struct file's

2007-06-25 Thread Andrew Morton
On Mon, 25 Jun 2007 08:37:29 -0700 Dave Hansen <[EMAIL PROTECTED]> wrote: > On Sat, 2007-06-23 at 09:52 -0700, Andrew Morton wrote: > > > On Fri, 22 Jun 2007 13:03:08 -0700 Dave Hansen <[EMAIL PROTECTED]> wrote: > > > Christoph H. says this stands on its own and can go in before the > > > rest of

i_flags locking

2007-06-25 Thread Jan Kara
Hi, I came across the following question: What is the proper locking for using i_flags? I've noticed i_flags are read freely without any lock. The modifications I've seen e.g. in ext3 were done under i_mutex. Is this right? BTW it means that when checking i_flags we can see intermediate stat

Re: Discussion about flash SSD during OLS2007

2007-06-25 Thread Jörn Engel
On Mon, 25 June 2007 19:40:02 +0900, Dongjun Shin wrote: > > I'm working on the Linux optimization for the flash SSD (Solid State Disk), > which is becoming more practical nowadays (it's not a pipe dream any more :) > > During my work, I've found that Linux does not perform so well on SSD. > The

Re: [PATCH 05/26] r/o bind mounts: stub functions

2007-06-25 Thread Dave Hansen
On Sat, 2007-06-23 at 09:52 -0700, Andrew Morton wrote: > > On Fri, 22 Jun 2007 13:03:09 -0700 Dave Hansen <[EMAIL PROTECTED]> wrote: > > This patch adds two function mnt_want_write() and > > mnt_drop_write() > > ITYM "global, exported-to-modules yet 100% undocumented" functions. Point taken. :)

Re: [PATCH 25/26] r/o bind mounts: scalable writer count

2007-06-25 Thread Dave Hansen
On Sat, 2007-06-23 at 09:52 -0700, Andrew Morton wrote: > > On Fri, 22 Jun 2007 13:03:36 -0700 Dave Hansen <[EMAIL PROTECTED]> > wrote: > > +DEFINE_PER_CPU(struct mnt_writer, mnt_writers); > > this can have static scope. Fixed. That'll be in my update. -- Dave - To unsubscribe from this list:

Re: [PATCH 00/26] Mount writer count and read-only bind mounts

2007-06-25 Thread Dave Hansen
On Sat, 2007-06-23 at 09:52 -0700, Andrew Morton wrote: > > On Fri, 22 Jun 2007 13:03:03 -0700 Dave Hansen <[EMAIL PROTECTED]> wrote: > > Why do we need r/o bind mounts? > > > > This feature allows a read-only view into a read-write filesystem. > > In the process of doing that, it also provides in

Re: [PATCH 04/26] filesystem helpers for custom 'struct file's

2007-06-25 Thread Dave Hansen
On Sat, 2007-06-23 at 09:52 -0700, Andrew Morton wrote: > > On Fri, 22 Jun 2007 13:03:08 -0700 Dave Hansen <[EMAIL PROTECTED]> wrote: > > Christoph H. says this stands on its own and can go in before the > > rest of the r/o bind mount set. > > > > --- > > > > Some filesystems forego the vfs and

Re: [PATCH 25/26] r/o bind mounts: scalable writer count

2007-06-25 Thread Dave Hansen
On Sat, 2007-06-23 at 13:28 +0200, Miklos Szeredi wrote: > > I'd suggest something along these lines in final mntput: > > lock_and_coalesce_cpu_mnt_writer_counts(); > mnt_unlock_cpus(); > BUG_ON(atomic_read(&mnt->__mnt_writers)); > > since there's basically no other we'll

Re: [PATCH 22/26] sys_mknodat(): elevate write count for vfs_mknod/create()

2007-06-25 Thread Dave Hansen
On Sat, 2007-06-23 at 08:51 +0100, Christoph Hellwig wrote: > > diff -puN > > fs/namei.c~18-24-sys-mknodat-elevate-write-count-for-vfs-mknod-create > > fs/namei.c > > --- > > lxc/fs/namei.c~18-24-sys-mknodat-elevate-write-count-for-vfs-mknod-create > > 2007-06-21 23:23:25.0 -0700 > > ++

Re: [PATCH 06/26] elevate write count open()'d files

2007-06-25 Thread Dave Hansen
On Sat, 2007-06-23 at 08:40 +0100, Christoph Hellwig wrote: > > > Some filesystems forego the use of normal vfs calls to create > > struct files. Make sure that these users elevate the mnt writer > > count because they will get __fput(), and we need to make > > sure they're balanced. > > With th

Re: [PATCH 15/26] mount_is_safe(): add comment

2007-06-25 Thread Dave Hansen
On Sat, 2007-06-23 at 08:47 +0100, Christoph Hellwig wrote: > On Fri, Jun 22, 2007 at 01:03:22PM -0700, Dave Hansen wrote: > > This area of code is currently #ifdef'd out, so add a comment > > for the time when it is actually used. > > Ok. Does this clash with the user mount patches? Even if it

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-25 Thread Amit K. Arora
I have not implemented FA_FL_FREE_ENOSPC and FA_ZERO_SPACE flags yet, as *suggested* by Andreas in http://lkml.org/lkml/2007/6/14/323 post. If it is decided that these flags are also needed, I will update this patch. Thanks! On Mon, Jun 25, 2007 at 07:15:00PM +0530, Amit K. Arora wrote: > Impleme

Re: [PATCH 04/26] filesystem helpers for custom 'struct file's

2007-06-25 Thread Dave Hansen
On Sat, 2007-06-23 at 08:38 +0100, Christoph Hellwig wrote: > Note that we've grown more instances of the crap you're fixing here, > e.g. fs/anon_inode.c Ugh. I'll go clean that one up. -- Dave - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message t

[PATCH 7/7][TAKE5] ext4: support new modes

2007-06-25 Thread Amit K. Arora
Support new values of mode in ext4. This patch supports new mode values/flags in ext4. With this patch ext4 will be able to support FA_ALLOCATE and FA_RESV_SPACE modes. Supporting FA_DEALLOCATE and FA_UNRESV_SPACE fallocate modes in ext4 is a work for future. Signed-off-by: Amit Arora <[EMAIL PRO

[PATCH 6/7][TAKE5] ext4: write support for preallocated blocks

2007-06-25 Thread Amit K. Arora
This patch adds write support to the uninitialized extents that get created when a preallocation is done using fallocate(). It takes care of splitting the extents into multiple (upto three) extents and merging the new split extents with neighbouring ones, if possible. Changelog: - Changes

[PATCH 5/7][TAKE5] ext4: fallocate support in ext4

2007-06-25 Thread Amit K. Arora
This patch implements ->fallocate() inode operation in ext4. With this patch users of ext4 file systems will be able to use fallocate() system call for persistent preallocation. Current implementation only supports preallocation for regular files (directories not supported as of date) with extent

[PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-25 Thread Amit K. Arora
Implement new flags and values for mode argument. This patch implements the new flags and values for the "mode" argument of the fallocate system call. It is based on the discussion between Andreas Dilger and David Chinner on the man page proposed (by the later) on fallocate. Signed-off-by: Amit A

[PATCH 3/7][TAKE5] fallocate() on ia64

2007-06-25 Thread Amit K. Arora
fallocate() on ia64 ia64 fallocate syscall support. Signed-off-by: Dave Chinner <[EMAIL PROTECTED]> Index: linux-2.6.22-rc4/arch/ia64/kernel/entry.S === --- linux-2.6.22-rc4.orig/arch/ia64/kernel/entry.S 2007-06-11 17:22:15.00

[PATCH 2/7][TAKE5] fallocate() on s390(x)

2007-06-25 Thread Amit K. Arora
This is the patch suggested by Martin Schwidefsky to support sys_fallocate() on s390(x) platform. He also suggested a wrapper in glibc to handle this system call on s390. Posting it here so that we get feedback for this too. .globl __fallocate ENTRY(__fallocate) stm %r6,%r7,28(%r15)

[PATCH 1/7][TAKE5] fallocate() implementation on i386, x86_64 and powerpc

2007-06-25 Thread Amit K. Arora
This patch implements sys_fallocate() and adds support on i386, x86_64 and powerpc platforms. Changelog: - Changes from Take3 to Take4: 1) Do not update c/mtime. Let each filesystem update ctime (update of mtime will not be required for allocation since we touch only metadata/inod

[PATCH 0/6][TAKE5] fallocate system call

2007-06-25 Thread Amit K. Arora
N O T E: --- 1) Only Patches 4/7 and 7/7 are NEW. Rest of them are _already_ part of ext4 patch queue git tree hosted by Ted. 2) The above new patches (4/7 and 7/7) are based on the dicussion between Andreas Dilger and David Chinner on the mode argument, when later posted a man page o

Re: [patch 1/3] add the fsblock layer

2007-06-25 Thread Chris Mason
On Sun, Jun 24, 2007 at 03:46:13AM +0200, Nick Piggin wrote: > Rewrite the buffer layer. Overall, I like the basic concepts, but it is hard to track the locking rules. Could you please write them up? I like the way you split out the assoc_buffers from the main fsblock code, but the list setup is

Re: [patch 1/3] add the fsblock layer

2007-06-25 Thread Chris Mason
On Mon, Jun 25, 2007 at 05:41:58PM +1000, Nick Piggin wrote: > Neil Brown wrote: > >On Sunday June 24, [EMAIL PROTECTED] wrote: > > > >> > >>+#define PG_blocks 20 /* Page has block mappings */ > >>+ > > > > > >I've only had a very quick look, but this line looks *very* wrong. > >You s

Re: [RFC] fsblock

2007-06-25 Thread Chris Mason
On Mon, Jun 25, 2007 at 04:58:48PM +1000, Nick Piggin wrote: > > >Using buffer heads instead allows the FS to send file data down inside > >the transaction code, without taking the page lock. So, locking wrt > >data=ordered is definitely going to be tricky. > > > >The best long term option may be

Discussion about flash SSD during OLS2007

2007-06-25 Thread Dongjun Shin
Hello, I'm working on the Linux optimization for the flash SSD (Solid State Disk), which is becoming more practical nowadays (it's not a pipe dream any more :) During my work, I've found that Linux does not perform so well on SSD. The most important issue, I suspect, is the behavior of the Linux

Re: [PATCH] update description in Documentation/filesystems/vfs.txt

2007-06-25 Thread Pekka Enberg
Hi Borislav, On 6/24/2007, "Borislav Petkov" <[EMAIL PROTECTED]> wrote: > @@ -3,7 +3,7 @@ > > Original author: Richard Gooch <[EMAIL PROTECTED]> > > - Last updated on October 28, 2005 > + Last updated on Juni 24, 2007. There's a typo here so do s/Juni/June/g p

Re: [patch 1/3] add the fsblock layer

2007-06-25 Thread Andi Kleen
On Sun, Jun 24, 2007 at 01:18:42PM -0700, Arjan van de Ven wrote: > > > Hmm, could define a macro DECLARE_ATOMIC_BITMAP(maxbit) that expands to the > > smallest > > possible type for each architecture. And a couple of ugly casts for set_bit > > et.al. > > but those could be also hidden in macros

Re: [patch 1/3] add the fsblock layer

2007-06-25 Thread Nick Piggin
Neil Brown wrote: On Sunday June 24, [EMAIL PROTECTED] wrote: +#define PG_blocks 20 /* Page has block mappings */ + I've only had a very quick look, but this line looks *very* wrong. You should be using PG_private. There should never be any confusion about whether ->priva

Re: [patch 1/3] add the fsblock layer

2007-06-25 Thread Nick Piggin
Andi Kleen wrote: Nick Piggin <[EMAIL PROTECTED]> writes: [haven't read everything, just commenting on something that caught my eye] +struct fsblock { + atomic_tcount; + union { + struct { + unsigned long flags; /* XXX: flags could be

Re: [RFC] fsblock

2007-06-25 Thread Nick Piggin
Andi Kleen wrote: Nick Piggin <[EMAIL PROTECTED]> writes: - Structure packing. A page gets a number of buffer heads that are allocated in a linked list. fsblocks are allocated contiguously, so cacheline footprint is smaller in the above situation. It would be interesting to test if that ma

Re: [RFC] fsblock

2007-06-25 Thread Nick Piggin
Chris Mason wrote: On Sun, Jun 24, 2007 at 05:47:55AM +0200, Nick Piggin wrote: My gut feeling is that there are several problem areas you haven't hit yet, with the new code. I would agree with your gut :) Without having read the code yet (light reading for monday morning ;), ext3 and re