Re: [AppArmor 00/44] AppArmor security module overview

2007-06-26 Thread John Johansen
On Tue, Jun 26, 2007 at 07:47:00PM -0700, Andrew Morton wrote: > On Tue, 26 Jun 2007 19:24:03 -0700 John Johansen <[EMAIL PROTECTED]> wrote: > > > > > > > so... where do we stand with this? Fundamental, irreconcilable > > > differences over the use of pathname-based security? > > > > > There c

Re: [RFC] fsblock

2007-06-26 Thread David Chinner
On Wed, Jun 27, 2007 at 07:32:45AM +0200, Nick Piggin wrote: > I think using fsblock to drive the IO and keep the pagecache flags > uptodate and using a btree in the filesystem to manage extents of block > allocations wouldn't be a bad idea though. Do any filesystems actually > do this? Yes. XFS.

Re: [RFC] fsblock

2007-06-26 Thread Nick Piggin
On Tue, Jun 26, 2007 at 08:34:49AM -0400, Chris Mason wrote: > On Tue, Jun 26, 2007 at 07:23:09PM +1000, David Chinner wrote: > > On Tue, Jun 26, 2007 at 01:55:11PM +1000, Nick Piggin wrote: > > [ ... fsblocks vs extent range mapping ] > > > iomaps can double as range locks simply because iomaps

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-26 Thread Andreas Dilger
On Jun 27, 2007 09:14 +1000, David Chinner wrote: > Someone on the XFs list had an interesting request - preallocated > swap files. You can't use unwritten extents for this because > of sys_swapon()s use of bmap() (XFS returns holes for reading > unwritten extents), so we need a method of prealloc

Re: [AppArmor 00/44] AppArmor security module overview

2007-06-26 Thread Andrew Morton
On Tue, 26 Jun 2007 19:24:03 -0700 John Johansen <[EMAIL PROTECTED]> wrote: > > > > so... where do we stand with this? Fundamental, irreconcilable > > differences over the use of pathname-based security? > > > There certainly seems to be some differences of opinion over the use > of pathname-b

Re: [AppArmor 00/44] AppArmor security module overview

2007-06-26 Thread John Johansen
On Tue, Jun 26, 2007 at 04:52:02PM -0700, Andrew Morton wrote: > On Tue, 26 Jun 2007 16:07:56 -0700 > [EMAIL PROTECTED] wrote: > > > This post contains patches to include the AppArmor application security > > framework, with request for inclusion into -mm for wider testing. > > Patches 24 and 31

[AppArmor 31/44] Add d_namespace_path() to compute namespace relative pathnames

2007-06-26 Thread jjohansen
In AppArmor, we are interested in pathnames relative to the namespace root. This is the same as d_path() except for the root where the search ends. Add a function for computing the namespace-relative path. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL

[AppArmor 24/44] Pass struct vfsmount to the inode_getxattr LSM hook

2007-06-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/xattr.c |2 +- include/linux/security.h | 13 -

Re: [RFD 1/4] Pass no useless nameidata to the create, lookup, and permission IOPs

2007-06-26 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, [EMAIL PROTECTED] writes: > The create, lookup, and permission inode operations are all passed a > full nameidata. This is unfortunate because in nfsd and the mqueue > filesystem, we must instantiate a struct nameidata but cannot provide > all of the same informatio

Re: [PATCH 7/7][TAKE5] ext4: support new modes

2007-06-26 Thread David Chinner
On Wed, Jun 27, 2007 at 12:59:08AM +0530, Amit K. Arora wrote: > On Tue, Jun 26, 2007 at 12:14:00PM -0400, Andreas Dilger wrote: > > On Jun 26, 2007 17:37 +0530, Amit K. Arora wrote: > > > > I also thought another proposed flag was to determine whether mtime (and > > > > maybe ctime) is changed wh

Re: [AppArmor 00/44] AppArmor security module overview

2007-06-26 Thread Andrew Morton
On Tue, 26 Jun 2007 16:07:56 -0700 [EMAIL PROTECTED] wrote: > This post contains patches to include the AppArmor application security > framework, with request for inclusion into -mm for wider testing. Patches 24 and 31 didn't come through. Rolled-up diffstat (excluding 24&31): fs/attr.c

Re: [RFD 0/4] AppArmor - Don't pass NULL nameidata to vfs_create/lookup/permission IOPs

2007-06-26 Thread Trond Myklebust
On Tue, 2007-06-26 at 16:15 -0700, [EMAIL PROTECTED] wrote: > To remove conditionally passing of vfsmounts to the LSM, a nameidata > struct can be instantiated in the nfsd and mqueue filesystems. This > however results in useless information being passed down, as not > all fields in the nameidata

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-26 Thread David Chinner
On Tue, Jun 26, 2007 at 11:42:50AM -0400, Andreas Dilger wrote: > On Jun 26, 2007 16:15 +0530, Amit K. Arora wrote: > > On Mon, Jun 25, 2007 at 03:52:39PM -0600, Andreas Dilger wrote: > > > In XFS one of the (many) ALLOC modes is to zero existing data on allocate. > > > For ext4 all this would mea

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-26 Thread David Chinner
On Mon, Jun 25, 2007 at 03:52:39PM -0600, Andreas Dilger wrote: > On Jun 25, 2007 19:15 +0530, Amit K. Arora wrote: > > +#define FA_FL_DEALLOC 0x01 /* default is allocate */ > > +#define FA_FL_KEEP_SIZE0x02 /* default is extend/shrink size */ > > +#define FA_FL_DEL_DATA 0x04 /* defaul

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-26 Thread David Chinner
On Tue, Jun 26, 2007 at 11:34:13AM -0400, Andreas Dilger wrote: > On Jun 26, 2007 16:02 +0530, Amit K. Arora wrote: > > On Mon, Jun 25, 2007 at 03:46:26PM -0600, Andreas Dilger wrote: > > > Can you clarify - what is the current behaviour when ENOSPC (or some other > > > error) is hit? Does it kee

[RFD 4/4] Pass nameidata2 to permission() from nfsd_permission()

2007-06-26 Thread jjohansen
Construct a nameidata object and pass it down to permission(), so that we can do the proper mount flag checks there. Note that confining nfsd with AppArmor makes no sense, and so this patch is not necessary for AppArmor alone. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by:

[RFD 3/4] Dont use a NULL nameidata in xattr_permission()

2007-06-26 Thread jjohansen
Create nameidata2 struct xattr_permission so that it does not pass NULL to permission. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/xattr.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) --- a/fs/xatt

[RFD 2/4] Never pass a NULL nameidata to vfs_create()

2007-06-26 Thread jjohansen
Create a nameidata2 struct in nfsd and mqueue so that vfs_create does need to conditionally pass the vfsmnt. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c|2 +- fs/nfsd/vfs.c | 42 +

Re: [PATCH 0/6][TAKE5] fallocate system call

2007-06-26 Thread David Chinner
On Mon, Jun 25, 2007 at 06:58:10PM +0530, Amit K. Arora wrote: > 2) The above new patches (4/7 and 7/7) are based on the dicussion >between Andreas Dilger and David Chinner on the mode argument, >when later posted a man page on fallocate. Can you include the man page in this patch set, ple

[RFD 0/4] AppArmor - Don't pass NULL nameidata to vfs_create/lookup/permission IOPs

2007-06-26 Thread jjohansen
-- This post is a request for discussion on creating a second smaller nameidata struct to eliminate conditionally passing of vfsmounts to the LSM. It contains a series of patches that apply on top of the AppArmor patch series. These patches were previously post on May 14, but received no feedba

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-26 Thread David Chinner
On Mon, Jun 25, 2007 at 03:46:26PM -0600, Andreas Dilger wrote: > On Jun 25, 2007 20:33 +0530, Amit K. Arora wrote: > > I have not implemented FA_FL_FREE_ENOSPC and FA_ZERO_SPACE flags yet, as > > *suggested* by Andreas in http://lkml.org/lkml/2007/6/14/323 post. > > If it is decided that these f

[AppArmor 04/44] Pass struct vfsmount to the inode_setattr LSM hook

2007-06-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/attr.c|4 ++-- include/linux/security.h |8 ++-- se

[AppArmor 43/44] Switch to vfs_permission() in sys_fchdir()

2007-06-26 Thread jjohansen
Switch from file_permission() to vfs_permission() in sys_fchdir(): this avoids calling permission() with a NULL nameidata here. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/open.c | 16 +++- 1 file changed, 7 inserti

[AppArmor 44/44] Fix file_permission()

2007-06-26 Thread jjohansen
We cannot easily switch from file_permission() to vfs_permission() everywhere, so fix file_permission() to not use a NULL nameidata for the remaining users. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |8 +++- 1 f

[AppArmor 42/44] Switch to vfs_permission() in do_path_lookup()

2007-06-26 Thread jjohansen
Switch from file_permission() to vfs_permission() in do_path_lookup(): this avoids calling permission() with a NULL nameidata here. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c | 13 ++--- 1 file changed, 6 inser

[AppArmor 41/44] Add AppArmor LSM to security/Makefile

2007-06-26 Thread jjohansen
Signed-off-by: John Johansen <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> --- security/Kconfig |1 + security/Makefile |1 + security/apparmor/Kconfig |3 ++- 3 files changed, 4 insertions(+), 1 deletion(-) --- a/security/Kconfig +++ b/s

[AppArmor 40/44] AppArmor: all the rest

2007-06-26 Thread jjohansen
All the things that didn't nicely fit in a category on their own: kbuild code, declararions and inline functions, /sys/kernel/security/apparmor filesystem for controlling apparmor from user space, profile list functions, locking documentation, /proc/$pid/task/$tid/attr/current access. Signed-off-b

[AppArmor 39/44] AppArmor: Profile loading and manipulation, pathname matching

2007-06-26 Thread jjohansen
Pathname matching, transition table loading, profile loading and manipulation. Signed-off-by: John Johansen <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> --- security/apparmor/match.c| 248 ++ security/apparmor/match.h| 83

[AppArmor 38/44] AppArmor: Module and LSM hooks

2007-06-26 Thread jjohansen
Module parameters, LSM hooks, initialization and teardown. Signed-off-by: John Johansen <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> --- security/apparmor/lsm.c | 817 1 file changed, 817 insertions(+) --- /dev/null

[AppArmor 37/44] AppArmor: Main Part

2007-06-26 Thread jjohansen
The underlying functions by which the AppArmor LSM hooks are implemented. Signed-off-by: John Johansen <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> --- security/apparmor/main.c | 1255 +++ 1 file changed, 1255 insertions(+

[AppArmor 36/44] Export audit subsystem for use by modules

2007-06-26 Thread jjohansen
Update kenel audit range comments to show AppArmor's registered range of 1500-1599. This range used to be reserved for LSPP but LSPP uses the SE Linux range and the range was given to AppArmor. Adds necessary export symbols for audit subsystem routines. Changes audit_log_vformat to be externally v

[AppArmor 33/44] Pass struct file down the inode_*xattr security LSM hooks

2007-06-26 Thread jjohansen
This allows LSMs to also distinguish between file descriptor and path access for the xattr operations. (The other relevant operations are covered by the setattr hook.) Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/xattr.c

[AppArmor 35/44] Allow permission functions to tell between parent and leaf checks

2007-06-26 Thread jjohansen
Set the LOOKUP_CONTINUE flag when checking parent permissions. This allows permission functions to tell between parent and leaf checks. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |6 ++ 1 file changed, 6 insertio

[AppArmor 34/44] Factor out sysctl pathname code

2007-06-26 Thread jjohansen
Convert the selinux sysctl pathname computation code into a standalone function. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- include/linux/sysctl.h |2 ++ kernel/sysctl.c | 27 +++ security/s

[AppArmor 32/44] Enable LSM hooks to distinguish operations on file descriptors from operations on pathnames

2007-06-26 Thread jjohansen
Struct iattr already contains ia_file since commit cc4e69de from Miklos (which is related to commit befc649c). Use this to pass struct file down the setattr hooks. This allows LSMs to distinguish operations on file descriptors from operations on paths. Signed-off-by: Andreas Gruenbacher <[EMAIL P

[AppArmor 29/44] Fix __d_path() for lazy unmounts and make it unambiguous

2007-06-26 Thread jjohansen
First, when __d_path() hits a lazily unmounted mount point, it tries to prepend the name of the lazily unmounted dentry to the path name. It gets this wrong, and also overwrites the slash that separates the name from the following pathname component. This patch fixes that; if a process was in dire

[AppArmor 12/44] Add struct vfsmount parameters to vfs_link()

2007-06-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/ecryptfs/inode.c |9 +++-- fs/namei.c

[AppArmor 30/44] Make d_path() consistent across mount operations

2007-06-26 Thread jjohansen
The path that __d_path() computes can become slightly inconsistent when it races with mount operations: it grabs the vfsmount_lock when traversing mount points but immediately drops it again, only to re-grab it when it reaches the next mount point. The result is that the filename computed is not a

[AppArmor 27/44] Add a struct vfsmount parameter to vfs_removexattr()

2007-06-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/nfsd/vfs.c |7 --- fs/xattr.c

[AppArmor 26/44] Pass struct vfsmount to the inode_listxattr LSM hook

2007-06-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/xattr.c |2 +- include/linux/security.h | 12 +++-

[AppArmor 28/44] Pass struct vfsmount to the inode_removexattr LSM hook

2007-06-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/xattr.c |2 +- include/linux/security.h | 15 +-

[AppArmor 25/44] Add a struct vfsmount parameter to vfs_listxattr()

2007-06-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/xattr.c| 25 ++--- i

[AppArmor 21/44] Add a struct vfsmount parameter to vfs_setxattr()

2007-06-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/nfsd/vfs.c | 16 +++- fs/xattr.c

[AppArmor 22/44] Pass struct vfsmount to the inode_setxattr LSM hook

2007-06-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/xattr.c |4 ++-- include/linux/security.h | 40

[AppArmor 23/44] Add a struct vfsmount parameter to vfs_getxattr()

2007-06-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/nfsd/nfs4xdr.c |2 +- fs/nfsd/vfs.c

[AppArmor 19/44] Add struct vfsmount parameters to vfs_rename()

2007-06-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/ecryptfs/inode.c |7 ++- fs/namei.c |

[AppArmor 20/44] Pass struct vfsmount to the inode_rename LSM hook

2007-06-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |6 -- include/linux/security.h | 18 ++

[AppArmor 18/44] Pass struct vfsmount to the inode_unlink LSM hook

2007-06-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |2 +- include/linux/security.h | 12

[AppArmor 17/44] Add a struct vfsmount parameter to vfs_unlink()

2007-06-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/ecryptfs/inode.c |3 ++- fs/namei.c|

[AppArmor 16/44] Call lsm hook before unhashing dentry in vfs_rmdir()

2007-06-26 Thread jjohansen
If we unhash the dentry before calling the security_inode_rmdir hook, we cannot compute the file's pathname in the hook anymore. AppArmor needs to know the filename in order to decide whether a file may be deleted, though. Signed-off-by: John Johansen <[EMAIL PROTECTED]> Signed-off-by: Andreas Gru

[AppArmor 15/44] Pass struct vfsmount to the inode_rmdir LSM hook

2007-06-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |2 +- include/linux/security.h | 12

[AppArmor 14/44] Add a struct vfsmount parameter to vfs_rmdir()

2007-06-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/ecryptfs/inode.c |4 +++- fs/namei.c

[AppArmor 13/44] Pass the struct vfsmounts to the inode_link LSM hook

2007-06-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |3 ++- include/linux/security.h | 18 +

[AppArmor 11/44] Pass struct vfsmount to the inode_readlink LSM hook

2007-06-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/stat.c|2 +- include/linux/security.h | 11 +++ s

[AppArmor 10/44] Pass struct vfsmount to the inode_symlink LSM hook

2007-06-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |2 +- include/linux/security.h |9 ++--- sec

[AppArmor 08/44] Pass struct vfsmount to the inode_mknod LSM hook

2007-06-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |2 +- include/linux/security.h |7 +-- secur

[AppArmor 09/44] Add a struct vfsmount parameter to vfs_symlink()

2007-06-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/ecryptfs/inode.c |4 +++- fs/namei.c |

[AppArmor 07/44] Add a struct vfsmount parameter to vfs_mknod()

2007-06-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/ecryptfs/inode.c |5 - fs/namei.c |

[AppArmor 05/44] Add struct vfsmount parameter to vfs_mkdir()

2007-06-26 Thread jjohansen
The vfsmount will be passed down to the LSM hook so that LSMs can compute pathnames. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/ecryptfs/inode.c |5 - fs/namei.c

[AppArmor 06/44] Pass struct vfsmount to the inode_mkdir LSM hook

2007-06-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |2 +- include/linux/security.h |8 ++-- secu

[AppArmor 02/44] Pass struct path down to remove_suid and children

2007-06-26 Thread jjohansen
Required by a later patch that adds a struct vfsmount parameter to notify_change(). Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/ntfs/file.c |2 +- fs/reiserfs/file.c

[AppArmor 01/44] Pass struct vfsmount to the inode_create LSM hook

2007-06-26 Thread jjohansen
This is needed for computing pathnames in the AppArmor LSM. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: John Johansen <[EMAIL PROTECTED]> --- fs/namei.c |2 +- include/linux/security.h |9 ++--- sec

[AppArmor 00/44] AppArmor security module overview

2007-06-26 Thread jjohansen
This post contains patches to include the AppArmor application security framework, with request for inclusion into -mm for wider testing. These patches are currently against lkml but we will gladly rebase them against -mm so that they will apply cleanly. Any comments and feedback to improve imple

[AppArmor 03/44] Add a vfsmount parameter to notify_change()

2007-06-26 Thread jjohansen
The vfsmount parameter must be set appropriately for files visibile outside the kernel. Files that are only used in a filesystem (e.g., reiserfs xattr files) will have a NULL vfsmount. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-b

Re: [AppArmor 39/45] AppArmor: Profile loading and manipulation, pathname matching

2007-06-26 Thread Crispin Cowan
Chris Wright wrote: > * Chris Mason ([EMAIL PROTECTED]) wrote: >> I'm sure people there will have a different versions of events. The >> one part that was discussed was if pathname based security was >> useful, and a number of the people in the room (outside of >> novell) said it was. Now, it

Problem with getting signals delivered to a Samba server

2007-06-26 Thread Robert Rappaport
I have been working for a while on making a distributed file system that runs on Linux to become "lease aware". I have been using advanced versions of proposed Linux modifications that allow a file system to have a "setlease" file operations method. My primary focus in this work was to allow Sam

Re: [PATCH 1/7][TAKE5] fallocate() implementation on i386, x86_64 and powerpc

2007-06-26 Thread Heiko Carstens
> Index: linux-2.6.22-rc4/arch/powerpc/kernel/sys_ppc32.c > === > --- linux-2.6.22-rc4.orig/arch/powerpc/kernel/sys_ppc32.c > +++ linux-2.6.22-rc4/arch/powerpc/kernel/sys_ppc32.c > @@ -773,6 +773,13 @@ asmlinkage int compat_sys_truncat

Re: [PATCH 7/7][TAKE5] ext4: support new modes

2007-06-26 Thread Amit K. Arora
On Tue, Jun 26, 2007 at 12:14:00PM -0400, Andreas Dilger wrote: > On Jun 26, 2007 17:37 +0530, Amit K. Arora wrote: > > Hmm.. I am thinking of a scenario when the file system supports some > > individual flags, but does not support a particular combination of them. > > Just for example sake, assum

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-26 Thread Amit K. Arora
On Tue, Jun 26, 2007 at 11:42:50AM -0400, Andreas Dilger wrote: > On Jun 26, 2007 16:15 +0530, Amit K. Arora wrote: > > On Mon, Jun 25, 2007 at 03:52:39PM -0600, Andreas Dilger wrote: > > > In XFS one of the (many) ALLOC modes is to zero existing data on allocate. > > > For ext4 all this would mea

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-26 Thread Amit K. Arora
On Tue, Jun 26, 2007 at 11:34:13AM -0400, Andreas Dilger wrote: > On Jun 26, 2007 16:02 +0530, Amit K. Arora wrote: > > On Mon, Jun 25, 2007 at 03:46:26PM -0600, Andreas Dilger wrote: > > > Can you clarify - what is the current behaviour when ENOSPC (or some other > > > error) is hit? Does it kee

Re: [PATCH 09/26] make access() use mnt check

2007-06-26 Thread Dave Kleikamp
On Mon, 2007-06-25 at 11:27 -0700, Dave Hansen wrote: > On Sat, 2007-06-23 at 08:45 +0100, Christoph Hellwig wrote: > > You probably want to add a big comment explaining why it's fine here. > > I've got this in the next set: > > - > - if(IS_RDONLY(nd.dentry->d_inode)) > + /* > +

Re: Patent or not patent a new idea

2007-06-26 Thread Andreas Dilger
On Jun 26, 2007 09:53 -0700, Bryan Henderson wrote: > >md/raid already works happily with different sized drives from > >different manufacturers ... > > >So I still cannot see anything particularly new. > > As compared to md of conventional disk partitions, it brings the ability > to create and

Re: vm/fs meetup in september?

2007-06-26 Thread Jared Hulbert
On 6/25/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote: On Mon, Jun 25, 2007 at 05:08:02PM -0700, Jared Hulbert wrote: > -memory mappable swap file (I'm not sure if this one is appropriate > for the proposed meeting) Please explain what this is supposed to mean. If you have a large array of a

Re: Patent or not patent a new idea

2007-06-26 Thread Bryan Henderson
>md/raid already works happily with different sized drives from >different manufacturers ... >So I still cannot see anything particularly new. As compared to md of conventional disk partitions, it brings the ability to create and delete arrays without shutting down all use of the physical disks

Re: [PATCH 7/7][TAKE5] ext4: support new modes

2007-06-26 Thread Andreas Dilger
On Jun 26, 2007 17:37 +0530, Amit K. Arora wrote: > Hmm.. I am thinking of a scenario when the file system supports some > individual flags, but does not support a particular combination of them. > Just for example sake, assume we have FA_ZERO_SPACE mode also. Now, if a > file system supports FA_Z

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-26 Thread Andreas Dilger
On Jun 26, 2007 16:15 +0530, Amit K. Arora wrote: > On Mon, Jun 25, 2007 at 03:52:39PM -0600, Andreas Dilger wrote: > > In XFS one of the (many) ALLOC modes is to zero existing data on allocate. > > For ext4 all this would mean is calling ext4_ext_mark_uninitialized() on > > each extent. For some

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-26 Thread Andreas Dilger
On Jun 26, 2007 16:02 +0530, Amit K. Arora wrote: > On Mon, Jun 25, 2007 at 03:46:26PM -0600, Andreas Dilger wrote: > > Can you clarify - what is the current behaviour when ENOSPC (or some other > > error) is hit? Does it keep the current fallocate() or does it free it? > > Currently it is left

Re: [PATCH 2/7][TAKE5] fallocate() on s390(x)

2007-06-26 Thread Heiko Carstens
> Index: linux-2.6.22-rc4/arch/s390/kernel/syscalls.S > === > --- linux-2.6.22-rc4.orig/arch/s390/kernel/syscalls.S 2007-06-11 > 16:16:01.0 -0700 > +++ linux-2.6.22-rc4/arch/s390/kernel/syscalls.S 2007-06-11 > 16:27:29.0

Re: [RFC PATCH 1/1] VFS: Augment /proc/mount with subroot and shared-subtree

2007-06-26 Thread H. Peter Anvin
Karel Zak wrote: (BTW, maybe we can completely remove "freq, passno" from /proc/mounts, especially if we don't have care about compatibility with /etc/{mtab,fstab} format. The freq and passno are always zero in /proc/mounts). But we do, since there are applications which use getmntent() a

Re: vm/fs meetup in september?

2007-06-26 Thread Chris Mason
On Tue, Jun 26, 2007 at 12:35:09PM +1000, Nick Piggin wrote: > Christoph Hellwig wrote: > >On Sun, Jun 24, 2007 at 06:23:45AM +0200, Nick Piggin wrote: > > > >>I'd just like to take the chance also to ask about a VM/FS meetup some > >>time around kernel summit (maybe take a big of time during UKUUG

Re: [RFC] fsblock

2007-06-26 Thread Chris Mason
On Tue, Jun 26, 2007 at 07:23:09PM +1000, David Chinner wrote: > On Tue, Jun 26, 2007 at 01:55:11PM +1000, Nick Piggin wrote: [ ... fsblocks vs extent range mapping ] > iomaps can double as range locks simply because iomaps are > expressions of ranges within the file. Seeing as you can only > ac

Re: [patch 1/3] add the fsblock layer

2007-06-26 Thread Chris Mason
On Tue, Jun 26, 2007 at 01:07:43PM +1000, Nick Piggin wrote: > Neil Brown wrote: > >On Tuesday June 26, [EMAIL PROTECTED] wrote: > > > >>Chris Mason wrote: > >> > >>>The block device pagecache isn't special, and certainly isn't that much > >>>code. I would suggest keeping it buffer head specific a

Re: [PATCH 7/7][TAKE5] ext4: support new modes

2007-06-26 Thread Amit K. Arora
On Mon, Jun 25, 2007 at 03:56:25PM -0600, Andreas Dilger wrote: > On Jun 25, 2007 19:20 +0530, Amit K. Arora wrote: > > @@ -2499,7 +2500,8 @@ long ext4_fallocate(struct inode *inode, > > * currently supporting (pre)allocate mode for extent-based > > * files _only_ > > */ > > - if

Re: [RFC] fsblock

2007-06-26 Thread Nick Piggin
On Tue, Jun 26, 2007 at 07:23:09PM +1000, David Chinner wrote: > On Tue, Jun 26, 2007 at 01:55:11PM +1000, Nick Piggin wrote: > > > > > >Realistically, this is not about "filesystem blocks", this is > > >about file offset to disk blocks. i.e. it's a mapping. > > > > Yeah, fsblock ~= the layer betw

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-26 Thread Amit K. Arora
On Mon, Jun 25, 2007 at 03:52:39PM -0600, Andreas Dilger wrote: > On Jun 25, 2007 19:15 +0530, Amit K. Arora wrote: > > +#define FA_FL_DEALLOC 0x01 /* default is allocate */ > > +#define FA_FL_KEEP_SIZE0x02 /* default is extend/shrink size */ > > +#define FA_FL_DEL_DATA 0x04 /* defaul

Re: [PATCH 4/7][TAKE5] support new modes in fallocate

2007-06-26 Thread Amit K. Arora
On Mon, Jun 25, 2007 at 03:46:26PM -0600, Andreas Dilger wrote: > On Jun 25, 2007 20:33 +0530, Amit K. Arora wrote: > > I have not implemented FA_FL_FREE_ENOSPC and FA_ZERO_SPACE flags yet, as > > *suggested* by Andreas in http://lkml.org/lkml/2007/6/14/323 post. > > If it is decided that these f

Re: [RFC] fsblock

2007-06-26 Thread David Chinner
On Tue, Jun 26, 2007 at 01:55:11PM +1000, Nick Piggin wrote: > David Chinner wrote: > >On Sun, Jun 24, 2007 at 03:45:28AM +0200, Nick Piggin wrote: > >>I'm announcing "fsblock" now because it is quite intrusive and so I'd > >>like to get some thoughts about significantly changing this core part > >

Re: [AppArmor 39/45] AppArmor: Profile loading and manipulation, pathname matching

2007-06-26 Thread Lars Marowsky-Bree
On 2007-06-25T17:14:11, Pavel Machek <[EMAIL PROTECTED]> wrote: > Actually, I surprised Lars a lot by telling him ln /etc/shadow /tmp/ > allows any user to make AA ineffective on large part of systems -- in > internal discussion. (It is not actually a _bug_, but it is certainly > unexpected). Pav

Re: [RFC PATCH 1/1] VFS: Augment /proc/mount with subroot and shared-subtree

2007-06-26 Thread Karel Zak
On Mon, Jun 25, 2007 at 03:00:15PM -0700, Ram Pai wrote: > Please check if the following modified patch meets the requirements. > > It augments /proc/mount with additional information to > (1) disambiguate bind mounts with subroot information. > (2) display shared-subtree information u