[BUG?] "ext4_ext_put_in_cache" uses __u32 to receive physical block number.

2007-07-26 Thread Yan Zheng
Hi, all I think I found a bug in ext4/extents.c, "ext4_ext_put_in_cache" uses "__u32" to receive physical block number. "ext4_ext_put_in_cache" is used in "ext4_ext_get_blocks", it sets ext4 inode's extent cache according most recently tree lookup (higher 16 bits of saved physical block number ar

Re: [RFC] basic delayed allocation in VFS

2007-07-26 Thread David Chinner
[please don't top post!] On Thu, Jul 26, 2007 at 05:33:08PM +0400, Alex Tomas wrote: > Jeff Garzik wrote: > >The XFS one is proven and the work was already completed. > > > >What were the specific technical issues that made it unsuitable for ext4? > > > >I would rather not reinvent the wheel, part

Re: [PATCH RFC] extent mapped page cache

2007-07-26 Thread Nick Piggin
On Thu, Jul 26, 2007 at 09:05:15AM -0400, Chris Mason wrote: > On Thu, 26 Jul 2007 04:36:39 +0200 > Nick Piggin <[EMAIL PROTECTED]> wrote: > > [ are state trees a good idea? ] > > > > One thing it gains us is finding the start of the cluster. Even if > > > called by kswapd, the state tree allows

[PATCH] partially fix up the lookup_one_noperm mess

2007-07-26 Thread Christoph Hellwig
Try to fix the mess created by sysfs braindamage. - refactor code internal to fs/namei.c a little to avoid too much duplication: o __lookup_hash_kern is renamed back to __lookup_hash o the old __lookup_hash goes away, permission checks moves to the two callers

Re: PROBLEM: slow NFS locking "lockd: failed to monitor xxxxx"

2007-07-26 Thread Trond Myklebust
On Thu, 2007-07-26 at 16:40 +0100, Anna Langley wrote: > [1] slow NFS locking, dmesg reports "lockd: failed to monitor x" Which tells you that rpc.statd either isn't running, or isn't able to receive RPC calls. Note that rpc.statd has to run on both the client and the server. > [2] Applicatio

PROBLEM: slow NFS locking "lockd: failed to monitor xxxxx"

2007-07-26 Thread Anna Langley
[1] slow NFS locking, dmesg reports "lockd: failed to monitor x" [2] Applications which set locks in NFS mounted home directories start very slowly. dmesg shows the following, repeated over and over: lockd: cannot monitor cabinet lockd: failed to monitor cabinet (cabinet is running Solaris

Re: Why the third parameter of "ext4_ext_put_in_cache" is __u32?

2007-07-26 Thread Yan Zheng
sorry, I mean the fourth parameter of "ext4_ext_put_in_cache. 2007/7/26, Yan Zheng <[EMAIL PROTECTED]>: Hi all The third parameter of "ext4_ext_put_in_cache" is used to receive physical block number. I think the data type should be "ext4_fsblk_t". Thanks in advance. YZ - To unsubscribe f

Why the third parameter of "ext4_ext_put_in_cache" is __u32?

2007-07-26 Thread Yan Zheng
Hi all The third parameter of "ext4_ext_put_in_cache" is used to receive physical block number. I think the data type should be "ext4_fsblk_t". Thanks in advance. YZ - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More ma

Re: [RFC] basic delayed allocation in VFS

2007-07-26 Thread Alex Tomas
It duplicates fs/mpage.c in bio building and introduces new generic API (iomap, map_blocks_t, etc). In contrast, my trivial implementation re-use existing code in fs/mpage.c, doesn't introduce new API and I tend to think provides quite the same functionality. I can be wrong, of course ... thanks,

Re: [PATCH RFC] extent mapped page cache

2007-07-26 Thread Chris Mason
On Thu, 26 Jul 2007 04:36:39 +0200 Nick Piggin <[EMAIL PROTECTED]> wrote: [ are state trees a good idea? ] > > One thing it gains us is finding the start of the cluster. Even if > > called by kswapd, the state tree allows writepage to find the start > > of the cluster and send down a big bio (pr

Re: [RFC] basic delayed allocation in ext4

2007-07-26 Thread Alex Tomas
Aneesh Kumar K.V wrote: +/* first, we need to know whether the block is allocated already + * XXX: when the filesystem has a lot of free blocks, we could + * reserve even allocated blocks to save this lookup */ +ret = ext4_get_blocks_wrap(NULL, inode, iblock, 1, bh_result, 0, 0)

Re: [RFC] basic delayed allocation in VFS

2007-07-26 Thread Jeff Garzik
Alex Tomas wrote: Jeff Garzik wrote: Is this based on Christoph's work? Christoph, or some other XFS hacker, already did generic delalloc, modeled on the XFS delalloc code. nope, this one is simple (something I'd prefer for ext4). The XFS one is proven and the work was already completed.

Re: [RFC] basic delayed allocation in VFS

2007-07-26 Thread Aneesh Kumar K.V
Alex Tomas wrote: Good day, please review ... thanks, Alex basic delayed allocation in VFS: * block_prepare_write() can be passed special ->get_block() which doesn't allocate blocks, but reserve them and mark bh delayed * a filesystem can use mpage_da_writepages() with other ->get_blo

Re: [RFC] basic delayed allocation in ext4

2007-07-26 Thread Aneesh Kumar K.V
Alex Tomas wrote: Good day, please review ... thanks, Alex Basic delayed allocation in ext4 Two special ->get_block() methods are introduced: * ext4_da_get_block_prep() to be used with ->prepare_write(), defers allocation till flush * ext4_da_get_block_write() to be used with mpage

Re: [RFC] basic delayed allocation in VFS

2007-07-26 Thread Alex Tomas
Jeff Garzik wrote: Is this based on Christoph's work? Christoph, or some other XFS hacker, already did generic delalloc, modeled on the XFS delalloc code. nope, this one is simple (something I'd prefer for ext4). thanks, Alex - To unsubscribe from this list: send the line "unsubscribe linu

Re: [RFC] basic delayed allocation in VFS

2007-07-26 Thread Jeff Garzik
Alex Tomas wrote: Good day, please review ... thanks, Alex basic delayed allocation in VFS: * block_prepare_write() can be passed special ->get_block() which doesn't allocate blocks, but reserve them and mark bh delayed * a filesystem can use mpage_da_writepages() with other ->get_block

[RFC] basic delayed allocation in VFS

2007-07-26 Thread Alex Tomas
Good day, please review ... thanks, Alex basic delayed allocation in VFS: * block_prepare_write() can be passed special ->get_block() which doesn't allocate blocks, but reserve them and mark bh delayed * a filesystem can use mpage_da_writepages() with other ->get_block() which doesn't

[RFC] basic delayed allocation in ext4

2007-07-26 Thread Alex Tomas
Good day, please review ... thanks, Alex Basic delayed allocation in ext4 Two special ->get_block() methods are introduced: * ext4_da_get_block_prep() to be used with ->prepare_write(), defers allocation till flush * ext4_da_get_block_write() to be used with mpage_da_writepages(), all

Re: [PATCH RFC] extent mapped page cache

2007-07-26 Thread Anton Altaparmakov
On 26 Jul 2007, at 03:36, Nick Piggin wrote: On Wed, Jul 25, 2007 at 10:10:07PM -0400, Chris Mason wrote: On Thu, 26 Jul 2007 03:37:28 +0200 Nick Piggin <[EMAIL PROTECTED]> wrote: One advantage to the state tree is that it separates the state from the memory being described, allowing a sim