[PATCH] FS: file name should be unique in the same dir in procfs

2007-08-16 Thread Zhang Rui
Files name should be unique in the same directory. Bug is reported here: http://bugzilla.kernel.org/show_bug.cgi?id=8798 Signed-off-by: Zhang Rui <[EMAIL PROTECTED]> --- fs/proc/generic.c |8 1 file changed, 8 insertions(+) Index: linux-2.6.23-rc3/fs/proc/generic.c ===

Re: Adding a security parameter to VFS functions

2007-08-16 Thread Andreas Gruenbacher
On Wednesday 15 August 2007 18:23, Casey Schaufler wrote: > > Hi Linus, Al, > > > > Would you object greatly to functions like vfs_mkdir() gaining a security > > parameter? > > Could you describe how this compares to the proposal that the > AppArmor developers suggested recently? I expect that we

Re: Adding a security parameter to VFS functions

2007-08-16 Thread Andreas Gruenbacher
On Wednesday 15 August 2007 13:40, David Howells wrote: > > Hi Linus, Al, > > Would you object greatly to functions like vfs_mkdir() gaining a security > parameter? What I'm thinking of is this: > > int vfs_mkdir(struct inode *dir, struct dentry *dentry, int mode, > st

Re: Adding a security parameter to VFS functions

2007-08-16 Thread Linus Torvalds
On Wed, 15 Aug 2007, David Howells wrote: > > Would you object greatly to functions like vfs_mkdir() gaining a security > parameter? What I'm thinking of is this: > > int vfs_mkdir(struct inode *dir, struct dentry *dentry, int mode, > struct security *security) I per

Re: Adding a security parameter to VFS functions

2007-08-16 Thread Al Viro
On Thu, Aug 16, 2007 at 03:57:24PM -0700, Linus Torvalds wrote: > I personally consider this an affront to everythign that is decent. > > Why the *hell* would mkdir() be so magical as to need something like that? > > Make it something sane, like a "struct nameidata" instead, and make it at > lea

Re: Adding a security parameter to VFS functions

2007-08-16 Thread Kyle Moffett
On Aug 16, 2007, at 18:57:24, Linus Torvalds wrote: On Wed, 15 Aug 2007, David Howells wrote: Would you object greatly to functions like vfs_mkdir() gaining a security parameter? What I'm thinking of is this: int vfs_mkdir(struct inode *dir, struct dentry *dentry, int mode, struct security *

[RFC PATCH 0/2] avoid clobbering registers with J_ASSERT macro

2007-08-16 Thread Chris Snook
The J_ASSERT() macro in jbd and jbd2 calls printk() prior to BUG(). While this makes it more convenient to read the assertion failure, it also clobbers registers, which can sometimes make debugging harder, which is clearly not the intended purpose. I recently banged my head on this myself. T

[RFC PATCH 1/2] jbd: avoid clobbering registers with J_ASSERT macro

2007-08-16 Thread Chris Snook
From: Chris Snook <[EMAIL PROTECTED]> Don't printk before BUG in J_ASSERT unless CONFIG_JBD_DEBUG is set. Signed-off-by: Chris Snook <[EMAIL PROTECTED]> --- linux-2.6.23-rc3-orig/include/linux/jbd.h 2007-07-08 19:32:17.0 -0400 +++ linux-2.6.23-rc3-patch/include/linux/jbd.h 2007-08-1

[RFC PATCH 2/2] jbd2: avoid clobbering registers with J_ASSERT macro

2007-08-16 Thread Chris Snook
From: Chris Snook <[EMAIL PROTECTED]> Don't printk before BUG in J_ASSERT unless CONFIG_JBD2_DEBUG is set. Signed-off-by: Chris Snook <[EMAIL PROTECTED]> --- linux-2.6.23-rc3-orig/include/linux/jbd2.h 2007-08-13 03:14:13.0 -0400 +++ linux-2.6.23-rc3-patch/include/linux/jbd2.h 2007-08-1