On Tue, 25 Sep 2007 16:42:17 -0700
Christoph Lameter <[EMAIL PROTECTED]> wrote:
> +static noinline void vcompound_free(void *addr)
> +{
> + if (in_interrupt()) {
Should be (in_interrupt() || irqs_disabled()) ?
Regards,
-Kame
-
To unsubscribe from this list: send the line "unsubscribe linux-
On Thu, Sep 27, 2007 at 05:28:57PM -0600, Matthew Wilcox wrote:
> On Thu, Sep 27, 2007 at 07:19:27PM -0400, Theodore Tso wrote:
> > Would you accept a patch which causes the deprecated sysfs
> > files/directories to disappear, even if CONFIG_SYS_DEPRECATED is
> > defined, via a boot-time parameter?
On Thu, Sep 27, 2007 at 07:19:27PM -0400, Theodore Tso wrote:
> On Thu, Sep 27, 2007 at 02:34:45PM -0700, Greg KH wrote:
> > Ok, how then should I advertise this better? What can we do better to
> > help userspace programmers out in this regard?
>
> Would you accept a patch which causes the depre
On Monday September 24, [EMAIL PROTECTED] wrote:
> From: Miklos Szeredi <[EMAIL PROTECTED]>
>
> Add a new super block flag, that results in the VFS not checking if
> the current process has enough privileges to do an mknod().
>
> If this flag is set, all mounts for this super block will have the
On Thu, Sep 27, 2007 at 05:28:57PM -0600, Matthew Wilcox wrote:
> On Thu, Sep 27, 2007 at 07:19:27PM -0400, Theodore Tso wrote:
> > Would you accept a patch which causes the deprecated sysfs
> > files/directories to disappear, even if CONFIG_SYS_DEPRECATED is
> > defined, via a boot-time parameter?
On Friday September 14, [EMAIL PROTECTED] wrote:
> This patchset is a medium scale rewrite of the export operations
> interface. The goal is to make the interface less complex, and
> easier to understand from the filesystem side, aswell as preparing
> generic support for exporting of 64bit inode n
On Thu, Sep 27 2007, Theodore Tso wrote:
> On Thu, Sep 27, 2007 at 04:19:12PM +0100, Alan Cox wrote:
> > > Well it's not my call, just seems like a really bad idea to change the
> > > error value. You can't claim full coverage for such testing anyway, it's
> > > one of those things that people will
On Thu, Sep 27, 2007 at 07:19:27PM -0400, Theodore Tso wrote:
> Would you accept a patch which causes the deprecated sysfs
> files/directories to disappear, even if CONFIG_SYS_DEPRECATED is
> defined, via a boot-time parameter?
How about a mount option? That way people can test without a reboot:
On Thu, Sep 27, 2007 at 06:27:48PM -0400, Kyle Moffett wrote:
> On Sep 27, 2007, at 17:34:45, Greg KH wrote:
>> On Thu, Sep 27, 2007 at 02:37:42PM -0400, Theodore Tso wrote:
>>> That fact that sysfs is all laid out in a directory, but for which some
>>> directories/symlinks are OK to use, and some
On Thu, Sep 27, 2007 at 02:34:45PM -0700, Greg KH wrote:
> Ok, how then should I advertise this better? What can we do better to
> help userspace programmers out in this regard?
Would you accept a patch which causes the deprecated sysfs
files/directories to disappear, even if CONFIG_SYS_DEPRECATE
On Sep 27, 2007, at 17:34:45, Greg KH wrote:
On Thu, Sep 27, 2007 at 02:37:42PM -0400, Theodore Tso wrote:
That fact that sysfs is all laid out in a directory, but for which
some directories/symlinks are OK to use, and some are NOT OK to
use --- is why I call the sysfs interface "an open pit"
On Thu, 2007-09-27 at 14:51 -0700, Andrew Morton wrote:
> So your stuff becomes dependent on Nick's stuff, and Nick's stuff is still
> failing on NFS, I think.
It worked today, it turned out to be a UML bug. Real hardware seemed to
work properly, but will test a bit more tomorrow.
-
To unsubscr
On Thu, 27 Sep 2007 14:51:25 -0700
Andrew Morton <[EMAIL PROTECTED]> wrote:
> > Plus, reiserfs seems to compile with that patch I just sent. Sure as
> > heck surprised me.
> >
>
> That'll be because reiserfs-convert-to-new-aops.patch witched reiserfs over
> to ->write_begin() and ->write_end().
On Thu, 27 Sep 2007 14:27:14 -0700
Dave Hansen <[EMAIL PROTECTED]> wrote:
> On Thu, 2007-09-27 at 22:04 +0100, Christoph Hellwig wrote:
> > On Thu, Sep 27, 2007 at 01:53:39PM -0700, Dave Hansen wrote:
> > > -int reiserfs_commit_write(struct file *f, struct page *page,
> > > - uns
On Thu, Sep 27, 2007 at 02:37:42PM -0400, Theodore Tso wrote:
> On Thu, Sep 27, 2007 at 10:59:17AM -0700, Greg KH wrote:
> > Come on now, I'm _very_ tired of this kind of discussion. Please go
> > read the documentation on how to _use_ sysfs from userspace in such a
> > way that you can properly a
On Thu, 2007-09-27 at 22:04 +0100, Christoph Hellwig wrote:
> On Thu, Sep 27, 2007 at 01:53:39PM -0700, Dave Hansen wrote:
> > -int reiserfs_commit_write(struct file *f, struct page *page,
> > - unsigned from, unsigned to);
> > -int reiserfs_prepare_write(struct file *f, struct
On Thu, Sep 27, 2007 at 01:53:39PM -0700, Dave Hansen wrote:
> -int reiserfs_commit_write(struct file *f, struct page *page,
> - unsigned from, unsigned to);
> -int reiserfs_prepare_write(struct file *f, struct page *page,
> -unsigned from, unsigned to)
On Thu, 2007-09-27 at 21:26 +0100, Christoph Hellwig wrote:
>
> Dave will probably find a bandaid to work around this, but the
> right fix is to stop using a file struct here entirely. If you
> look at reiserfs_xattr_set it's not actually used at all except
> for passing it to ->prepare_write and
On Thu, Sep 27, 2007 at 12:48:33PM -0700, Andrew Morton wrote:
> > __fput+0x124/0x1a9
> > fput+0x31/0x35
> > reiserfs_xattr_set+0x291/0x2b0 [reiserfs]
> > user_set+0x4c/0x57 [reiserfs]
> > reiserfs_setxattr+0x81/0xf1 [reiserfs]
> > vfs_setxattr+0x7d/0xfa
> > setxattr+0xb9/0xd1
> > sys_lsetx
On Thu, 2007-09-27 at 12:48 -0700, Andrew Morton wrote:
>
> Hi, Dave!
>
> > It's fully reproducible.
> >
> > /home is mounted with the following options:
> >/dev/mapper/vglinux1-lvhome on /home type reiserfs
> (rw,noatime,nodiratime,user_xattr)
> >
> > This BUG happened with rc8-mm1 too.
>
On Thu, 27 Sep 2007 21:18:55 +0200
Laurent Riffard <[EMAIL PROTECTED]> wrote:
> Le 27.09.2007 11:22, Andrew Morton a écrit :
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/
>
> I've got this BUG a few seconds after I logged in into Gnome desktop :
>
>
Le 27.09.2007 11:22, Andrew Morton a écrit :
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/
I've got this BUG a few seconds after I logged in into Gnome desktop :
[partially hand copied BUG]
BUG: unable to handle kernel NULL pointer dereference at virtu
On Thu, Sep 27, 2007 at 02:37:42PM -0400, Theodore Tso wrote:
> I'm reminded of Rusty's 2003 OLS Keynote, where he points out that
> what's important is not making an interface easy to use, but _hard_
> _to_ _misuse_. That fact that sysfs is all laid out in a directory,
> but for which some direct
On Thu, Sep 27, 2007 at 10:59:17AM -0700, Greg KH wrote:
> Come on now, I'm _very_ tired of this kind of discussion. Please go
> read the documentation on how to _use_ sysfs from userspace in such a
> way that you can properly access these data structures so that no
> breakage occurs.
I've read i
On Thu, 27 Sep 2007, Andrew Morton wrote:
> On Thu, 27 Sep 2007 10:56:09 -0700 (PDT) Davide Libenzi <[EMAIL PROTECTED]>
> wrote:
>
> > Open coded atomic_inc()? Hmm, dunno...
>
> box:/usr/src/25> grep 'atomic_inc.*->i_count' */*.c
> fs/block_dev.c: atomic_inc(&bdev->bd_inode->i_count);
>
On Thu, 27 Sep 2007 10:56:09 -0700 (PDT) Davide Libenzi <[EMAIL PROTECTED]>
wrote:
> Open coded atomic_inc()? Hmm, dunno...
box:/usr/src/25> grep 'atomic_inc.*->i_count' */*.c
fs/block_dev.c: atomic_inc(&bdev->bd_inode->i_count);
fs/block_dev.c: atomic_inc(&bdev->bd_inode
On Thu, Sep 27, 2007 at 10:23:43AM -0700, Andrew Morton wrote:
> On Thu, 27 Sep 2007 11:59:02 -0400 Theodore Tso <[EMAIL PROTECTED]> wrote:
>
> > On Thu, Sep 27, 2007 at 04:19:12PM +0100, Alan Cox wrote:
> > > There are real things to worry about - sysfs, sysfs, sysfs, ... and all
> > > the other
On Thu, 27 Sep 2007, Andrew Morton wrote:
> On Thu, 27 Sep 2007 09:54:47 -0700 (PDT) Davide Libenzi <[EMAIL PROTECTED]>
> wrote:
>
> > On Thu, 27 Sep 2007, Davide Libenzi wrote:
> >
> > > On Wed, 26 Sep 2007, Andrew Morton wrote:
> > >
> > > > On Thu, 27 Sep 2007 10:30:50 +0800 "Yan Zheng" <[E
On Thu, 27 Sep 2007 09:54:47 -0700 (PDT) Davide Libenzi <[EMAIL PROTECTED]>
wrote:
> On Thu, 27 Sep 2007, Davide Libenzi wrote:
>
> > On Wed, 26 Sep 2007, Andrew Morton wrote:
> >
> > > On Thu, 27 Sep 2007 10:30:50 +0800 "Yan Zheng" <[EMAIL PROTECTED]> wrote:
> > >
> > > > Hello,
> > > >
> >
On Thu, 27 Sep 2007 11:59:02 -0400 Theodore Tso <[EMAIL PROTECTED]> wrote:
> On Thu, Sep 27, 2007 at 04:19:12PM +0100, Alan Cox wrote:
> > > Well it's not my call, just seems like a really bad idea to change the
> > > error value. You can't claim full coverage for such testing anyway, it's
> > > o
On Thu, 27 Sep 2007, Davide Libenzi wrote:
> On Wed, 26 Sep 2007, Andrew Morton wrote:
>
> > On Thu, 27 Sep 2007 10:30:50 +0800 "Yan Zheng" <[EMAIL PROTECTED]> wrote:
> >
> > > Hello,
> > >
> > > igrab return NULL on error.
> > >
> > > Signed-off-by: Yan Zheng<[EMAIL PROTECTED]>
> > > ---
> >
On Wed, 26 Sep 2007, Andrew Morton wrote:
> On Thu, 27 Sep 2007 10:30:50 +0800 "Yan Zheng" <[EMAIL PROTECTED]> wrote:
>
> > Hello,
> >
> > igrab return NULL on error.
> >
> > Signed-off-by: Yan Zheng<[EMAIL PROTECTED]>
> > ---
> > diff -ur linux-2.6.23-rc8/fs/anon_inodes.c linux/fs/anon_inodes.
On Thu, Sep 27, 2007 at 04:19:12PM +0100, Alan Cox wrote:
> > Well it's not my call, just seems like a really bad idea to change the
> > error value. You can't claim full coverage for such testing anyway, it's
> > one of those things that people will complain about two releases later
> > saying it
> Well it's not my call, just seems like a really bad idea to change the
> error value. You can't claim full coverage for such testing anyway, it's
> one of those things that people will complain about two releases later
> saying it broke app foo.
Strange since we've spent years changing error val
On Thu, Sep 27 2007, Alan Cox wrote:
> > > Its a change of a specific error return from the wrong error to the right
> > > one, nothing more. Fixing the returned error gives us correct behaviour
> > > according to the standards and other systems.
> >
> > It may still break applications. Waving som
> > Its a change of a specific error return from the wrong error to the right
> > one, nothing more. Fixing the returned error gives us correct behaviour
> > according to the standards and other systems.
>
> It may still break applications. Waving some standard at them if they
> complain is unlike
On Thu, Sep 27 2007, Alan Cox wrote:
> On Thu, 27 Sep 2007 07:01:18 -0700
> Arjan van de Ven <[EMAIL PROTECTED]> wrote:
>
> > On Thu, 27 Sep 2007 14:29:19 +0100
> > Alan Cox <[EMAIL PROTECTED]> wrote:
> >
> > > The early LFS work that Linux uses favours EFBIG in various places.
> > > SuSv3 specif
In message <[EMAIL PROTECTED]>, roel writes:
> Erez Zadok wrote:
>
> > @@ -194,7 +194,7 @@ int check_empty(struct dentry *dentry, struct
> > unionfs_dir_state **namelist)
> >
> > BUG_ON(!S_ISDIR(dentry->d_inode->i_mode));
> >
> > - if ((err = unionfs_partial_lookup(dentry)))
> > + if
On Thu, 27 Sep 2007 07:01:18 -0700
Arjan van de Ven <[EMAIL PROTECTED]> wrote:
> On Thu, 27 Sep 2007 14:29:19 +0100
> Alan Cox <[EMAIL PROTECTED]> wrote:
>
> > The early LFS work that Linux uses favours EFBIG in various places.
> > SuSv3 specifically uses EOVERFLOW for this as noted by Michael (B
On Thu, 27 Sep 2007 14:29:19 +0100
Alan Cox <[EMAIL PROTECTED]> wrote:
> The early LFS work that Linux uses favours EFBIG in various places.
> SuSv3 specifically uses EOVERFLOW for this as noted by Michael (Bug
> 7253)
isn't this an ABI change?
What's the gain for doing this ABI change?
-
To uns
The early LFS work that Linux uses favours EFBIG in various places. SuSv3
specifically uses EOVERFLOW for this as noted by Michael (Bug 7253)
--
[EOVERFLOW]
The named file is a regular file and the size of the file cannot be
represented correctly in an object of type off_t. We should therefor
41 matches
Mail list logo
