Re: remove some of cifs hard to read ifdefs

2008-02-12 Thread Christoph Hellwig
On Tue, Feb 12, 2008 at 03:25:49PM -0600, Steve French wrote: > On Feb 7, 2008 12:25 PM, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > and while I'm at it a lot of the non-DFS additions to cifs aren't quite > > up to standards for kernel code either, lots of useless braces, wierd > > coding styl

Re: BTRFS partition usage...

2008-02-12 Thread Christoph Hellwig
On Tue, Feb 12, 2008 at 03:35:57PM -0800, David Miller wrote: > What XFS does is really unfortunate, let's learn from it's > mistake. I'd rather say what Sun did with their disklabels was rather unfortunate :) But yeah, new filesystem should cater for it's braindamage because it doesn't have any k

Re: [PATCH 4/8][for -mm] mem_notify v6: memory_pressure_notify() caller

2008-02-12 Thread KOSAKI Motohiro
Hi Andrew > > and, It is judged out of trouble at the fllowing situations. > > o memory pressure decrease and stop moves an anonymous page to the > > inactive list. > > o free pages increase than (pages_high+lowmem_reserve)*2. > > This seems rather arbitrary. Why choose this stage in the page

Re: BTRFS partition usage...

2008-02-12 Thread Jeff Garzik
David Miller wrote: From: Chris Mason <[EMAIL PROTECTED]> Date: Tue, 12 Feb 2008 09:08:59 -0500 I've had requests to move the super down to 64k to make room for bootloaders, which may not matter for sparc, but I don't really plan on different locations for different arches. The Sun disk label

Re: BTRFS partition usage...

2008-02-12 Thread Bryan Henderson
> The Sun disk label only allows you to specify the start of a partition > in cylinders, so if you want to use a filesystem like XFS you have to > start the partition on cylinder 1 which can be many blocks into the > disk. That entire first cylinder is completely wasted. I don't believe a cylinde

Re: BTRFS partition usage...

2008-02-12 Thread Rene Herman
On 13-02-08 00:42, Jan Engelhardt wrote: x86 MSDOS partition table layout starts counting with sector 1, which is (not so intuitively) starting at 0x7e00 (and there's no sector 0, probably for safety). Well, each ptable format with its own quirks. I haven't followed this thread, but in case i

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: Jan Engelhardt <[EMAIL PROTECTED]> Date: Wed, 13 Feb 2008 00:42:56 +0100 (CET) > > On Feb 12 2008 15:38, David Miller wrote: > > > >> I still don't like the idea of btrfs trying to be smarter than a user > >> who can partition up his system according to > >>(a) his likes > >>(b) sys

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: Jan Engelhardt <[EMAIL PROTECTED]> Date: Wed, 13 Feb 2008 00:39:16 +0100 (CET) > On the other hand, the H and S of CHS could be lowered and S increased, > e.g. divide H by 2, divide S by 2, multiply S by 4. This gives a finer > bytes/cylinder granularity. That's really not an option when yo

Re: BTRFS partition usage...

2008-02-12 Thread Theodore Tso
On Tue, Feb 12, 2008 at 03:28:26PM -0800, David Miller wrote: > From: Jan Engelhardt <[EMAIL PROTECTED]> > Date: Tue, 12 Feb 2008 15:00:20 +0100 (CET) > > > Something looks wrong here. Why would btrfs need to zero at all? > > So that existing superblocks on the partition won't > be interpreted as

Re: BTRFS partition usage...

2008-02-12 Thread Jan Engelhardt
On Feb 12 2008 15:38, David Miller wrote: > >> I still don't like the idea of btrfs trying to be smarter than a user >> who can partition up his system according to >> (a) his likes >> (b) system or hardware requirements or recommendations >> to align the superblock to a specific locatio

Re: BTRFS partition usage...

2008-02-12 Thread Jan Engelhardt
On Feb 12 2008 15:26, David Miller wrote: > >> (Yes, I had xfs on sparc before, so it's not like you NEED the >> whitespace at the start of a partition.) > >You actully do unless you want to lose significant chunks of your disk >space. > >The Sun disk label only allows you to specify the start of

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: Jan Engelhardt <[EMAIL PROTECTED]> Date: Tue, 12 Feb 2008 16:04:52 +0100 (CET) > I still don't like the idea of btrfs trying to be smarter than a user > who can partition up his system according to > (a) his likes > (b) system or hardware requirements or recommendations > to alig

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: Chris Mason <[EMAIL PROTECTED]> Date: Tue, 12 Feb 2008 09:35:20 -0500 > From my point of view, 0 is a bad idea because it is very likely to > conflict with other things. Starting at 0 is a bad idea because otherwise you'll waste significant chunks of your disk on Sparc because of reasons I'

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: Jan Engelhardt <[EMAIL PROTECTED]> Date: Tue, 12 Feb 2008 15:21:52 +0100 (CET) > For sparc you could have something like > > startlbaendlba type > sda10 2 1 Boot > sda22 58 3 Whole disk

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: Chris Mason <[EMAIL PROTECTED]> Date: Tue, 12 Feb 2008 09:08:59 -0500 > I've had requests to move the super down to 64k to make room for > bootloaders, which may not matter for sparc, but I don't really plan > on different locations for different arches. The Sun disk label sits in the first

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: Jan Engelhardt <[EMAIL PROTECTED]> Date: Tue, 12 Feb 2008 15:00:20 +0100 (CET) > Something looks wrong here. Why would btrfs need to zero at all? So that existing superblocks on the partition won't be interpreted as correct by other filesystems. It's a safety measure many mkfs programs use

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: Jan Engelhardt <[EMAIL PROTECTED]> Date: Tue, 12 Feb 2008 15:00:20 +0100 (CET) > (Yes, I had xfs on sparc before, so it's not like you NEED the > whitespace at the start of a partition.) You actully do unless you want to lose significant chunks of your disk space. The Sun disk label only

Re: [PATCH 4/8][for -mm] mem_notify v6: memory_pressure_notify() caller

2008-02-12 Thread Andrew Morton
On Sun, 10 Feb 2008 00:24:28 +0900 "KOSAKI Motohiro" <[EMAIL PROTECTED]> wrote: > the notification point to happen whenever the VM moves an > anonymous page to the inactive list - this is a pretty good indication > that there are unused anonymous pages present which will be very likely > swapped o

Re: BTRFS only works with PAGE_SIZE <= 4K

2008-02-12 Thread Chris Mason
On Tuesday 12 February 2008, David Miller wrote: > From: Chris Mason <[EMAIL PROTECTED]> > Date: Wed, 6 Feb 2008 12:00:13 -0500 > > > So, here's v0.12. > > Any page size larger than 4K will not work with btrfs. All of the > extent stuff assumes that PAGE_SIZE <= sectorsize. Yeah, there is definit

BTRFS only works with PAGE_SIZE <= 4K

2008-02-12 Thread David Miller
From: Chris Mason <[EMAIL PROTECTED]> Date: Wed, 6 Feb 2008 12:00:13 -0500 > So, here's v0.12. Any page size larger than 4K will not work with btrfs. All of the extent stuff assumes that PAGE_SIZE <= sectorsize. I confirmed this by forcing mkfs.btrfs to use an 8K sectorsize on sparc64 and I was

remove some of cifs hard to read ifdefs

2008-02-12 Thread Steve French
On Feb 7, 2008 12:25 PM, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > and while I'm at it a lot of the non-DFS additions to cifs aren't quite > up to standards for kernel code either, lots of useless braces, wierd > coding style and ifdef mania. The useless braces should be removed now. The "ifd

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: Chris Mason <[EMAIL PROTECTED]> Date: Tue, 12 Feb 2008 08:49:34 -0500 > So, if Btrfs starts zeroing at 1k, will that be acceptable for you? Sure. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: i_version changes

2008-02-12 Thread J. Bruce Fields
On Sun, Feb 10, 2008 at 08:30:41AM +0100, Christoph Hellwig wrote: > I think the i_version changes that hit mainline about a week ago are > not as nice as they should be. > > First there's a complete lack of documentation on this, which is very > bad. Please document what the new semantics for i_

Re: BTRFS partition usage...

2008-02-12 Thread Chris Mason
On Tuesday 12 February 2008, Jan Engelhardt wrote: > On Feb 12 2008 09:35, Chris Mason wrote: > >> and slap the bootloader into "MBR", just like on x86. > >> Or I am missing something.. > > > >It was a request from hpa, and he clearly had something in mind. He > > kindly offered to review the disk

Re: BTRFS partition usage...

2008-02-12 Thread Jan Engelhardt
> On Feb 12 2008 09:35, Chris Mason wrote: >> >> and slap the bootloader into "MBR", just like on x86. >> Or I am missing something.. > >It was a request from hpa, and he clearly had something in mind. He kindly >offered to review the disk format for bootloaders and other lower level >issues but

Re: BTRFS partition usage...

2008-02-12 Thread Chris Mason
On Tuesday 12 February 2008, Jan Engelhardt wrote: > On Feb 12 2008 09:08, Chris Mason wrote: > >> >So, if Btrfs starts zeroing at 1k, will that be acceptable for you? > >> > >> Something looks wrong here. Why would btrfs need to zero at all? > >> Superblock at 0, and done. Just like xfs. > >> (Yes

Re: BTRFS partition usage...

2008-02-12 Thread Jan Engelhardt
On Feb 12 2008 09:08, Chris Mason wrote: >> > >> >So, if Btrfs starts zeroing at 1k, will that be acceptable for you? >> >> Something looks wrong here. Why would btrfs need to zero at all? >> Superblock at 0, and done. Just like xfs. >> (Yes, I had xfs on sparc before, so it's not like you NEED th

Re: BTRFS partition usage...

2008-02-12 Thread Chris Mason
On Tuesday 12 February 2008, Jan Engelhardt wrote: > On Feb 12 2008 08:49, Chris Mason wrote: > >> > This is a real issue on sparc where the default sun disk labels > >> > created use an initial partition where block zero aliases the disk > >> > label. It took me a few iterations before I figured

Re: BTRFS partition usage...

2008-02-12 Thread Jan Engelhardt
On Feb 12 2008 08:49, Chris Mason wrote: >> > >> > This is a real issue on sparc where the default sun disk labels >> > created use an initial partition where block zero aliases the disk >> > label. It took me a few iterations before I figured out why every >> > btrfs make would zero out my disk

Re: BTRFS partition usage...

2008-02-12 Thread Chris Mason
On Tuesday 12 February 2008, David Miller wrote: > From: David Miller <[EMAIL PROTECTED]> > Date: Mon, 11 Feb 2008 23:21:39 -0800 (PST) > > > Filesystems like ext2 put their superblock 1 block into the partition > > in order to avoid overwriting disk labels and other uglies. UFS does > > this too,

Re: [ANNOUNCE] Btrfs v0.12 released

2008-02-12 Thread Chris Mason
On Tuesday 12 February 2008, David Miller wrote: > From: Chris Mason <[EMAIL PROTECTED]> > Date: Mon, 11 Feb 2008 08:42:20 -0500 > > > The kernel is actually worse, because the set/get macros are more > > complex. Some live in ctree.h like in the progs, but the nasty ones live > > in struct-funcs.c

CRC32C big endian bugs...

2008-02-12 Thread David Miller
The CRC32C implementation in the btrfs progs is different from the one in the kernel, so obviously nothing can possibly work on big-endian. This is getting less and less fun by the minute, I simply wanted to test btrfs on Niagara :-/ Here is a patch to fix that: --- vanilla/btrfs-progs-0.12/crc

Re: Question about do_sync_read()

2008-02-12 Thread Benny Halevy
On Feb. 09, 2008, 10:52 +0200, "Manish Katiyar" <[EMAIL PROTECTED]> wrote: > Hi, > > In the implementation of file systems for 2.6 kernels, > generic_file_read is often replaced with do_sync_read(). In this > function we call "filp->f_op->aio_read" unconditionally. > where most of the times aio_re

Re: BTRFS partition usage...

2008-02-12 Thread David Miller
From: David Miller <[EMAIL PROTECTED]> Date: Mon, 11 Feb 2008 23:21:39 -0800 (PST) > Filesystems like ext2 put their superblock 1 block into the partition > in order to avoid overwriting disk labels and other uglies. UFS does > this too, as do several others. One of the few exceptions I've been