Re: unionfs_copy_attr_times oopses

In message <[EMAIL PROTECTED]>, Hugh Dickins writes: > Hi Erez, > > Aside from the occasional "unionfs: new lower inode mtime" messages > on directories (which I've got into the habit of ignoring now), the > only problem I'm still suffering with unionfs over tmpfs (not tested > any other fs's bel

[PATCH 14/17] Unionfs: stop using iget() and read_inode()

From: David Howells <[EMAIL PROTECTED]> Replace unionfs_read_inode() with unionfs_iget(), and call that instead of iget(). unionfs_iget() then uses iget_locked() directly and returns a proper error code instead of an inode in the event of an error. unionfs_fill_super() returns any error incurred

[PATCH 11/17] Unionfs: lock parents' branch configuration fixes

Ensure that we lock the branch configuration of parent and child dentries in operations which need it, and in the right order. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c | 31 +--- fs/unionfs/dentry.c | 26 +--- fs/unionfs

[PATCH 06/17] Unionfs: extend dentry branch configuration lock in open

Dentry branch configuration "info node" lock should extend to calls to copy_attr_times. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.

[PATCH 15/17] Unionfs: embed a struct path into struct nameidata instead of nd dentrymnt

From: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/inode.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 2e791fd..

[PATCH 05/17] Unionfs: initialize path_save variable

This is not strictly necessary, but it helps quiet a gcc-4.2 warning (a good optimizer may optimize this initialization away). Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> Signed-off-by: Josef 'Jeff' Sipek <[EMAIL PROTECTED]> --- fs/unionfs/inode.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 08/17] Unionfs: improve debugging in copy_attr_times

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/subr.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/subr.c b/fs/unionfs/subr.c index 68a6280..1a40f63 100644 --- a/fs/unionfs/subr.c +++ b/fs/unionfs/subr.c @@ -247,8 +247,14 @@ void unionfs_

[PATCH 13/17] Unionfs: use dget_parent in revalidation code

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/dentry.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index a956b94..f8f65e1 100644 --- a/fs/unionfs/dentry.c +++ b/fs/unionfs/dentry.c @@ -410,15 +410,10

[PATCH 12/17] Unionfs: branch management/configuration fixes

Remove unnecessary calls to update branch m/ctimes, and use them only when needed. Update branch vfsmounts after operations that could cause a copyup. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c |9 +++-- fs/unionfs/copyup.c |3 ++- fs/unionfs/dentry

[PATCH 10/17] Unionfs: factor out revalidation routine

To be used by rest of revalidation code, as well a callers who already locked the child and parent dentry branch-configurations. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/dentry.c | 87 +++--- fs/unionfs/union.h |3 ++ 2 files

[PATCH 17/17] VFS/Unionfs: use generic path_get/path_put functions

Remove unionfs's versions thereof. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/main.c | 10 +- fs/unionfs/super.c| 27 ++- include/linux/namei.h | 12 3 files changed, 19 insertions(+), 30 deletions(-) diff --git a/fs/un

[PATCH 16/17] Unionfs: use the new path_put

From: Jan Blunck <[EMAIL PROTECTED]> * Add path_put() functions for releasing a reference to the dentry and vfsmount of a struct path in the right order * Switch from path_release(nd) to path_put(&nd->path) * Rename dput_path() to path_put_conditional() Signed-off-by: Jan Blunck <[EMAIL PROTE

[PATCH 04/17] Unionfs: uninline unionfs_copy_attr_times and unionfs_copy_attr_all

This reduces text size by about 6k. Cc: Hugh Dickins <[EMAIL PROTECTED]> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/fanout.h | 50 -- fs/unionfs/subr.c | 50 ++ fs/unionfs/unio

[PATCH 02/17] Unionfs: ensure consistent lower inodes types

When looking up a lower object in multiple branches, especially for directories, ignore any existing entries whose type is different than the type of the first found object (otherwise we'll be trying to, say, call readdir on a non-dir inode). Signed-off-by: Himanshu Kanda <[EMAIL PROTECTED]> Signe

[PATCH 07/17] Unionfs: follow_link locking fixes

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/inode.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 8d939dc..6377533 100644 --- a/fs/unionfs/inode.c +++ b/fs/unionfs/inode.c @@ -820,7 +820,11 @@ static voi

[PATCH 09/17] Unionfs: revalidation code cleanup and refactoring

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/dentry.c | 55 -- 1 files changed, 35 insertions(+), 20 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index cd15243..afa2120 100644 --- a/fs/unionfs/dentry.c +++ b/

[PATCH 01/17] Unionfs: grab lower super_block references

This prevents the lower super_block from being destroyed too early, when a lower file system is being unmounted with MNT_FORCE or MNT_DETACH. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/main.c |3 +++ fs/unionfs/super.c | 14 ++ fs/unionfs/union.h |2 +- 3

[PATCH 03/17] Unionfs: document behavior when the lower topology changes

Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- Documentation/filesystems/unionfs/concepts.txt | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/Documentation/filesystems/unionfs/concepts.txt b/Documentation/filesystems/unionfs/concepts.txt index bed69bd..8d9

[GIT PULL -mm] 00/17 Unionfs updates/fixes/cleanups

The following is a series of patchsets related to Unionfs. The most significant changes are several fixes to races/locking. This release also supports newer APIs in 2.6.25-rc: not using iget/read_inode, using the changed d_path, using the revised nameidata which embeds a struct path, and using p

Re: jffs2 console printk storm

On Thu, 2008-02-14 at 17:16 -0500, Erez Zadok wrote: > Hi David, > > This has been a problem I've seen for a while. I've generated a jffs2 image > of an empty directory (I don't recall the version of the jffs2 utils I've > used to generate it). I mount the jffs2 image something like this: > >

Re: Re[2]: [linux-cifs-client] review 5, was Re: projected date for mount.cifs to support DFS junction points

On Sat, Feb 16, 2008 at 11:51:52AM +0300, Q wrote: > At first glance cifs_get_inode_info_remote won't work cause it's old dfs > code not new one. But I caught what Christoph meant now, and will try to > rewrite it this way. Yes, this was supposed to be a refactoring of the existing code. By doing

Re: [RFC] ext3 freeze feature

On Fri, Feb 15, 2008 at 08:51:15PM +0900, Takashi Sato wrote: > So XFS_IOC_FREEZE and XFS_IOC_THAW cannot be lifted to generic code simply. > I think we should create new generic numbers for freeze and thaw Actually we've lifted specific ioctls to the generic layer before all the time in drivers.

Re[2]: [linux-cifs-client] review 5, was Re: projected date for mount.cifs to support DFS junction points

-Original Message- From: "Steve French" <[EMAIL PROTECTED]> To: "Christoph Hellwig" <[EMAIL PROTECTED]> Date: Fri, 15 Feb 2008 15:02:19 -0600 Subject: Re: [linux-cifs-client] review 5, was Re: projected date for mount.cifs to support DFS junction points > > On 2/15/08, Christoph Hellwi