On Fri, 8 Feb 2008 16:12:28 -0500
"J. Bruce Fields" <[EMAIL PROTECTED]> wrote:
> On Fri, Feb 08, 2008 at 03:54:14PM -0500, Jeff Layton wrote:
> > Interesting. It's not clear me why the underlying filesystem would make
> > any difference there. Though now
On Fri, 8 Feb 2008 13:49:01 -0500 (EST)
"david m. richter" <[EMAIL PROTECTED]> wrote:
> On Fri, 8 Feb 2008, J. Bruce Fields wrote:
>
> > On Fri, Feb 08, 2008 at 07:15:02AM -0500, Jeff Layton wrote:
> > > On Thu, 7 Feb 2008 18:26:18 -0500
> > &g
e finally reproduced this problem here, and David's working on
> debugging. It does indeed seem to only be reproduceable with client and
> server on the same machine. Thanks for the report
>
> --b.
It might be worth testing this both with and without the patchset I
poste
to only call filemap_write_and_wait for
ATTR_SIZE changes.
4) makes cifs_writepages accurately distinguish between EIO and ENOSPC
errors when writing out pages.
Some simple testing indicates that the patch works as expected and that
it fixes the reproducer for the known problem.
Signed-of
f just req->rq_rlen, since that should represent the
amount of unread data in the response.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
Acked-by: Guenter Kukkukk <[EMAIL PROTECTED]>
---
fs/smbfs/sock.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a
much like the patch I sent to the list on Oct 16. At the
time I think you emailed JRA to ask why we were setting the sticky bit
but I don't believe he ever replied.
AFAICT, the sticky bit on a regular file doesn't mean anything on
Linux. Having it set is harmless, but I could see probl
f just req->rq_rlen, since that should represent the
amount of unread data in the response.
I think this is correct, but an ACK or NACK from someone more familiar
with this code would be appreciated...
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/smbfs/sock.c |5 ++---
1 files
Fix some warnings with SMBFS_DEBUG_* builds. This patch makes it so
that builds with -Werror don't fail.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/smbfs/file.c |7 ---
fs/smbfs/inode.c |2 +-
fs/smbfs/proc.c |2 +-
fs/smbfs/smbiod.c |2 +-
4 files
reiserfs_setattr can call notify_change recursively using the same
iattr struct. This could cause it to trip the BUG() in notify_change.
Fix reiserfs to clear those bits near the beginning of the function.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/reiserfs/inode.c |6 +++
If the ATTR_KILL_S*ID bits are set then any mode change is only for
clearing the setuid/setgid bits. For NFS, skip the mode change and
let the server handle it.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/nfs/inode.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
If the ATTR_KILL_S*ID bits are set then any mode change is only for
clearing the setuid/setgid bits. For CIFS, skip the mode change and
let the server handle it.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/cifs/inode.c |5 +
1 files changed, 5 insertions(+), 0 del
Don't allow unionfs_setattr to trip the BUG() in notify_change. Clear
ATTR_MODE if the either ATTR_KILL_S*ID is set. This also allows the
lower filesystem to interpret these bits in its own way.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/unionfs/inode.c |7 +++
1 fi
t the mode
change was only for the purposes of clearing these bits.
This means that we now have an implicit assumption that notify_change is
never called with ATTR_MODE and either ATTR_KILL_S*ID bit set. Nothing
currently enforces that, so this patch also adds a BUG() if that occurs.
Signed-off-by: J
Make sure ecryptfs doesn't trip the BUG() in notify_change. This also
allows the lower filesystem to interpret ATTR_KILL_S*ID in its own way.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/ecryptfs/inode.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff
It's theoretically possible for a single SETATTR call to come in that
sets the mode and the uid/gid. In that case, don't set the ATTR_KILL_S*ID
bits since that would trip the BUG() in notify_change. Just fix up the
mode to have the same effect.
Signed-off-by: Jeff Layton <[EM
et is being submitted for inclusion into -mm.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 17 Sep 2007 07:29:05 -0400
Jeff Layton <[EMAIL PROTECTED]> wrote:
> This patchset is the latest one for fixing the clearing of setuid/setgid
> bits in networked filesystems. It should apply cleanly to 2.6.23-rc4-mm1.
> This is basically the same patchset as take 5. The m
It's theoretically possible for a single SETATTR call to come in that
sets the mode and the uid/gid. In that case, don't set the ATTR_KILL_S*ID
bits since that would trip the BUG() in notify_change. Just fix up the
mode to have the same effect.
Signed-off-by: Jeff Layton <[EM
t the mode
change was only for the purposes of clearing these bits.
This means that we now have an implicit assumption that notify_change is
never called with ATTR_MODE and either ATTR_KILL_S*ID bit set. Nothing
currently enforces that, so this patch also adds a BUG() if that occurs.
Signed-off-by: J
If the ATTR_KILL_S*ID bits are set then any mode change is only for
clearing the setuid/setgid bits. For CIFS, skip the mode change and
let the server handle it.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/cifs/inode.c |5 +
1 files changed, 5 insertions(+), 0 del
If the ATTR_KILL_S*ID bits are set then any mode change is only for
clearing the setuid/setgid bits. For NFS, skip the mode change and
let the server handle it.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/nfs/inode.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
reiserfs_setattr can call notify_change recursively using the same
iattr struct. This could cause it to trip the BUG() in notify_change.
Fix reiserfs to clear those bits near the beginning of the function.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/reiserfs/inode.c |6 +++
TTR_KILL_S*ID. Just fix up the mode to have the same effect. Also, move
locking the i_mutex to lower in the function. It's not needed until it
checks the i_size.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/unionfs/inode.c | 10 ++
1 files changed, 6 insertions(+),
the comment in notify_change is now a bit more descriptive. I've also
moved the description of the main rationale for the patch into patch 5.
Andrew, would it be possible to go ahead and get this committed to -mm?
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
-
To unsubscribe from this
This patch makes sure ecryptfs doesn't trip the BUG() in notify_change.
It also allows the lower filesystem to interpret ATTR_KILL_S*ID in its
own way.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/ecryptfs/inode.c |8
1 files changed, 8 insertions(+), 0 deletio
On Sat, 15 Sep 2007 01:43:45 +1000
Greg Banks <[EMAIL PROTECTED]> wrote:
> On Fri, Sep 14, 2007 at 10:58:38AM -0400, Jeff Layton wrote:
> > On Sat, 15 Sep 2007 00:40:33 +1000
> > Greg Banks <[EMAIL PROTECTED]> wrote:
> >
> >
> > > Ok, you convin
On Sat, 15 Sep 2007 00:40:33 +1000
Greg Banks <[EMAIL PROTECTED]> wrote:
> On Fri, Sep 14, 2007 at 09:38:46AM -0400, Jeff Layton wrote:
> > On Fri, 14 Sep 2007 23:09:24 +1000
> > Greg Banks <[EMAIL PROTECTED]> wrote:
> >
> > > On Fri, Sep 14, 2
On Fri, 14 Sep 2007 23:09:24 +1000
Greg Banks <[EMAIL PROTECTED]> wrote:
> On Fri, Sep 14, 2007 at 07:02:58AM -0400, Jeff Layton wrote:
> > On Fri, 14 Sep 2007 20:25:45 +1000
> > Greg Banks <[EMAIL PROTECTED]> wrote:
> >
> > > I'm curious abo
On Fri, 14 Sep 2007 20:25:45 +1000
Greg Banks <[EMAIL PROTECTED]> wrote:
> On Tue, Sep 04, 2007 at 10:37:04AM -0400, Jeff Layton wrote:
> > If the ATTR_KILL_S*ID bits are set then any mode change is only for
> > clearing the setuid/setgid bits. For NFS skip the mode change a
When making a directory with POSIX mkdir calls, cifs_mkdir does not
respect the umask. This moves the AND'ing of the mode with the umask
to higher in the function so that the POSIX mkdir creates with the
correct mode.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/cifs/ino
If the ATTR_KILL_S*ID bits are set then any mode change is only for
clearing the setuid/setgid bits. For CIFS, skip the mode change and
let the server handle it.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/cifs/inode.c |5 +
1 files changed, 5 insertions(+), 0 del
If the ATTR_KILL_S*ID bits are set then any mode change is only for
clearing the setuid/setgid bits. For NFS skip the mode change and
let the server handle it.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/nfs/inode.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
both ATTR_MODE
and either of the ATTR_KILL_S*ID bits set, since the filesystem would
have no way to know what part of the mode change was intentional. If
it is called this way, consider it a BUG().
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/attr.c | 26 ---
he i_mutex to lower in the function. It's not needed until it
checks the i_size.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/unionfs/inode.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c
index 59bb418.
It's theoretically possible for a single SETATTR call to come in that
sets the mode and the uid/gid. In that case, assume the mode is
correct and don't set the ATTR_KILL_S*ID bits. Doing so would trip the
BUG() in notify_change.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
--
reiserfs_setattr can call notify_change recursively using the same
iattr struct. This could cause it to trip the BUG() in notify_change.
Fix reiserfs to clear those bits near the beginning of the function.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/reiserfs/inode.c |6 +++
Make sure ecryptfs doesn't trip the BUG() in notify_change. This also
allows the lower filesystem to interpret these bits in their own way.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/ecryptfs/inode.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff
as take 5. The only differences are that
the patches have been reordered to make the tree cleanly bisectable,
and the comment in notify_change is now a bit more descriptive.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux
he i_mutex to lower in the function. It's not needed until it
checks the i_size.
(Jeff Sipek indicated that he was planning to change some of this code,
so this patch may need changes if it goes in after his patchset)
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/unionfs/inode.c
reiserfs_setattr can call notify_change recursively using the same
iattr struct. This could cause it to trip the BUG() in notify_change.
Fix reiserfs to clear those bits near the beginning of the function.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/reiserfs/inode.c |6 +++
It's theoretically possible for a single SETATTR call to come in that
sets the mode and the uid/gid. In that case, assume the mode is
correct and don't set the ATTR_KILL_S*ID bits. Doing so would trip the
BUG() in notify_change.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
--
Make sure ecryptfs doesn't trip the BUG() in notify_change. This also
allows the lower filesystem to interpret these bits in their own way.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/ecryptfs/inode.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff
If the ATTR_KILL_S*ID bits are set then any mode change is only for
clearing the setuid/setgid bits. For NFS, skip the mode change and
let the server handle it.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/cifs/inode.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
both ATTR_MODE
and either of the ATTR_KILL_S*ID bits set, since the filesystem would
have no way to know what part of the mode change was intentional. If
it is called this way, consider it a BUG().
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/attr.c | 23 +--
1
If the ATTR_KILL_S*ID bits are set then any mode change is only for
clearing the setuid/setgid bits. For NFS skip the mode change and
let the server handle it.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/nfs/inode.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
is is
basically the same patchset as take 4 with a few extra patches to
fix up the callers of notify_change, and some minor parenthetical
cleanups.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
other two patches in the set fix up NFS and CIFS to ignore
the mode change if either ATTR_KILL_S*ID bit is set.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
Mo
both ATTR_MODE
and either of the ATTR_KILL_S*ID bits set, since the filesystem would
have no way to know what part of the mode change was intentional. If
it is called this way, consider it a BUG().
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/attr.c | 22 --
1
| S_IXGRP)) {
> > if (!(ia_valid & ATTR_MODE)) {
> > ia_valid = attr->ia_valid |= ATTR_MODE;
> > attr->ia_mode = inode->i_mode;
> > }
> > attr->ia_mode &= ~S_
..make it just clear the ATTR_KILL_S*ID bits since we want the
server to handle it.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/cifs/cifsfs.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
index cabb6a5..c
This updates the VFS docs under the Documentation/ directory to describe
the new killattr inode operation.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
Documentation/filesystems/Locking |2 ++
Documentation/filesystems/vfs.txt |6 ++
2 files changed, 8 insertions
Add the nfs_killattr inode operation. For NFS, we generally want the server
to handle clearing these bits. So the function is really just a noop.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/nfs/dir.c |3 +++
fs/nfs/file.c |2 ++
fs/nfs/inode.c
ined.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/attr.c | 33 -
include/linux/fs.h |1 +
2 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/fs/attr.c b/fs/attr.c
index ae58bd3..77608d3 100644
--- a/fs/attr.c
+++ b/fs
d
suggestions appreciated...
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 21 Aug 2007 17:21:28 -0400
Josef Sipek <[EMAIL PROTECTED]> wrote:
> On Tue, Aug 21, 2007 at 07:35:51AM -0400, Jeff Layton wrote:
> > On Tue, 21 Aug 2007 15:35:08 +1000
> > Timothy Shimmin <[EMAIL PROTECTED]> wrote:
> >
> > > Jeff Layton
On Tue, 21 Aug 2007 15:35:08 +1000
Timothy Shimmin <[EMAIL PROTECTED]> wrote:
> Jeff Layton wrote:
> > This should fix all of the filesystems in the mainline kernels to handle
> > ATTR_KILL_SUID and ATTR_KILL_SGID correctly. For most of them, this is
> > just a matt
This should fix all of the filesystems in the mainline kernels to handle
ATTR_KILL_SUID and ATTR_KILL_SGID correctly. For most of them, this is
just a matter of making sure that they call generic_attrkill early in
the setattr inode op.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
ld help us to catch filesystems that
don't handle these bits correctly without breaking them outright.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/attr.c | 91 ---
include/linux/fs.h |1 +
2 files changed, 72 ins
broken out individually
again if needed.
Comments and suggestions appreciated. Also, please let me know if
I've missed any filesystems that need to be converted...
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-fsd
This is the only filesystem in -mm but not in mainline that seems to
be affected by this change...
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/reiser4/plugin/inode_ops.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/reiser4/plugin/inode_ops.c b/fs/r
notify_change doesn't try to do a second setattr. NFS already clears
these bits, and this just updates a comment to make it clear
that doing this is more than an optimization.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/cifs/inode.c |5 +
fs/nfs/inode.c |6 +-
2 fi
On Mon, 13 Aug 2007 08:01:34 -0400
Jeff Layton <[EMAIL PROTECTED]> wrote:
> On Sat, 11 Aug 2007 03:57:39 +0100
> Christoph Hellwig <[EMAIL PROTECTED]> wrote:
> >
> > I like the idea of checking ia_valid after return a lot. But instead of
> > going BUG()
convert to the "new" scheme,
so they can avoid this second setattr call.
If this idea seems sound then I'll start the grunt work to fix up the
in-tree filesystems so that they don't need the second setattr call.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
commit 52
ange a setuid/setgid
file on these filesystems. Still, it should conceivably catch most if
not all offenders. Would that be sufficient to take care of everyone's
concerns?
--
Jeff Layton <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-fsd
On Wed, 8 Aug 2007 22:05:13 +0200 (CEST)
Jan Engelhardt <[EMAIL PROTECTED]> wrote:
>
> On Aug 8 2007 09:48, Andrew Morton wrote:
> >> > On Mon, 6 Aug 2007 09:54:03 -0400
> >> > Jeff Layton <[EMAIL PROTECTED]> wrote:
> >> >
> >>
On Tue, 7 Aug 2007 17:15:01 -0700
Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Mon, 6 Aug 2007 09:54:03 -0400
> Jeff Layton <[EMAIL PROTECTED]> wrote:
>
> > Apologies for the resend, but the original sending had the date in the
> > email header and
gestions. I'll plan to incorporate them in the next
respin of the set.
Thanks,
--
Jeff Layton <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
a little easier if you
> really care.)
Thanks. I debated about how best to split these up. A coworker
mentioned that Andrew had tossed him back a single patch that
touched several mainline filesystems and asked him to break it
up. I took that to mean that the patches should generally be split
out,
this up later.
As Trond said, in-tree filesystems will be converted so they won't
be an issue. The only danger is someone who is running unconverted
out-of-tree filesystem code on a kernel with this patch. Is that enough
of an issue to warrant us taking extra steps to deal with it?
An
ill break out-of-tree fs, so a separate flag is
> probably better.
>
In the past I've been told that adding new flags is something of a
"last resort". Since it's not strictly necessary to fix this then
it may be best to avoid that.
That said, if the concensus is that we nee
ses that to decide whether to return early, and to pass
a (hopefully) appropriate bitmask to fsnotify_change.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/attr.c | 54 +--
include/linux/fs.h |1 +
2 files changed, 36 i
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/affs/inode.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/affs/inode.c b/fs/affs/inode.c
index 4609a6c..1fa2937 100644
--- a/fs/affs/inode.c
+++ b/fs/affs/inode.c
@@ -218,6 +218,7 @@ affs_notify_change(
Not sure if this is necessary or desirable for AFS, but adding it for
consistency.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/afs/inode.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fs/afs/inode.c b/fs/afs/inode.c
index d196840..d0ad5e6 100644
--
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/9p/vfs_inode.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
index e5c45ee..00fcd4e 100644
--- a/fs/9p/vfs_inode.c
+++ b/fs/9p/vfs_inode.c
@@ -756,6 +756,7 @@ stat
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
mm/shmem.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index fcd19d3..d3b5421 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -719,6 +719,8 @@ static int shmem_notify_change(struct dentry *
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/spufs/inode.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/platforms/cell/spufs/inode.c
b/arch/powerpc/platforms/cell/spufs/inode.c
index b3d0dd1..d0f6b62 100644
---
..and only save off ia_valid after it returns
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/xfs/linux-2.6/xfs_iops.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c
index 0b5fa12..67fba53 100644
..and only save off ia_valid after it returns
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/ufs/truncate.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/fs/ufs/truncate.c b/fs/ufs/truncate.c
index 79c54c8..193679b 100644
--- a/fs/ufs/truncate.c
+++ b/
..and only save off ia_valid after it returns
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/sysfs/inode.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c
index 10d1b52..38f2ba9 100644
--- a/fs/sysfs/inode.c
+++ b/fs
..seems unlikely that the sb mode would include a setuid bit, but I suppose
it's possible.
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/smbfs/inode.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/smbfs/inode.c b/fs/smbfs/inode.c
index 73d14
..and only set old_ia_valid after it returns
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/ramfs/file-nommu.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/fs/ramfs/file-nommu.c b/fs/ramfs/file-nommu.c
index cad2b7a..c354883 100644
--- a/fs/ramf
..and only save off ia_valid after it returns
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/reiserfs/inode.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c
index ddde489..55b2aea 100644
--- a/fs/reiserfs/i
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/ocfs2/file.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index c4034f6..d05d472 100644
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -972,6 +972,8 @@ int ocfs2_setattr(
Not sure if this is really needed, but I don't think it will hurt anything
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/proc/base.c|3 +++
fs/proc/generic.c |3 +++
fs/proc/proc_sysctl.c |3 +++
3 files changed, 9 insertions(+), 0 deletions(-)
diff
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/jfs/acl.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/jfs/acl.c b/fs/jfs/acl.c
index 4d84bdc..34ca314 100644
--- a/fs/jfs/acl.c
+++ b/fs/jfs/acl.c
@@ -227,6 +227,8 @@ int jfs_setattr(struct dentry *
..and only set ia_valid just before it's actually used
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/configfs/inode.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/configfs/inode.c b/fs/configfs/inode.c
index ddc003a..a67f36b 100644
--- a/
..and only set ia_valid after it returns
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/hugetlbfs/inode.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index c848a19..3566abb 100644
--- a/fs/hugetlbfs/inode.c
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/jffs2/fs.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/jffs2/fs.c b/fs/jffs2/fs.c
index 1d3b7a9..5218f04 100644
--- a/fs/jffs2/fs.c
+++ b/fs/jffs2/fs.c
@@ -37,6 +37,7 @@ static int jffs2_do_setattr (
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/hostfs/hostfs_kern.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c
index c778620..ea75204 100644
--- a/fs/hostfs/hostfs_kern.c
+++ b/fs/hostfs/hostfs_
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/hpfs/inode.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/hpfs/inode.c b/fs/hpfs/inode.c
index 85d3e1d..d2b26eb 100644
--- a/fs/hpfs/inode.c
+++ b/fs/hpfs/inode.c
@@ -265,6 +265,7 @@ int hpfs_notify_
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/gfs2/ops_inode.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c
index 911c115..8401fc7 100644
--- a/fs/gfs2/ops_inode.c
+++ b/fs/gfs2/ops_inode.c
@@ -994,6 +994,8 @@
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/fuse/dir.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index bd5a772..60c8d5e 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -1016,6 +1016,8 @@ static int fuse_setattr(
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/coda/inode.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/coda/inode.c b/fs/coda/inode.c
index 342f4e0..c06d031 100644
--- a/fs/coda/inode.c
+++ b/fs/coda/inode.c
@@ -239,6 +239,7 @@ int coda_setattr(
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/cifs/inode.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index dd41677..6fee1fa 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
@@ -1429,6 +1429,8 @@ int cifs_setattr(
know if there are others who should be informed.
Comments and suggestions appreciated...
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [EMAIL PROTECTED]
More majordomo
.. and only save off ia_valid once it returns
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/ext2/inode.c |1 +
fs/ext3/inode.c |5 -
fs/ext4/inode.c |5 -
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
index 0
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/jffs2/fs.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/jffs2/fs.c b/fs/jffs2/fs.c
index 1d3b7a9..5218f04 100644
--- a/fs/jffs2/fs.c
+++ b/fs/jffs2/fs.c
@@ -37,6 +37,7 @@ static int jffs2_do_setattr (
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/ocfs2/file.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index c4034f6..d05d472 100644
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -972,6 +972,8 @@ int ocfs2_setattr(
vative approach and call
the helper when I wasn't sure. I've tried to CC the maintainers
for the individual filesystems as well where I could find them,
please let me know if there are others who should be informed.
Comments and suggestions appreciated...
Signed-off-by: Jeff Layton
Signed-off-by: Jeff Layton <[EMAIL PROTECTED]>
---
fs/jfs/acl.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/jfs/acl.c b/fs/jfs/acl.c
index 4d84bdc..34ca314 100644
--- a/fs/jfs/acl.c
+++ b/fs/jfs/acl.c
@@ -227,6 +227,8 @@ int jfs_setattr(struct dentry *
1 - 100 of 203 matches
Mail list logo
