Re: [13/17] Virtual compound page freeing in interrupt context

2007-09-28 Thread KAMEZAWA Hiroyuki
On Fri, 28 Sep 2007 10:35:44 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Fri, 28 Sep 2007, KAMEZAWA Hiroyuki wrote: > > > On Tue, 25 Sep 2007 16:42:17 -0700 > > Christoph Lameter <[EMAIL PROTECTED]> wrote: > > > > > +s

Re: [13/17] Virtual compound page freeing in interrupt context

2007-09-27 Thread KAMEZAWA Hiroyuki
On Tue, 25 Sep 2007 16:42:17 -0700 Christoph Lameter <[EMAIL PROTECTED]> wrote: > +static noinline void vcompound_free(void *addr) > +{ > + if (in_interrupt()) { Should be (in_interrupt() || irqs_disabled()) ? Regards, -Kame - To unsubscribe from this list: send the line "unsubscribe linux-

Re: [05/17] vunmap: return page array

2007-09-19 Thread KAMEZAWA Hiroyuki
On Wed, 19 Sep 2007 15:15:58 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Wed, 19 Sep 2007, KAMEZAWA Hiroyuki wrote: > > > Hmm, I don't like returning array which someone allocated in past and > > forgot. > > But that is exactly the point. Th

Re: [05/17] vunmap: return page array

2007-09-19 Thread KAMEZAWA Hiroyuki
On Tue, 18 Sep 2007 20:36:10 -0700 Christoph Lameter <[EMAIL PROTECTED]> wrote: > Make vunmap return the page array that was used at vmap. This is useful > if one has no structures to track the page array but simply stores the > virtual address somewhere. The disposition of the page array can be >

Re: [RFC 14/26] SLUB: __GFP_MOVABLE and SLAB_TEMPORARY support

2007-08-31 Thread KAMEZAWA Hiroyuki
On Fri, 31 Aug 2007 18:41:21 -0700 Christoph Lameter <[EMAIL PROTECTED]> wrote: > +#ifndef CONFIG_HIGHMEM > + if (s->kick || s->flags & SLAB_TEMPORARY) > + flags |= __GFP_MOVABLE; > +#endif > + Should I do this as #if !defined(CONFIG_HIGHMEM) && !defined(CONFIG_MEMORY_HOTREMOVE)