Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-26 Thread Miklos Szeredi
is not really needed. Just require ->set_page_dirty() be filled in by filesystems which want swapfiles (and others too, in the longer term, the fallback is just historical crud). Here's an incremental patch addressing these issues and beautifying t

Re: [patch 00/10] mount ownership and unprivileged mount syscall (v8)

2008-02-23 Thread Miklos Szeredi
> On Sat, Feb 23, 2008 at 06:33:13PM +0100, Miklos Szeredi wrote: > > > c) just what is limited by that sysctl? AFAICS, rbind is allowed > > > if mountpoint is on user vfsmount and it seems to create vfsmounts without > > > eating into that limit just fine... Wh

Re: [patch 00/10] mount ownership and unprivileged mount syscall (v8)

2008-02-23 Thread Miklos Szeredi
> On Mon, Feb 18, 2008 at 12:47:59PM +0100, Miklos Szeredi wrote: > > So what should I do? > > > > Would Al be wanting to merge this into his VFS tree? (Can't find it > > on git.kernel.org yet, BTW.) > > FWIW, it's on hera right now, should propagat

[rfc patch] how to show propagation state for mounts

2008-02-22 Thread Miklos Szeredi
nt --make-slave /mnt1 old ns: mount --make-slave /mnt2 mount --bind /mnt1/tmp /mnt1/tmp new ns: mount --make-shared /mnt1/tmp mount --bind /mnt1/tmp /mnt2/tmp Voila. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/pnode.c ===

Re: how to show propagation state for mounts

2008-02-20 Thread Miklos Szeredi
the things out as much as possible > without leaking 3rd-party information to either. This sounds fine. I'll have a look at implementing a stable peer group ID (it doesn't need a separate object, I realized that now). Miklos - To unsubscribe from this list: send the line &quo

Re: how to show propagation state for mounts

2008-02-20 Thread Miklos Szeredi
> On Wed, Feb 20, 2008 at 04:39:15PM +0100, Miklos Szeredi wrote: > > > mountinfo - IMO needs a sane discussion of what and how should be shown > > > wrt propagation state > > > > Here's my take on the matter. > > > > The propagation tree can b

how to show propagation state for mounts

2008-02-20 Thread Miklos Szeredi
a fixed id for each peer group would mean introducing a new object to anchor the peer group into, which would add complexity to the whole thing. All of these are implementable, just need to decide which one we want. Miklos - To unsubscribe from this list: send the line "unsubscribe linux-fs

Re: NFS/LSM: allow NFS to control all of its own mount options

2008-02-20 Thread Miklos Szeredi
x27;s mount options in /proc/mounts. Well, actually there's no infrastructure for it either. Here's a template patch (completely untested). Selinux guys, please fill in the details and submit, thanks. Signed-off-by: Miklos Szeredi <[EMAIL PROTE

git tree with VFS stuff

2008-02-19 Thread Miklos Szeredi
I've created a git tree with the following mounts related stuff: - read-only bind mounts - /proc//mountinfo - unprivileged mounts git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfsstuff.git master I guess, giving these a spin in linux-next wouldn't hurt? Thanks, Mik

Re: [patch 00/10] mount ownership and unprivileged mount syscall (v8)

2008-02-18 Thread Miklos Szeredi
I do? Would Al be wanting to merge this into his VFS tree? (Can't find it on git.kernel.org yet, BTW.) I can set up a git tree for these patches if that makes things easier. Or should I just wait and resubmit after every kernel release, hoping that it becomes _the_ most important thing on Ch

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Miklos Szeredi
> On Thu, Feb 14, 2008 at 9:31 AM, Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > > > I deliberately not used the MS_* flags, which is currently a messy mix > > of things with totally different meanings. > > > > Does this solve all the issues? > >

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Miklos Szeredi
> On Thu, 2008-02-14 at 18:39 +0100, Miklos Szeredi wrote: > > > > And I'm not against doing it with the "at*" variants, as Trond > > > > suggested. > > > > > > If you're going to change the syscall, then you should ensure th

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Miklos Szeredi
d); return mount_foo(tmpbuf, ...); } Or is there something (other than not requiring proc) that the *at variant gives? Miklos - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Miklos Szeredi
topath, struct mount_param *param); int mount_setflagsat(int fd, const char *path, struct mount_param *param); int mount_moveat(int fromfd, const char *frompath, int tofd, const char *topath); ... I deliberately not used the MS_* flags, which is curr

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Miklos Szeredi
> On Thu, Feb 14, 2008 at 12:30 AM, Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > > For recursive bind mounts, only the root of the tree being bound > > > inherits the per-mount flags from the mount() arguments; sub-mounts > > > inherit their per-mount

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Miklos Szeredi
just set the read-only flag and leave the others alone. And this is where we usually conclude, that a new userspace mount API is long overdue. So for starters, how about a new syscall for bind mounts: int mount_bind(const char *src, const char *dst, unsigned flags, unsigned

Re: [patch 01/26] mount options: add documentation

2008-02-08 Thread Miklos Szeredi
ync, but hey, we seem to be able to live with that). However, once you start using multiple namespaces, the daemon based solution quickly becomes unusable, because you would need a separate daemon for each namespace, and it would have to somehow keep track of mount propagations in userspace (which is

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-02-07 Thread Miklos Szeredi
> On Tue, Feb 05, 2008 at 10:36:23PM +0100, Miklos Szeredi wrote: > > From: Miklos Szeredi <[EMAIL PROTECTED]> > > > > Add the following: > > > > /proc/sys/fs/types/${FS_TYPE}/usermount_safe > > > > > There is /proc/fs// already. Si

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-02-07 Thread Miklos Szeredi
DMIN rather than CAP_SYS_ADMIN? I guess so. I'm not very familiar with the different capabilities :) How about this patch then: a hybrid solution between just relying on permission bits, and specifying separate capability sets for read and write in addition to the permission bi

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-02-07 Thread Miklos Szeredi
nd not something else, then the permission check would not need to look at uids or gids at all. Miklos - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-02-06 Thread Miklos Szeredi
ds. I think that would make a lot of sense anyway. Thanks, Miklos - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch 07/10] unprivileged mounts: add sysctl tunable for "safe" property

2008-02-05 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add the following: /proc/sys/fs/types/${FS_TYPE}/usermount_safe Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/filesystems.c === --- linux.orig/fs/f

[patch 09/10] unprivileged mounts: propagation: inherit owner from parent

2008-02-05 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> On mount propagation, let the owner of the clone be inherited from the parent into which it has been propagated. If the parent has the "nosuid" flag, set this flag for the child as well. This is needed for the suid-less namespace (us

[patch 01/10] unprivileged mounts: add user mounts to the kernel

2008-02-05 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> This patchset adds support for keeping mount ownership information in the kernel, and allow unprivileged mount(2) and umount(2) in certain cases. The mount owner has the following privileges: - unmount the owned mount - create a submount und

[patch 06/10] unprivileged mounts: allow unprivileged mounts

2008-02-05 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> For "safe" filesystems allow unprivileged mounting and forced unmounting. A filesystem type is considered "safe", if mounting it by an unprivileged user may not cause a security problem. This is somewhat subjective, so settin

[patch 10/10] unprivileged mounts: add "no submounts" flag

2008-02-05 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add a new mount flag "nosubmnt", which denies submounts for the owner. This would be useful, if we want to support traditional /etc/fstab based user mounts. In this case mount(8) would still have to be suid-root, to check the mountpoint

[patch 03/10] unprivileged mounts: propagate error values from clone_mnt

2008-02-05 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Allow clone_mnt() to return errors other than ENOMEM. This will be used for returning a different error value when the number of user mounts goes over the limit. Fix copy_tree() to return EPERM for unbindable mounts. Signed-off-by: Miklos S

[patch 00/10] mount ownership and unprivileged mount syscall (v8)

2008-02-05 Thread Miklos Szeredi
Just documentation updates, compared to the previous submission. Thanks to Serge for the relentless reviews :) Please consider for -mm, and then for 2.6.26. Thanks, Miklos v7 -> v8 - extend documentation of allow_usermount sysctl tunable - describe new unprivileged mounting in fuse.txt

[patch 08/10] unprivileged mounts: make fuse safe

2008-02-05 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Don't require the "user_id=" and "group_id=" options for unprivileged mounts, but if they are present, verify them for sanity. Disallow the "allow_other" option for unprivileged mounts. Document new way of enablin

[patch 04/10] unprivileged mounts: account user mounts

2008-02-05 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add sysctl variables for accounting and limiting the number of user mounts. The maximum number of user mounts is set to 1024 by default. This won't in itself enable user mounts, setting a mount to be owned by a user is first needed. [akpm]

[patch 05/10] unprivileged mounts: allow unprivileged bind mounts

2008-02-05 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Allow bind mounts to unprivileged users if the following conditions are met: - mountpoint is not a symlink - parent mount is owned by the user - the number of user mounts is below the maximum Unprivileged mounts imply MS_SETUSER, and will als

[patch 02/10] unprivileged mounts: allow unprivileged umount

2008-02-05 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> The owner doesn't need sysadmin capabilities to call umount(). Similar behavior as umount(8) on mounts having "user=UID" option in /etc/mtab. The difference is that umount also checks /etc/fstab, presumably to exclude another mount o

Re: [patch 0/3] add perform_write to a_ops

2008-02-04 Thread Miklos Szeredi
ing up to higher layers might not be possible, due to lock/unlock of i_mutex being inside generic_file_aio_write(). But with fuse being the only user, it's not a huge issue duplicating some code. Nick, were there any other candidates, that would want to use such an interface in the fut

Re: [PATCH 2/3] enhanced syscall ESTALE error handling (v2)

2008-02-04 Thread Miklos Szeredi
up till now, returning ESTALE in a fuse filesystem was a perfectly valid thing to do. This patch changes the behavior of that rather drastically. There might be installed systems that rely on current behavior, and we want to avoid breaking those on a kernel upgrade." Miklos - To

Re: [PATCH 2/3] enhanced syscall ESTALE error handling (v2)

2008-02-04 Thread Miklos Szeredi
backward compatibility problems. > Do you have anything more specific about any real problems? > I see lots of "mays" and "coulds", but I don't see anything > that I can do to make this support better. Implement the above suggestion? Or something else. Otherwi

[patch 0/3] add perform_write to a_ops

2008-02-04 Thread Miklos Szeredi
t improvement. This allows larger than 4k buffered writes for fuse, which is one of the most requested features. This goes on top of the "fuse: writable mmap" patches. Thanks, Miklos -- - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a

[patch 3/3] fuse: implement perform_write

2008-02-04 Thread Miklos Szeredi
: Nick Piggin <[EMAIL PROTECTED]> Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/fuse/file.c === --- linux.orig/fs/fuse/file.c 2008-02-04 17:11:18.0 +0100 +++ linux/fs/fuse/file.c

[patch 1/3] vfs: introduce perform_write in a_ops

2008-02-04 Thread Miklos Szeredi
ecache. For some filesystems, using this can provide significant speedups. Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/include/linux/fs.h === --- linux.

[patch 2/3] fuse: clean up setting i_size in write

2008-02-04 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Extract common code for setting i_size in write functions into a common helper. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/fuse/file.c === --- linux.

[patch 2/3] mm: Add NR_WRITEBACK_TEMP counter

2008-02-04 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Fuse will use temporary buffers to write back dirty data from memory mappings (normal writes are done synchronously). This is needed, because there cannot be any guarantee about the time in which a write will complete. By using temporary buffers

[patch 1/3] mm: bdi: export bdi_writeout_inc()

2008-02-04 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Fuse needs this for writable mmap support. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/include/linux/backing-dev.h === --- linux.orig/include/linux/b

[patch 3/3] fuse: support writable mmap

2008-02-04 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Quoting Linus (3 years ago, FUSE inclusion discussions): "User-space filesystems are hard to get right. I'd claim that they are almost impossible, unless you limit them somehow (shared writable mappings are the nastiest part - i

[patch 0/3] fuse: writable mmap

2008-02-04 Thread Miklos Szeredi
that depends on whether the bdi things go). Thanks, Miklos -- - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH] vfs: optimization to /proc//mountinfo patch

2008-02-04 Thread Miklos Szeredi
"\0", 1); > + if (!IS_ROOT(dentry) && d_unhashed(dentry) && > + prepend(&end, &buflen, " (deleted)", 10)) And this should test for "prepend() != 0" or "prepend() < 0" instead, otherwise it could easily be

[patch 0/3] mm: bdi: updates

2008-02-02 Thread Miklos Szeredi
also done some testing, and fixed some bugs. Including patches in -mm can do wonders, even before the kernel containing them is released :) Let me know if you prefer a resubmission of the original series with these changes folded in. Thanks, Miklos -- - To unsubscribe from this list: send the li

[patch 3/3] mm: bdi: move statistics to debugfs

2008-02-02 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Move BDI statistics to debugfs: /sys/kernel/debug/bdi//stats Use postcore_initcall() to initialize the sysfs class and debugfs, because debugfs is initialized in core_initcall(). Update descriptions in ABI documentation. Signed-off-by:

[patch 1/3] mm: bdi: fix read_ahead_kb_store()

2008-02-02 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> This managed to completely evade testing :( Fix return value to be count or -errno. Also bring the function in line with the other store functions on this object, which have more strict input checking. Also fix bdi_set_max_ratio() to actually ret

[patch 2/3] mm: bdi: use MAJOR:MINOR in /sys/class/bdi

2008-02-02 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Uniformly use MAJOR:MINOR in /sys/class/bdi/ for both block devices and non-block device backed filesystems: FUSE and NFS. Add symlink for block devices: /sys/block//bdi -> /sys/class/bdi/ Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]

Re: [PATCH 2/3] enhanced syscall ESTALE error handling (v2)

2008-02-02 Thread Miklos Szeredi
lly. There might be installed systems that rely on current behavior, and we want to avoid breaking those on a kernel upgrade. A few solutions come to mind, perhaps the best is to introduce a kernel internal errno value (ERETRYSTALE), that forces the relevant system calls to be retried. NFS cou

Re: [PATCH 2/3] enhanced syscall ESTALE error handling (v2)

2008-02-01 Thread Miklos Szeredi
E, this > > goes into an infinite loop. How are we planning to deal with that? > > > > > > Would you describe the situation that would cause the kernel to > go into an infinite loop, please? The patch basically does: do { ... er

Re: [PATCH 2/3] enhanced syscall ESTALE error handling (v2)

2008-02-01 Thread Miklos Szeredi
lesystems. We can't just say, fix the broken servers, especially not with FUSE, where the server is totally untrusted. Miklos - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 01/26] mount options: add documentation

2008-01-31 Thread Miklos Szeredi
;m=119362955431694&w=2 > > So, with this patch mount(8) needn't to maintain info about loops and > umount(8) doesn't need to call LOOP_CLR_FD ioctl, because umount(2) > is enough. Excellent! This is a very good example how moving a functionality into the kernel can grea

Re: [patch 6/6] mm: bdi: allow setting a maximum for the bdi dirty limit

2008-01-31 Thread Miklos Szeredi
> On Tue, 29 Jan 2008 16:49:06 +0100 > Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > > Add "max_ratio" to /sys/class/bdi. This indicates the maximum > > percentage of the global dirty threshold allocated to this bdi. > > Maybe I'm having a stu

Re: [patch 2/6] mm: bdi: export BDI attributes in sysfs

2008-01-31 Thread Miklos Szeredi
> On Tue, 29 Jan 2008 16:49:02 +0100 > Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > > From: Peter Zijlstra <[EMAIL PROTECTED]> > > > > Provide a place in sysfs (/sys/class/bdi) for the backing_dev_info > > object. This allows us to see a

Re: [patch] vfs: create /proc//mountinfo

2008-01-31 Thread Miklos Szeredi
t I think this is implicit in all of the multi-fields-per-line formats, and I'm quite confident all sane parsers already ignore unknown junk at the end of a line. > > > > > [EMAIL PROTECTED] > > > > - new file, rearrange fields > > - for mount ID's u

Re: [patch 01/26] mount options: add documentation

2008-01-30 Thread Miklos Szeredi
leged mounts patches do contain a simple form of access control. I don't think anything more is needed, but of course, having unprivileged mounts in the kernel does not prevent the use of a more sophisticated access control daemon in userspace, if that becomes necessary. Miklos - To unsubsc

Re: [patch 0/6] mm: bdi: updates

2008-01-29 Thread Miklos Szeredi
> On Tue, 2008-01-29 at 16:49 +0100, Miklos Szeredi wrote: > > This is a series from Peter Zijlstra, with various updates by me. The > > patchset mostly deals with exporting BDI attributes in sysfs. > > > > Should be in a mergeable state, at least into -mm. >

[patch 2/3] fuse: save space in struct fuse_req

2008-01-29 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Move the fields 'dentry' and 'vfsmount' into the request specific union, since these are only used for the RELEASE request. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]>

[patch 3/3] fuse: limit queued background requests

2008-01-29 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Libfuse basically creates a new thread for each new request. This is fine for synchronous requests, which are naturally limited. However background requests (especially writepage) can cause a thread creation storm. To avoid this, limit the num

[patch 0/3] fuse: update for 2.6.25

2008-01-29 Thread Miklos Szeredi
Here's one small fix, one cleanup and one in preparation for writable mmap support (but which makes sense on it's own as well). Please apply. Thanks, Miklos -- - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTE

[patch 1/3] fuse: fix attribute caching after create

2008-01-29 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Invalidate attributes on create, since st_ctime is updated. Reported by Szabolcs Szakacsits Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/f

[patch 3/6] mm: bdi: expose the BDI object in sysfs for NFS

2008-01-29 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Register NFS' backing_dev_info under sysfs with the name "nfs-MAJOR:MINOR" Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> CC: Peter Zijlstra <[EMAIL PROTECTED]> CC: Trond Myklebust <[EMAIL PROTECTE

[patch 1/6] mm: bdi: tweak task dirty penalty

2008-01-29 Thread Miklos Szeredi
gt; Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/mm/page-writeback.c === --- linux.orig/mm/page-writeback.c 2008-01-17 19:00:56.0 +0100 +++ linux/mm/page-writeback.c 2008-01-18 13:07:16.0 +

[patch 6/6] mm: bdi: allow setting a maximum for the bdi dirty limit

2008-01-29 Thread Miklos Szeredi
i_dirty with bdi->max_ratio - document new sysfs attribute Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/include/linux/backing-dev.h === --- linux.o

[patch 5/6] mm: bdi: allow setting a minimum for the bdi dirty limit

2008-01-29 Thread Miklos Szeredi
Zijlstra <[EMAIL PROTECTED]> Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/include/linux/backing-dev.h === --- linux.orig/include/linux/backing-dev.h 2008-01-29 14:40:35.0 +0100 +++ linux

[patch 2/6] mm: bdi: export BDI attributes in sysfs

2008-01-29 Thread Miklos Szeredi
#x27;t be initialized - remove bdi_init_fmt macro, it's not used very much Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> CC: Kay Sievers <[EMAIL PROTECTED]> CC: Greg KH <[EMAIL PROTECTED]> CC: Trond Myklebust <[EMAIL PROTECTED]> Signed-off-by: Miklos Szeredi &

[patch 4/6] mm: bdi: expose the BDI object in sysfs for FUSE

2008-01-29 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Register FUSE's backing_dev_info under sysfs with the name "fuse-MAJOR:MINOR" Make the fuse control filesystem use s_dev instead of a fuse specific ID. This makes it easier to match directories under /sys/fs/fuse/connections/ with d

[patch 0/6] mm: bdi: updates

2008-01-29 Thread Miklos Szeredi
This is a series from Peter Zijlstra, with various updates by me. The patchset mostly deals with exporting BDI attributes in sysfs. Should be in a mergeable state, at least into -mm. -- - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL

[patch] vfs: create /proc//mountinfo

2008-01-29 Thread Miklos Szeredi
ugs - remove inlines - style fixes Signed-off-by: Ram Pai <[EMAIL PROTECTED]> Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/dcache.c === --- linux.orig/fs/dcache.c 2008-01-28 14:54:19.000

Re: [patch 24/26] mount options: fix tmpfs

2008-01-28 Thread Miklos Szeredi
> > Thanks Miklos, that's a welcome enhancement, nicely done. I've only > noticed one thing wrong (MPOL_PREFERRED shown as "default"); but thought > shmem_config didn't add much value - I'd rather avoid those syntactic > changes to unchanged code; and

Re: [patch 00/26] mount options: fix filesystem's ->show_options

2008-01-28 Thread Miklos Szeredi
> > On Thu, 24 Jan 2008 20:33:41 +0100 Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > Andrew, > > > > Would you please consider these patches for -mm? > > Sure, but I'm too lazy to pick through them and work out which ones need > updating, which ones

Re: [patch 21/26] mount options: partially fix nfs

2008-01-28 Thread Miklos Szeredi
ption parser. > > Let me know your preference. You are more familiar with NFS, so I think it would be better if you updated nfs_show_mount_options(). Could you also queue my patch (updated) or incorporate it into a combined fix? Thanks, Miklos Subject: mount options: partially fix nf

Re: [patch 25/26] mount options: fix udf

2008-01-25 Thread Miklos Szeredi
> On Fri 25-01-08 16:50:15, Miklos Szeredi wrote: > > > > > | + /* is this correct? */ > > > > > | + if (sbi->s_anchor[2] != 0) > > > > > | + seq_printf(seq, ",anchor=%u", sbi->s_anchor[2]); > > > > > &

Re: [patch 25/26] mount options: fix udf

2008-01-25 Thread Miklos Szeredi
it, because it's a very useful and good type. We are just not very much used to it yet, but don't tell me it's confusing to see a type like this ;) Miklos - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 25/26] mount options: fix udf

2008-01-25 Thread Miklos Szeredi
ption matter? This is actually a somewhat philosophical question about what the mount options in /proc/mounts mean: 1) Options _given_ by the user for the mount 2) Options which are _effective_ for the mount If we take interpretation 2) and there was no anchor (whatever that means), then the anch

Re: [patch 01/26] mount options: add documentation

2008-01-25 Thread Miklos Szeredi
e save_mount_options(). Especially, since unionfs implemets a remount, that changes the tree only partially AFAICS. Miklos - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 26/26] mount options: fix usbfs

2008-01-25 Thread Miklos Szeredi
> > From: Miklos Szeredi <[EMAIL PROTECTED]> > > > > Add a .show_options super operation to usbfs. > > > > Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> > > Looks good to me. Do you want to take this through your tree, as it is > dependa

Re: [patch 21/26] mount options: partially fix nfs

2008-01-25 Thread Miklos Szeredi
> On Thu, 2008-01-24 at 20:34 +0100, Miklos Szeredi wrote: > > plain text document attachment (nfs_opts.patch) > > From: Miklos Szeredi <[EMAIL PROTECTED]> > > > > Add posix, bsize=, namelen= options to /proc/mounts for nfs > > filesystems. > > >

Re: [patch 21/26] mount options: partially fix nfs

2008-01-25 Thread Miklos Szeredi
> Miklos Szeredi wrote: > > From: Miklos Szeredi <[EMAIL PROTECTED]> > > > > Add posix, bsize=, namelen= options to /proc/mounts for nfs > > filesystems. > > > > Document several other options that are still missing. > > NFS lists onl

Re: [patch 25/26] mount options: fix udf

2008-01-25 Thread Miklos Szeredi
decision (i'm not the expert in this area ;) I think UDF_SB_ANCHOR macro was removed by some patch in -mm. I'm more interested if the second element of the s_anchor array really does always have the value of the 'anchor=N' mount option. I haven't been able to verify th

Re: [patch 10/26] mount options: fix devpts

2008-01-25 Thread Miklos Szeredi
Yeah, it's a matter of taste. I'll update the patch. Actually, a lot of filesystems share the options 'uid=X', 'gid=X', 'mode=X' (or 'umask=X'). This could be handled by the VFS, saving some code, and making things more consistent. One day mayb

[patch 17/26] mount options: fix hugetlbfs

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add a .show_options super operation to hugetlbfs. Use generic_show_options() and save the complete option string in hugetlbfs_fill_super(). Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/huget

[patch 20/26] mount options: fix ncpfs

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add a .show_options super operation to ncpfs. Small fix: add FS_BINARY_MOUNTDATA to the filesystem type flags, since it can take binary data, as well as text (similarly to NFS). Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: li

[patch 19/26] mount options: fix jfs

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add iocharset= and errors= options to /proc/mounts for jfs filesystems. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/jfs/super.c === --- linux.orig/fs

[patch 26/26] mount options: fix usbfs

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add a .show_options super operation to usbfs. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/drivers/usb/core/inode.c === --- linux.orig/drivers/usb/core/ino

[patch 22/26] mount options: fix reiserfs

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add a .show_options super operation to reiserfs. Use generic_show_options() and save the complete option string in reiserfs_fill_super() and reiserfs_remount(). Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/reis

[patch 25/26] mount options: fix udf

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add a .show_options super operation to udf. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/udf/super.c === --- linux.orig/fs/udf/super.c 2008

[patch 24/26] mount options: fix tmpfs

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add .show_options super operation to tmpfs. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/mm/shmem.c === --- linux.orig/mm/shmem.c 2008-01-21 21:20:

[patch 23/26] mount options: fix spufs

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add a .show_options super operation to spufs. Use generic_show_options() and save the complete option string in spufs_fill_super(). Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/arch/powerpc/platforms/cell/s

[patch 07/26] mount options: fix autofs

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add a .show_options super operation to autofs. Use generic_show_options() and save the complete option string in autofs_fill_super(). Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/au

[patch 18/26] mount options: fix isofs

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add a .show_options super operation to isofs. Use generic_show_options() and save the complete option string in isofs_fill_super(). Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/i

[patch 21/26] mount options: partially fix nfs

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add posix, bsize=, namelen= options to /proc/mounts for nfs filesystems. Document several other options that are still missing. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs

[patch 15/26] mount options: fix hostfs

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add the "host path" option to /proc/mounts for UML hostfs filesystems. The mount source (mnt_devname) should really be used for this, but not easy to change now in a backward compatible way. Signed-off-by: Miklos Szeredi <[EMAIL PRO

[patch 16/26] mount options: fix hpfs

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add a .show_options super operation to hpfs. Use generic_show_options() and save the complete option string in hpfs_fill_super() and hpfs_remount_fs(). Also add a small fix: hpfs_remount_fs() should return -EINVAL on error, instead of 1, which is

[patch 13/26] mount options: fix fat

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add flush option to /proc/mounts for msdos and vfat filesystems. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/fat/inode.c === --- linux.orig/fs/fat/inode

[patch 14/26] mount options: fix fuse

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add blksize= option to /proc/mounts for fuseblk filesystems. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/fuse/inode.c === --- linux.orig/fs/fuse/inode.c

[patch 12/26] mount options: fix ext4

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add stripe= option to /proc/mounts for ext4 filesystems. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/ext4/super.c === --- linux.orig/fs/ext4/super.c 2

[patch 01/26] mount options: add documentation

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> This series addresses the problem of showing mount options in /proc/mounts. Several filesystems which use mount options, have not implemented a .show_options superblock operation. Several others have implemented this callback, but have not kept it

[patch 10/26] mount options: fix devpts

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add a .show_options super operation to devpts. Also add minor fix: when parsing the "mode" option, mask with S_IALLUGO instead of ~S_IFMT, which could leave unsed bits in the mask. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]>

[patch 11/26] mount options: fix ext2

2008-01-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Add noreservation option to /proc/mounts for ext2 filesystems. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/ext2/super.c === --- linux.orig/fs/ext2/supe

  1   2   3   4   5   6   >