On Mon, 9 Jul 2007 22:00:03 +0200
Jörn Engel <[EMAIL PROTECTED]> wrote:
> On Mon, 9 July 2007 22:01:48 +0400, Alexey Dobriyan wrote:
> >
> > Yes. Note that ext2_clear_inode() is referenced from ext2_sops, so even
> > empty, it leaves traces in resulting kernel.
>
> Is that your opinion or have y
On Mon, 9 July 2007 17:02:20 -0500, Dave Kleikamp wrote:
>
> It's not a direct call to a static function. It is called as a
> super_ops method. I don't think the overhead is very significant, but
> it doesn't look like it could do any harm.
Ah, I missed that fact. Yep, looks fine to me.
Jörn
On Mon, 2007-07-09 at 22:00 +0200, Jörn Engel wrote:
> On Mon, 9 July 2007 22:01:48 +0400, Alexey Dobriyan wrote:
> >
> > Yes. Note that ext2_clear_inode() is referenced from ext2_sops, so even
> > empty, it leaves traces in resulting kernel.
>
> Is that your opinion or have you actually measured
On Mon, 9 July 2007 22:01:48 +0400, Alexey Dobriyan wrote:
>
> Yes. Note that ext2_clear_inode() is referenced from ext2_sops, so even
> empty, it leaves traces in resulting kernel.
Is that your opinion or have you actually measured a difference?
I strongly suspect that compilers are smart enough
On Mon, Jul 09, 2007 at 10:34:32AM +0200, Jörn Engel wrote:
> On Mon, 9 July 2007 08:11:22 +0400, Alexey Dobriyan wrote:
> >
> > If CONFIG_EXT2_FS_POSIX_ACL is not configured, ext2_clear_inode() will be
> > empty
> > function. However, there still will be call and immediate return which can
> >
On Mon, 9 July 2007 08:11:22 +0400, Alexey Dobriyan wrote:
>
> If CONFIG_EXT2_FS_POSIX_ACL is not configured, ext2_clear_inode() will be
> empty
> function. However, there still will be call and immediate return which can be
> avoided.
> [...]
> +#ifdef CONFIG_EXT2_FS_POSIX_ACL
> static void ext
If CONFIG_EXT2_FS_POSIX_ACL is not configured, ext2_clear_inode() will be empty
function. However, there still will be call and immediate return which can be
avoided.
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>
---
fs/ext2/super.c |6 --
1 file changed, 4 insertions(+), 2 deletion
