Re: [PATCH] Make BH_Unwritten a first class bufferhead flag

2007-01-09 Thread Christoph Hellwig
On Tue, Jan 09, 2007 at 10:57:45AM +1100, David Chinner wrote: On Mon, Jan 08, 2007 at 10:54:02PM +, Christoph Hellwig wrote: this doesn't look like a full first class flag to me yet. Don't we need to check for buffer_unwritten in the places we're checking for buffer_delay so we can

[PATCH] Make BH_Unwritten a first class bufferhead flag

2007-01-08 Thread David Chinner
Currently, XFS uses BH_PrivateStart for flagging unwritten extent state in a bufferhead. Recently, i found the long standing mmap/unwritten extent conversion bug, and it was to do with partial page invalidation not clearing the unwritten flag from bufferheads attached to the page but beyond EOF.

Re: [PATCH] Make BH_Unwritten a first class bufferhead flag

2007-01-08 Thread Christoph Hellwig
this doesn't look like a full first class flag to me yet. Don't we need to check for buffer_unwritten in the places we're checking for buffer_delay so we can stop setting buffer_delay for unwritten buffers? - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a

Re: [PATCH] Make BH_Unwritten a first class bufferhead flag

2007-01-08 Thread David Chinner
On Mon, Jan 08, 2007 at 10:54:02PM +, Christoph Hellwig wrote: this doesn't look like a full first class flag to me yet. Don't we need to check for buffer_unwritten in the places we're checking for buffer_delay so we can stop setting buffer_delay for unwritten buffers? That would be