Re: [PATCH] dio: remove bogus refcounting BUG_ON

2007-07-05 Thread Zach Brown
the BUG_ON(). But unfortunately, our perf. team is able reproduce the problem. What are they doing to reproduce it? How much setup does it take? Debug indicated that, the ret2 == 1 :( That could be consistent with the theory that we're racing with the dio struct being freed and reused

Re: [PATCH] dio: remove bogus refcounting BUG_ON

2007-07-05 Thread Badari Pulavarty
On Thu, 2007-07-05 at 10:11 -0700, Zach Brown wrote: the BUG_ON(). But unfortunately, our perf. team is able reproduce the problem. What are they doing to reproduce it? How much setup does it take? Huge OLTP run :( Debug indicated that, the ret2 == 1 :( That could be consistent

Re: [PATCH] dio: remove bogus refcounting BUG_ON

2007-07-04 Thread Badari Pulavarty
On Tue, 2007-07-03 at 15:28 -0700, Zach Brown wrote: Linus, Andrew, please apply the bug fix patch at the end of this reply for .22. One of our perf. team ran into this while doing some runs. I didn't see anything obvious - it looks like we converted async IO to synchronous one. I didn't

Re: [PATCH] dio: remove bogus refcounting BUG_ON

2007-07-04 Thread Suparna Bhattacharya
On Wed, Jul 04, 2007 at 07:25:10PM -0700, Badari Pulavarty wrote: On Tue, 2007-07-03 at 15:28 -0700, Zach Brown wrote: Linus, Andrew, please apply the bug fix patch at the end of this reply for .22. One of our perf. team ran into this while doing some runs. I didn't see anything

[PATCH] dio: remove bogus refcounting BUG_ON

2007-07-03 Thread Zach Brown
Linus, Andrew, please apply the bug fix patch at the end of this reply for .22. One of our perf. team ran into this while doing some runs. I didn't see anything obvious - it looks like we converted async IO to synchronous one. I didn't spend much time digging around. OK, I think this