Re: [PATCH 14/14] NFS: Use local caching [try #2]

2007-08-10 Thread David Howells
Trond Myklebust [EMAIL PROTECTED] wrote: Dang, that's a lot of inlines... AFAICS, approx half of fs/nfs/fscache.h should really be moved into fscache.c. If you wish. It seems a shame since a lot of them have only one caller. ...however it also forces you to export a lot of stuff

[PATCH 14/14] NFS: Use local caching [try #2]

2007-08-09 Thread David Howells
The attached patch makes it possible for the NFS filesystem to make use of the network filesystem local caching service (FS-Cache). To be able to use this, an updated mount program is required. This can be obtained from: http://people.redhat.com/steved/cachefs/util-linux/ To mount an

Re: [PATCH 14/14] NFS: Use local caching [try #2]

2007-08-09 Thread Trond Myklebust
Dang, that's a lot of inlines... AFAICS, approx half of fs/nfs/fscache.h should really be moved into fscache.c. Otherwise, this looks a lot less intrusive than previous patches. See inlined comments. On Thu, 2007-08-09 at 17:05 +0100, David Howells wrote: The attached patch makes it possible

Re: [PATCH 14/14] NFS: Use local caching [try #2]

2007-08-09 Thread David Howells
Trond Myklebust [EMAIL PROTECTED] wrote: Dang, that's a lot of inlines... AFAICS, approx half of fs/nfs/fscache.h should really be moved into fscache.c. If you wish. It seems a shame since a lot of them have only one caller. + /* we can do this here as the bits are only set with the page

Re: [PATCH 14/14] NFS: Use local caching [try #2]

2007-08-09 Thread David Howells
Instead, feel free to update the text-based mount interface (which can be found in 2.6.23-rc1 and later). I presume you're referring to nfs_mount_option_tokens[] and friends. Is there a mount program that can drive this? David - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 14/14] NFS: Use local caching [try #2]

2007-08-09 Thread Trond Myklebust
On Thu, 2007-08-09 at 19:52 +0100, David Howells wrote: Trond Myklebust [EMAIL PROTECTED] wrote: Dang, that's a lot of inlines... AFAICS, approx half of fs/nfs/fscache.h should really be moved into fscache.c. If you wish. It seems a shame since a lot of them have only one caller.